- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Verifying storage space for AddDiskCommand
by amureini＠redhat.com 08 Dec '13

08 Dec '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Verifying storage space for AddDiskCommand ...................................................................... core: Verifying storage space for AddDiskCommand This is the first in a series of patches intended to fix storage space allocation validation throught the system (see bz). Added hasSpaceForNewDisk(s) in StorageDomainValidator. Added test - StorageDomainValidatorFreeSpaceTest. Applied use in AddDiskCommand (former use is buggy). Amended AddDiskToVmCommandTest. Previous tests simulated several space situations. These are now thoroughly tested in StorageDomainValidatorFreeSpaceTest, where they belong, and therefore removed from the command test. What's left to test is that the command actually behaves according to the validator's response. To that end added two new tests. Also amended AddDiskCommand CDA to always check for threshold limits (not only preallocated) since we want to have this leeway. Bug-url: https://bugzilla.redhat.com/960934 Change-Id: I1a33502683ec77fba09efffba1438beb552082f7 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/StorageDomainValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddDiskToVmCommandTest.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/StorageDomainValidatorFreeSpaceTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/StorageDomainValidatorTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DiskImage.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomain.java 7 files changed, 175 insertions(+), 64 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15377 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1a33502683ec77fba09efffba1438beb552082f7 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Use longs to represent dates in QueryData
by amureini＠redhat.com 08 Dec '13

08 Dec '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Use longs to represent dates in QueryData ...................................................................... core: Use longs to represent dates in QueryData Use longs representing the amount of milliseconds since the epoch instead of Data instances in order to prevent accidental change of QueryData's internal members externally. Besides being a good defensive practice, this patch solves the EI_EXPOSE_REP and EI_EXPOSE_REP2 FindBugs warnings on this class. Change-Id: I9eb83c123a4fd9a1b2abc3bdb74d91a1391245d2 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/QueryData.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java 2 files changed, 5 insertions(+), 7 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22144 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9eb83c123a4fd9a1b2abc3bdb74d91a1391245d2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Fix typo
by dfediuck＠redhat.com 08 Dec '13

08 Dec '13

Doron Fediuck has submitted this change and it was merged. Change subject: engine: Fix typo ...................................................................... engine: Fix typo Thiss patch fixes a minor spelling issue in MoM policy synchronization; Cluster--> Host --> "Synch Mom Policy" should be "Sync MoM Policy". Change-Id: I325c14e8b5c3fc97d6293d80a7f05d68fe89a1b9 Bug-Url: https://bugzilla.redhat.com/1039275 Signed-off-by: Doron Fediuck <dfediuck(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Doron Fediuck: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22168 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I325c14e8b5c3fc97d6293d80a7f05d68fe89a1b9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: frontend: remove unused method NotifyRetrieved from Registra...
by tnisan＠redhat.com 08 Dec '13

08 Dec '13

Tal Nisan has submitted this change and it was merged. Change subject: frontend: remove unused method NotifyRetrieved from RegistrationResult ...................................................................... frontend: remove unused method NotifyRetrieved from RegistrationResult The method was causing a findbug warning by starting with capital letter. Since it was not in use, better to remove it than rename. Change-Id: I53d6e76f4446b9c93a203a966a9576f2a20f1dee Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/RegistrationResult.java 1 file changed, 0 insertions(+), 5 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22165 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I53d6e76f4446b9c93a203a966a9576f2a20f1dee Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: fix findbug warning in volumes tab
by kmayilsa＠redhat.com 08 Dec '13

08 Dec '13

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin: fix findbug warning in volumes tab ...................................................................... webadmin: fix findbug warning in volumes tab Removed the unused field. Change-Id: I555f3409391616441f9731853fda886a719a20a3 Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/VolumeBrickStatusCell.java 1 file changed, 0 insertions(+), 3 deletions(-) Approvals: Kanagaraj M: Verified Gilad Chaplik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22166 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I555f3409391616441f9731853fda886a719a20a3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.3]: core: get cd path only when the VM isn't the hosted engine
by iheim＠redhat.com 08 Dec '13

08 Dec '13

Itamar Heim has submitted this change and it was merged. Change subject: core: get cd path only when the VM isn't the hosted engine ...................................................................... core: get cd path only when the VM isn't the hosted engine When the VM we wish to change disk to is the hosted engine VM, getting the CD path fails, as this VM isn't managed by the engine. For that reason, this patch moves this logic to after we know it is not the hosted engine. In addition, it is good to do that not in the constructor but after some validation is done, as it is less error prone. Change-Id: Ie94993f2f43b5c3d2658542f38292b0d8c5503b3 Bug-Url: https://bugzilla.redhat.com/1014030 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeDiskCommand.java 1 file changed, 9 insertions(+), 8 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Oved Ourfali: Verified -- To view, visit http://gerrit.ovirt.org/22164 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie94993f2f43b5c3d2658542f38292b0d8c5503b3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: uicompat: remove unused parameter Dispatcher in TaskContext ...
by tnisan＠redhat.com 08 Dec '13

08 Dec '13

Tal Nisan has submitted this change and it was merged. Change subject: uicompat: remove unused parameter Dispatcher in TaskContext ctor ...................................................................... uicompat: remove unused parameter Dispatcher in TaskContext ctor Change-Id: Ica3b7f7ff0265a520e041d6bd88fe5825428d287 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Task.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/TaskContext.java 2 files changed, 2 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22163 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ica3b7f7ff0265a520e041d6bd88fe5825428d287 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: get cd path only when the VM isn't the hosted engine
by ofrenkel＠redhat.com 08 Dec '13

08 Dec '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: get cd path only when the VM isn't the hosted engine ...................................................................... core: get cd path only when the VM isn't the hosted engine When the VM we wish to change disk to is the hosted engine VM, getting the CD path fails, as this VM isn't managed by the engine. For that reason, this patch moves this logic to after we know it is not the hosted engine. In addition, it is good to do that not in the constructor but after some validation is done, as it is less error prone. Change-Id: Ie94993f2f43b5c3d2658542f38292b0d8c5503b3 Bug-Url: https://bugzilla.redhat.com/1014030 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeDiskCommand.java 1 file changed, 9 insertions(+), 8 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22081 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie94993f2f43b5c3d2658542f38292b0d8c5503b3 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Remove VdcException
by amureini＠redhat.com 08 Dec '13

08 Dec '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove VdcException ...................................................................... core: Remove VdcException This exception is not used anywhere in the codebase, and can safely be removed. Change-Id: I376f853585c18e36f6e2ee6d57c617851b329480 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- D backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/VdcException.java 1 file changed, 0 insertions(+), 18 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22105 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I376f853585c18e36f6e2ee6d57c617851b329480 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: EvenDistributionBalancePolicyUnit's comparators
by amureini＠redhat.com 08 Dec '13

08 Dec '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: EvenDistributionBalancePolicyUnit's comparators ...................................................................... core: EvenDistributionBalancePolicyUnit's comparators Fixed modifiers in these comparators to increase performance and fix the MS_SHOULD_BE_FINAL FindBugs warnings on these classes. Change-Id: Ice42566f82dccfb66624d7054b52948220ced3ea Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/EvenDistributionBalancePolicyUnit.java 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22147 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ice42566f82dccfb66624d7054b52948220ced3ea Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0