- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Fill and check arch when importing VM and Template
by rgolan＠redhat.com 08 Dec '13

08 Dec '13

Roy Golan has submitted this change and it was merged. Change subject: core: Fill and check arch when importing VM and Template ...................................................................... core: Fill and check arch when importing VM and Template * On importing VM and Template, its architecture must match with cluster architecture, otherwise an error must be displayed. It's being checked in the import command for each one. * On importing OVF files, the same validation is necessary, and filling the architecture for VM and Template is necessary. The architecture is filled based on the OS architecture, otherwise the architecture will be undefined. * If VM or Template has undefined architecture, it cannot be imported, so a error message is displayed when trying to import it. Change-Id: I6ac6093e253225f801e216310828a7afba73f9e6 Signed-off-by: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br> Signed-off-by: Vitor de Lima <vitor.lima(a)eldorado.org.br> Signed-off-by: Gustavo Pedrosa <gustavo.pedrosa(a)eldorado.org.br> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVmTemplateCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfTemplateReader.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmReader.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ovf/OvfManagerTest.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 11 files changed, 92 insertions(+), 10 deletions(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18702 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6ac6093e253225f801e216310828a7afba73f9e6 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br> Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vitor.lima(a)eldorado.org.br> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: CreateVDSCommand Logging message does not report NIC...
by emesika＠redhat.com 08 Dec '13

08 Dec '13

Eli Mesika has submitted this change and it was merged. Change subject: engine: CreateVDSCommand Logging message does not report NIC devices ...................................................................... engine: CreateVDSCommand Logging message does not report NIC devices Network and other devices are not written to the log file in CreateVDSCommand. Change-Id: I9aa08e4064c62d034fe769b0df65f20fc6b4fd8f Bug-Url: https://bugzilla.redhat.com/1036885 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22110 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9aa08e4064c62d034fe769b0df65f20fc6b4fd8f Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Fix compilation problem
by amureini＠redhat.com 08 Dec '13

08 Dec '13

Allon Mureinik has submitted this change and it was merged. Change subject: webadmin: Fix compilation problem ...................................................................... webadmin: Fix compilation problem Change-Id: Ia5bd68af043f839b4f7451d15e41a23c7f4888f7 Signed-off-by: Sergey Gotliv <sgotliv(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sergey Gotliv: Verified Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22137 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia5bd68af043f839b4f7451d15e41a23c7f4888f7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Show only compatible OSes
by rgolan＠redhat.com 08 Dec '13

08 Dec '13

Roy Golan has submitted this change and it was merged. Change subject: webadmin: Show only compatible OSes ...................................................................... webadmin: Show only compatible OSes This change modifies the frontend to show only OSes compatible with the architecture of the VM or pool being created. Change-Id: I19f5a2fa8ca6a54e75f4ff64c4b6189db13ed25d Signed-off-by: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br> Signed-off-by: Gustavo Pedrosa <gustavo.pedrosa(a)eldorado.org.br> Signed-off-by: Vitor de Lima <vitor.lima(a)eldorado.org.br> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/OsRepositoryQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/osinfo/OsRepository.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/OsQueryParameters.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/OsRepositoryImpl.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewTemplateVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/PoolModelBehaviorBase.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/TemplateVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java 13 files changed, 126 insertions(+), 12 deletions(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17972 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I19f5a2fa8ca6a54e75f4ff64c4b6189db13ed25d Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <vitor.lima(a)eldorado.org.br> Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br> Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vitor.lima(a)eldorado.org.br> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: New OS for IBM POWER support
by rgolan＠redhat.com 08 Dec '13

08 Dec '13

Roy Golan has submitted this change and it was merged. Change subject: core: New OS for IBM POWER support ...................................................................... core: New OS for IBM POWER support This change introduces an operating system which contains the characteristics of the IBM POWER architecture. It includes also some information about disk interfaces that will be used in other following patches. Change-Id: I35298c31cfa55f212c2d8b4016ee3019d7b28c40 Signed-off-by: Vitor de Lima <vitor.lima(a)eldorado.org.br> Signed-off-by: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br> Signed-off-by: Gustavo Pedrosa <gustavo.pedrosa(a)eldorado.org.br> --- M packaging/conf/osinfo-defaults.properties 1 file changed, 15 insertions(+), 2 deletions(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18220 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I35298c31cfa55f212c2d8b4016ee3019d7b28c40 Gerrit-PatchSet: 17 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <vitor.lima(a)eldorado.org.br> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vitor.lima(a)eldorado.org.br> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: gluster: add Host UUID to volume status
by kmayilsa＠redhat.com 07 Dec '13

07 Dec '13

Kanagaraj M has submitted this change and it was merged. Change subject: gluster: add Host UUID to volume status ...................................................................... gluster: add Host UUID to volume status Added host_uuid to service details of volume status. This can used to easily map the service details output with host details availble in engine, instead of comparing the ipaddress/hostname. Change-Id: I9cda0b69e3067d71d7c0fb8d71211a47691a68f5 Bug-Url: https://bugzilla.redhat.com/885592 Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeAdvancedDetailsQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterServerService.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterDBUtils.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterVolumeStatusReturnForXmlRpc.java 4 files changed, 45 insertions(+), 2 deletions(-) Approvals: Kanagaraj M: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21599 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9cda0b69e3067d71d7c0fb8d71211a47691a68f5 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.0]: Allow editing the VM mac address
by sbonazzo＠redhat.com 06 Dec '13

06 Dec '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: Allow editing the VM mac address ...................................................................... Allow editing the VM mac address In order to give the user control of IP address assignment in DHCP environments it is important to allow the MAC address to be specified explicitly. Make MAC address a customizable parameter while still suggesting a default value for users who may not care. Change-Id: Ie75af322fc403809e0b044eb13561e6d16e1c4d4 Signed-off-by: Adam Litke <alitke(a)redhat.com> Bug-url: https://bugzilla.redhat.com/show_bug.cgi?id=1034706 --- M src/ovirt_hosted_engine_setup/constants.py M src/ovirt_hosted_engine_setup/util.py M src/plugins/ovirt-hosted-engine-setup/vm/Makefile.am M src/plugins/ovirt-hosted-engine-setup/vm/__init__.py M src/plugins/ovirt-hosted-engine-setup/vm/configurevm.py A src/plugins/ovirt-hosted-engine-setup/vm/mac.py 6 files changed, 131 insertions(+), 4 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22125 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie75af322fc403809e0b044eb13561e6d16e1c4d4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.0 Gerrit-Owner: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core, webadmin: add isVm and isTemplate methods to VmEntityType
by ofrenkel＠redhat.com 06 Dec '13

06 Dec '13

Omer Frenkel has submitted this change and it was merged. Change subject: core,webadmin: add isVm and isTemplate methods to VmEntityType ...................................................................... core,webadmin: add isVm and isTemplate methods to VmEntityType Since now there are more types for VmEntityType (like instance type), code that check for these types need to be updated. Since the new entities are just types of templates, and looking fwd we might add more like these, looks like caller only want to know if this is a vm or a template. So I added methods for easier reference, and changed all references to specific types to the right method. Change-Id: I6fc92031ab0afd08ab309a8ef6fd71a3fddb2204 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmEntityType.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/disks/DisksViewColumns.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/disks/DiskListModel.java 5 files changed, 44 insertions(+), 26 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21598 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6fc92031ab0afd08ab309a8ef6fd71a3fddb2204 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-setup[master]: Allow editing the VM mac address
by sbonazzo＠redhat.com 06 Dec '13

06 Dec '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: Allow editing the VM mac address ...................................................................... Allow editing the VM mac address In order to give the user control of IP address assignment in DHCP environments it is important to allow the MAC address to be specified explicitly. Make MAC address a customizable parameter while still suggesting a default value for users who may not care. Change-Id: Ie75af322fc403809e0b044eb13561e6d16e1c4d4 Signed-off-by: Adam Litke <alitke(a)redhat.com> Bug-url: https://bugzilla.redhat.com/show_bug.cgi?id=1034706 --- M src/ovirt_hosted_engine_setup/constants.py M src/ovirt_hosted_engine_setup/util.py M src/plugins/ovirt-hosted-engine-setup/vm/Makefile.am M src/plugins/ovirt-hosted-engine-setup/vm/__init__.py M src/plugins/ovirt-hosted-engine-setup/vm/configurevm.py A src/plugins/ovirt-hosted-engine-setup/vm/mac.py 6 files changed, 131 insertions(+), 4 deletions(-) Approvals: Adam Litke: Verified Sandro Bonazzola: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22112 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie75af322fc403809e0b044eb13561e6d16e1c4d4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3.2]: packaging: setup: aio: fix ssh issues
by iheim＠redhat.com 06 Dec '13

06 Dec '13

Itamar Heim has submitted this change and it was merged. Change subject: packaging: setup: aio: fix ssh issues ...................................................................... packaging: setup: aio: fix ssh issues 1. If ~root/.ssh is missing and selinux enabled, it will be created without proper selinux attributes, causing ssh to fail. 2. If ~root/.ssh is missing it is created using mode 0755 and not 0700. 3. Validate /etc/ssh/sshd_config, if PermitRootLogin is no then fail early. Buf-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1036209 Change-Id: Icfe55ccf4535792fed69912553d86a53dec3764b Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/constants.py M packaging/setup/plugins/ovirt-engine-setup/all-in-one/sshd.py M packaging/setup/plugins/ovirt-engine-setup/all-in-one/vdsm.py 3 files changed, 57 insertions(+), 0 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Sandro Bonazzola: Verified; Looks good to me, but someone else must approve Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22120 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icfe55ccf4535792fed69912553d86a53dec3764b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3.2 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: r herrold <herrold(a)owlriver.com>

1 0