- Engine-commits - oVirt List Archives

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.0]: hosted-engine: Update usage info and handle sub-command help
by sbonazzo＠redhat.com 06 Dec '13

06 Dec '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: hosted-engine: Update usage info and handle sub-command help ...................................................................... hosted-engine: Update usage info and handle sub-command help The hosted-engine command uses sub-commands and the current arg parsing leads to some odd and confusing side effects. Update the usage message to make the invocation a bit clearer. Handle sub-command specific help (<command> --help) explicitly in each sub-command function. Signed-off-by: Adam Litke <alitke(a)redhat.com> Change-Id: I7323022994b0225b0b319d0b402c0fd755b8da78 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1038626 --- M man/hosted-engine.8 M src/bin/hosted-engine.in M src/plugins/ovirt-hosted-engine-setup/vm/runvm.py 3 files changed, 312 insertions(+), 178 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22123 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7323022994b0225b0b319d0b402c0fd755b8da78 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.0 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: packaging: setup: aio: fix ssh issues
by iheim＠redhat.com 06 Dec '13

06 Dec '13

Itamar Heim has submitted this change and it was merged. Change subject: packaging: setup: aio: fix ssh issues ...................................................................... packaging: setup: aio: fix ssh issues 1. If ~root/.ssh is missing and selinux enabled, it will be created without proper selinux attributes, causing ssh to fail. 2. If ~root/.ssh is missing it is created using mode 0755 and not 0700. 3. Validate /etc/ssh/sshd_config, if PermitRootLogin is no then fail early. Buf-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1036209 Change-Id: Icfe55ccf4535792fed69912553d86a53dec3764b Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/constants.py M packaging/setup/plugins/ovirt-engine-setup/all-in-one/sshd.py M packaging/setup/plugins/ovirt-engine-setup/all-in-one/vdsm.py 3 files changed, 57 insertions(+), 0 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22119 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icfe55ccf4535792fed69912553d86a53dec3764b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: r herrold <herrold(a)owlriver.com>

1 0

Change in ovirt-engine[master]: packaging: setup: aio: fix ssh issues
by sbonazzo＠redhat.com 06 Dec '13

06 Dec '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: aio: fix ssh issues ...................................................................... packaging: setup: aio: fix ssh issues 1. If ~root/.ssh is missing and selinux enabled, it will be created without proper selinux attributes, causing ssh to fail. 2. If ~root/.ssh is missing it is created using mode 0755 and not 0700. 3. Validate /etc/ssh/sshd_config, if PermitRootLogin is no then fail early. Buf-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1036209 Change-Id: Icfe55ccf4535792fed69912553d86a53dec3764b Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/constants.py M packaging/setup/plugins/ovirt-engine-setup/all-in-one/sshd.py M packaging/setup/plugins/ovirt-engine-setup/all-in-one/vdsm.py 3 files changed, 57 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21874 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icfe55ccf4535792fed69912553d86a53dec3764b Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-Reviewer: r herrold <herrold(a)owlriver.com>

1 0

Change in ovirt-engine[master]: frontend: Refactored ClusterModel to use generics
by tjelinek＠redhat.com 06 Dec '13

06 Dec '13

Tomas Jelinek has submitted this change and it was merged. Change subject: frontend: Refactored ClusterModel to use generics ...................................................................... frontend: Refactored ClusterModel to use generics Change-Id: Ib639a20cc718f7e8479627772002507cef04ad53 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterGuideModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/AddClusterRM.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/ConfigureLocalStorageModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostConfigureLocalStoragePopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostConfigureLocalStoragePopupView.ui.xml 9 files changed, 313 insertions(+), 321 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21869 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib639a20cc718f7e8479627772002507cef04ad53 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: build: fix parallel make issue
by sbonazzo＠redhat.com 06 Dec '13

06 Dec '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: build: fix parallel make issue ...................................................................... packaging: build: fix parallel make issue Change-Id: I91962ffc5396433cf670174cd757617b4b405c63 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M Makefile 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22111 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I91962ffc5396433cf670174cd757617b4b405c63 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Set brick port and pid when returned
by kmayilsa＠redhat.com 06 Dec '13

06 Dec '13

Kanagaraj M has submitted this change and it was merged. Change subject: engine: Set brick port and pid when returned ...................................................................... engine: Set brick port and pid when returned When gluster process is restarted, the gluster CLI returns the brick port as NA. This causes the VDS xml return handler to fail as the brick port is expected as an integer value. Added code to set the int values only if returned correctly. If brick port is N/A then brick's status should be set offline. Change-Id: I544b0aa4705b4bcde7638f15b5b235ba10deb3b1 Bug-Url: https://bugzilla.redhat.com/1036039 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterVolumeStatusReturnForXmlRpc.java 1 file changed, 12 insertions(+), 6 deletions(-) Approvals: Kanagaraj M: Looks good to me, approved Sahina Bose: Verified -- To view, visit http://gerrit.ovirt.org/21908 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I544b0aa4705b4bcde7638f15b5b235ba10deb3b1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: fix add-bricks validation in volume creation
by kmayilsa＠redhat.com 06 Dec '13

06 Dec '13

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin: fix add-bricks validation in volume creation ...................................................................... webadmin: fix add-bricks validation in volume creation If the user chooses 'Distributed Replicate' or 'Distributed Stripe' during volume creation, an error will be showm if the brick count is not equal to multiple of replica or stripe count respectively. Change-Id: I3adc50b09f7c246bda0fcd63c906a8c726f5a3aa Bug-Url: https://bugzilla.redhat.com/886478 Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeBrickModel.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Kanagaraj M: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22077 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3adc50b09f7c246bda0fcd63c906a8c726f5a3aa Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: gluster: Proper checking before retriving volume in eventMes...
by kmayilsa＠redhat.com 06 Dec '13

06 Dec '13

Kanagaraj M has submitted this change and it was merged. Change subject: gluster: Proper checking before retriving volume in eventMessageLogger ...................................................................... gluster: Proper checking before retriving volume in eventMessageLogger While retriving volume sometimes it may cause null pointer exception. So volume is retrived after proper checking. Change-Id: I78367afc8771b2adb6b653f5d23bdbfe28e126d2 Signed-off-by: ndarshan <dnarayan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/tasks/GlusterTaskUtils.java 1 file changed, 10 insertions(+), 2 deletions(-) Approvals: Kanagaraj M: Looks good to me, approved Darshan N: Verified -- To view, visit http://gerrit.ovirt.org/21949 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I78367afc8771b2adb6b653f5d23bdbfe28e126d2 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Darshan N <dnarayan(a)redhat.com> Gerrit-Reviewer: Darshan N <dnarayan(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in mom[master]: HostKSM: Detect missing pgrep and log an error
by alitke＠redhat.com 05 Dec '13

05 Dec '13

Adam Litke has submitted this change and it was merged. Change subject: HostKSM: Detect missing pgrep and log an error ...................................................................... HostKSM: Detect missing pgrep and log an error If pgrep is missing on the system the HostKSM Collector will silently fail and MOM will exit. This is just a CollectionError so catch the condition and raise the proper exception. Change-Id: Iae678edaac5560d0066ebde1a0da6f610e48fb02 Signed-off-by: Adam Litke <alitke(a)redhat.com> Reviewed-on: http://gerrit.ovirt.org/22087 Reviewed-by: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Reviewed-by: Martin Sivák <msivak(a)redhat.com> --- M mom.spec.in M mom/Collectors/HostKSM.py 2 files changed, 5 insertions(+), 1 deletion(-) Approvals: Piotr Kliczewski: Looks good to me, but someone else must approve Adam Litke: Verified; Looks good to me, approved Martin Sivák: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/22087 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iae678edaac5560d0066ebde1a0da6f610e48fb02 Gerrit-PatchSet: 2 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>

1 0

Change in mom[master]: Do not crash when collector returns no data
by alitke＠redhat.com 05 Dec '13

05 Dec '13

Adam Litke has submitted this change and it was merged. Change subject: Do not crash when collector returns no data ...................................................................... Do not crash when collector returns no data Change-Id: Ie99d9ec4c063f88cc5dd58c844f5c2a200d35a0b Signed-off-by: Martin Sivak <msivak(a)redhat.com> Reviewed-on: http://gerrit.ovirt.org/22097 Reviewed-by: Adam Litke <alitke(a)redhat.com> --- M mom/Monitor.py 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: Adam Litke: Looks good to me, approved Martin Sivák: Verified -- To view, visit http://gerrit.ovirt.org/22097 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie99d9ec4c063f88cc5dd58c844f5c2a200d35a0b Gerrit-PatchSet: 3 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>

1 0