- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: add missing mock of config value in GlusterServiceSync...
by tnisan＠redhat.com 03 Nov '13

03 Nov '13

Tal Nisan has submitted this change and it was merged. Change subject: core: add missing mock of config value in GlusterServiceSyncJobTest ...................................................................... core: add missing mock of config value in GlusterServiceSyncJobTest Change-Id: I0600ba1200a65c3931d4a7e40152966a8c5eb40b Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GlusterServiceSyncJobTest.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20780 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0600ba1200a65c3931d4a7e40152966a8c5eb40b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <liran.zelkha(a)gmail.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: remove unused code.
by tnisan＠redhat.com 03 Nov '13

03 Nov '13

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: remove unused code. ...................................................................... webadmin: remove unused code. Fix dead local store warnings in findbugs Change-Id: I8121d34d3ea991727fe7664eb66a4cbd8cd045b8 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/AddDataCenterRM.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewTemplateVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UserPortalNewVmModelBehavior.java 3 files changed, 2 insertions(+), 6 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Alissa Bonas: Verified -- To view, visit http://gerrit.ovirt.org/20816 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8121d34d3ea991727fe7664eb66a4cbd8cd045b8 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: webadmin: Rendered checkbox headers resizeable
by iheim＠redhat.com 03 Nov '13

03 Nov '13

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: Rendered checkbox headers resizeable ...................................................................... webadmin: Rendered checkbox headers resizeable Previously, CheckboxHeader wasn't resizeable. Created a class ResizeableCheckboxHeader to fix this, a wrapper for CheckboxHeader that inherits from ResizableHeader (classic case for multiple inheritance, but used composition due to Java limitations). A CheckboxHeader is automatically wrapped with a ResizeableCheckboxHeader when it is added to a ColumnResizeCellTable that has column resizing enabled, as in such a case it would be expected that the checkbox headers are resizeable as well. Change-Id: Ie442350893282e7838e5216d277718e654f1d884 Bug-Url: https://bugzilla.redhat.com/1009745 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/SafeHtmlCellWithTooltip.java R frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/header/CheckboxHeader.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/header/ResizeableCheckboxHeader.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/resize/ColumnResizeCellTable.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/resize/ResizableHeader.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/AbstractNetworkPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterManageNetworkPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/provider/ImportNetworksPopupView.java 8 files changed, 67 insertions(+), 13 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20698 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie442350893282e7838e5216d277718e654f1d884 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: core: adding a filter policy for CPU level
by iheim＠redhat.com 03 Nov '13

03 Nov '13

Itamar Heim has submitted this change and it was merged. Change subject: core: adding a filter policy for CPU level ...................................................................... core: adding a filter policy for CPU level Change-Id: Ib42b803fe0d2e9389d10196cd44c3fd21342927f Bug-Url: https://bugzilla.redhat.com/1006209 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/PolicyUnitImpl.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/CpuLevelFilterPolicyUnit.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties A packaging/dbscripts/upgrade/03_03_0990_add_cpu_level_policy_unit.sql 8 files changed, 67 insertions(+), 0 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20233 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib42b803fe0d2e9389d10196cd44c3fd21342927f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: core: saving the cpu_name in vm_dynamic
by iheim＠redhat.com 03 Nov '13

03 Nov '13

Itamar Heim has submitted this change and it was merged. Change subject: core: saving the cpu_name in vm_dynamic ...................................................................... core: saving the cpu_name in vm_dynamic This patch adds the cpu_name property to the vm_dynamic table, to allow knowing what cpu was configured in the cluster when running the VM Change-Id: I2f13891b3425e4864334851ecb12d1d61a162082 Bug-Url: https://bugzilla.redhat.com/1006209 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RunVmCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDynamic.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDynamicDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java M packaging/dbscripts/create_views.sql A packaging/dbscripts/upgrade/03_03_0980_add_cpu_name_to_vm_dynamic.sql M packaging/dbscripts/vms_sp.sql 12 files changed, 48 insertions(+), 11 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20232 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2f13891b3425e4864334851ecb12d1d61a162082 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: utils: ForwardServlet: fix generic forward to use path info
by vszocs＠redhat.com 31 Oct '13

31 Oct '13

Vojtech Szocs has submitted this change and it was merged. Change subject: utils: ForwardServlet: fix generic forward to use path info ...................................................................... utils: ForwardServlet: fix generic forward to use path info requestURI is no good as we may need to forward into different uris. cleanup serlvet initialization. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=961677 Change-Id: I7307d57792fb966c8acb6ac0bdcad9302c0e3a65 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/services/src/main/webapp/WEB-INF/web.xml M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/servlet/ForwardServlet.java 2 files changed, 17 insertions(+), 20 deletions(-) Approvals: Alon Bar-Lev: Verified Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20784 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7307d57792fb966c8acb6ac0bdcad9302c0e3a65 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: rearrange product uris
by vszocs＠redhat.com 31 Oct '13

31 Oct '13

Vojtech Szocs has submitted this change and it was merged. Change subject: core: rearrange product uris ...................................................................... core: rearrange product uris MISSION Advanced farther into well behaved web application, install as much as we can into /ovirt-engine URI name space, removing / abuse. Synchronize between jboss and apache URI layouts so that development setup will be as similar as possible to production. NEW LAYOUT -+- / (root.war) Redirect: ovirt-engine | +--- api/ (api.war) | +-+- ovirt-engine/ (welcome.war) [NEW] | | | +--- docs/ (docs.war) [NEW] | | | +-+- services(services.war) [NEW] | | | | | +-+- attachment/ | | | | | +-+- files/ | | | | | +--- get-session-user | | | | | +--- health | | | | | +--- host-register | | | | | +--- pki-resource | | | | | +--- reports-redirect | | | +--- userportal/ (userportal.war) | | | +--- webadmin/ (webadmin.war) | +-+- OvirtEngineWeb/ | | | +--- HealthStatus.aspx Forward: ovirt-engine/services/health | | | +--- HealthStatus/* Forward: ovirt-engine/services/health | | | +--- VdsAutoRegistration.aspx Forward: ovirt-engine/services/host-register | | | +--- register Forward: ovirt-engine/services/host-register | +-+- RHEVManagerWeb/ | | | +--- VdsAutoRegistration.aspx Forward: ovirt-engine/services/host-register | +--- ca.crt Forward: ovirt-engine/serivces/pki-resource | +--- engine.ssh.key.txt Forward: ovirt-engine/serivces/pki-resource | +--- rhevm.ssh.key.txt Forward: ovirt-engine/serivces/pki-resource LAYOUT NOTES HealthStatus servlet is used by python using urllib2 which supports redirect, it does not accept extra path, so it is redirected into servlet at services. Registration uses python httplib which does not support redirect, so these uris are forwarded into servlets at services. /ValidateSession is gone as reports can be modified to support the new servlet name at /services/get-session-user. GWT NOTES - Generate GWT files in-place so that application name is user friendly and there is no extra nesting, so we end up with: /ovirt-engine/webadmin /ovirt-engine/userportal - Added client side BaseContextPathData class to read base context path from host page. CONFIGURATION ENGINE_URI was added to be able to configure URI at runtime, jboss upstream has some bugs regarding variable substitution within resources, once this is resolved we can have fully configured URI. Change-Id: I9cb4822f6bf4d372715e12858635db5ed3edd115 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=961677 Signed-off-by: Alexander Wels <awels(a)redhat.com> Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- A backend/manager/modules/docs/exclude-filters.xml A backend/manager/modules/docs/pom.xml A backend/manager/modules/docs/src/main/resources/META-INF/MANIFEST.MF R backend/manager/modules/docs/src/main/resources/messages.properties R backend/manager/modules/docs/src/main/webapp/WEB-INF/no_lang.jsp A backend/manager/modules/docs/src/main/webapp/WEB-INF/web.xml M backend/manager/modules/pom.xml D backend/manager/modules/root/exclude-filters.xml M backend/manager/modules/root/pom.xml D backend/manager/modules/root/src/main/java/org/ovirt/engine/core/pki/PKIResourceServlet.java M backend/manager/modules/root/src/main/resources/META-INF/MANIFEST.MF M backend/manager/modules/root/src/main/webapp/WEB-INF/web.xml A backend/manager/modules/services/exclude-filters.xml A backend/manager/modules/services/pom.xml R backend/manager/modules/services/src/main/java/org/ovirt/engine/core/services/GetAttachmentServlet.java R backend/manager/modules/services/src/main/java/org/ovirt/engine/core/services/GetSessionUser.java R backend/manager/modules/services/src/main/java/org/ovirt/engine/core/services/HealthStatus.java A backend/manager/modules/services/src/main/java/org/ovirt/engine/core/services/PKIResourceServlet.java R backend/manager/modules/services/src/main/java/org/ovirt/engine/core/services/RegisterServlet.java R backend/manager/modules/services/src/main/java/org/ovirt/engine/core/services/ReportsRedirectServlet.java A backend/manager/modules/services/src/main/resources/META-INF/MANIFEST.MF A backend/manager/modules/services/src/main/webapp/WEB-INF/web.xml R backend/manager/modules/services/src/main/webapp/novnc-main.html R backend/manager/modules/services/src/main/webapp/spicehtml5-main.html M backend/manager/modules/utils/exclude-filters.xml R backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/servlet/DocsServlet.java R backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/servlet/FileServlet.java A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/servlet/ForwardServlet.java D backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/servlet/PageNotFoundForwardServlet.java A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/servlet/RedirectServlet.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/servlet/ServletUtils.java R backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/servlet/DocsServletTest.java R backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/servlet/FileServletTest.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/servlet/ServletUtilsTest.java R backend/manager/modules/utils/src/test/resources/org/ovirt/engine/core/utils/servlet/filetest/en-US/index.html R backend/manager/modules/utils/src/test/resources/org/ovirt/engine/core/utils/servlet/filetest/fr/index.html R backend/manager/modules/utils/src/test/resources/org/ovirt/engine/core/utils/servlet/filetest/index.html A backend/manager/modules/welcome/pom.xml R backend/manager/modules/welcome/src/main/java/org/ovirt/engine/core/WelcomeServlet.java A backend/manager/modules/welcome/src/main/resources/META-INF/MANIFEST.MF A backend/manager/modules/welcome/src/main/resources/messages.properties R backend/manager/modules/welcome/src/main/webapp/WEB-INF/404.jsp R backend/manager/modules/welcome/src/main/webapp/WEB-INF/ovirt-engine.jsp A backend/manager/modules/welcome/src/main/webapp/WEB-INF/web.xml R backend/manager/modules/welcome/src/main/webapp/splash.js R backend/manager/modules/welcome/src/test/java/org/ovirt/engine/core/WelcomeServletTest.java M ear/pom.xml M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/GwtDynamicHostPageServlet.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/UserPortalHostPageServlet.java A frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/utils/BaseContextPathData.java M frontend/webadmin/modules/frontend/src/main/resources/META-INF/resources/GwtHostPage.jsp M frontend/webadmin/modules/frontend/src/main/resources/META-INF/web-fragment.xml M frontend/webadmin/modules/frontend/src/test/java/org/ovirt/engine/ui/frontend/server/gwt/AbstractGwtDynamicHostPageServletTest.java M frontend/webadmin/modules/frontend/src/test/java/org/ovirt/engine/ui/frontend/server/gwt/UserPortalHostPageServletTest.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/NoVncImpl.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/SpiceHtml5Impl.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Configurator.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ConsoleModel.java M frontend/webadmin/modules/userportal-gwtp/pom.xml M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/uicommon/UserPortalConfigurator.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/userportal/UserPortal.gwt.xml M frontend/webadmin/modules/userportal-gwtp/src/main/webapp/WEB-INF/web.xml D frontend/webadmin/modules/userportal-gwtp/src/main/webapp/index.html M frontend/webadmin/modules/webadmin/pom.xml M frontend/webadmin/modules/webadmin/src/main/webapp/WEB-INF/web.xml D frontend/webadmin/modules/webadmin/src/main/webapp/index.html M ovirt-engine.spec.in M packaging/branding/ovirt.brand/welcome_page.template M packaging/conf/ovirt-engine-proxy.conf.v2.in M packaging/services/ovirt-engine/ovirt-engine.conf.in 70 files changed, 1,283 insertions(+), 629 deletions(-) Approvals: Alexander Wels: Verified Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20473 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9cb4822f6bf4d372715e12858635db5ed3edd115 Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: rename fence methods to start with lowercase.
by emesika＠redhat.com 31 Oct '13

31 Oct '13

Eli Mesika has submitted this change and it was merged. Change subject: core: rename fence methods to start with lowercase. ...................................................................... core: rename fence methods to start with lowercase. Cleans some findbugs warnings. Change-Id: I0efff7949a568367a5c40507d19fd26b2e233c21 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceExecutor.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceVdsBaseCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetNewVdsFenceStatusQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVdsFenceStatusQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java 5 files changed, 13 insertions(+), 13 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20738 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0efff7949a568367a5c40507d19fd26b2e233c21 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: core+ui: Support lowering cluster CPU level
by iheim＠redhat.com 31 Oct '13

31 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: core+ui: Support lowering cluster CPU level ...................................................................... core+ui: Support lowering cluster CPU level This patch removes the validation of not lowering down the cluster CPU level while VMs are running. A proper warning and confirmation window is displayed instead. Change-Id: I69a32299b5782e69aef8832501dc8969b6dc810c Bug-Url: https://bugzilla.redhat.com/1006209 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetNumberOfActiveVmsInVdsGroupByVdsGroupIdQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 11 files changed, 119 insertions(+), 13 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20231 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I69a32299b5782e69aef8832501dc8969b6dc810c Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Remove NICs from VM Guide Me
by lvernia＠redhat.com 31 Oct '13

31 Oct '13

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Remove NICs from VM Guide Me ...................................................................... webadmin: Remove NICs from VM Guide Me Since virtual network interfaces can now be added in the add VM dialog itself, there's no longer need for them to take part in the following Guide Me flow. Change-Id: I870e7898f788e691741bfc4bc1b24c898ab4100b Bug-Url: https://bugzilla.redhat.com/1024249 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewGuideDiskModel.java D frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewGuideVmInterfaceModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmGuideModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java 4 files changed, 11 insertions(+), 184 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20754 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I870e7898f788e691741bfc4bc1b24c898ab4100b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0