- Engine-commits - oVirt List Archives

Change in ovirt-log-collector[ovirt-log-collector-3.3]: Use max=1000 option return results when calling the oVirt API.
by sbonazzo＠redhat.com 31 Oct '13

31 Oct '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: Use max=1000 option return results when calling the oVirt API. ...................................................................... Use max=1000 option return results when calling the oVirt API. When calling the API the LC does not provide a max value, limiting the results to 100 by default. For environments with 100+ DCs, Clusters or hosts this leads to incomplete LCs being collected. This change introduces the max=1000 option to each .list() call to allow a greater number of results to be returned. Change-Id: I0c9f61938df1626b1d81e4c0320b5bca10614f34 Bug-Url: https://bugzilla.redhat.com/1014379 Signed-off-by: Lee Yarwood <lyarwood(a)redhat.com> Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M .gitignore M src/helper/hypervisors.py 2 files changed, 4 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Kiril Nesenko: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/20764 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0c9f61938df1626b1d81e4c0320b5bca10614f34 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-3.3 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Humble Devassy Chirammal <hchiramm(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Lee Yarwood <lyarwood(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-log-collector[master]: Use max=1000 option return results when calling the oVirt API.
by sbonazzo＠redhat.com 31 Oct '13

31 Oct '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: Use max=1000 option return results when calling the oVirt API. ...................................................................... Use max=1000 option return results when calling the oVirt API. When calling the API the LC does not provide a max value, limiting the results to 100 by default. For environments with 100+ DCs, Clusters or hosts this leads to incomplete LCs being collected. This change introduces the max=1000 option to each .list() call to allow a greater number of results to be returned. Change-Id: I0c9f61938df1626b1d81e4c0320b5bca10614f34 Bug-Url: https://bugzilla.redhat.com/1014379 Signed-off-by: Lee Yarwood <lyarwood(a)redhat.com> Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M .gitignore M src/helper/hypervisors.py 2 files changed, 4 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved humble devassy: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/19759 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0c9f61938df1626b1d81e4c0320b5bca10614f34 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Lee Yarwood <lyarwood(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Lee Yarwood <lyarwood(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: humble devassy <hchiramm(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine, frontend: localize snapshot type on FE
by tjelinek＠redhat.com 31 Oct '13

31 Oct '13

Tomas Jelinek has submitted this change and it was merged. Change subject: engine,frontend: localize snapshot type on FE ...................................................................... engine,frontend: localize snapshot type on FE The problem was that the "Activet VM before preview" and "Active VM" Strings were hardcoded in the backend and written to the DB as a description. The problem with this was that the strings were taken on the frontend "as is" and were not localized. This patch localizes this strings on FE but leaves tham on BE to provide them to REST. Change-Id: I26866fd4dd91d034e7ae5afee054080a4ab864a1 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1010122 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/snapshot/SnapshotsViewColumns.java 2 files changed, 7 insertions(+), 0 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19542 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I26866fd4dd91d034e7ae5afee054080a4ab864a1 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Eli Mesika <elimesika(a)gmail.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: Add "permissions" sub-collections to vnic profiles
by masayag＠redhat.com 31 Oct '13

31 Oct '13

Moti Asayag has submitted this change and it was merged. Change subject: restapi: Add "permissions" sub-collections to vnic profiles ...................................................................... restapi: Add "permissions" sub-collections to vnic profiles The "permissions" sub-collections is added to vnic profiles under the networks top collection: api/networks/{network:id}/vnicprofiles api/networks/{network:id}/vnicprofiles/{profile:id}/permissions api/networks/{network:id}/vnicprofiles/{profile:id}/permissions/{permission:id} Change-Id: I02573ec87a40c7e017a24f334083044b051613ac Bug-Url: https://bugzilla.redhat.com/1014985 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/AssignedVnicProfileResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendVnicProfileResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendVnicProfilesResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendAssignedVnicProfileResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendAssignedVnicProfilesResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVnicProfileResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVnicProfilesResource.java 7 files changed, 30 insertions(+), 19 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20410 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I02573ec87a40c7e017a24f334083044b051613ac Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: Fix incorrect api description
by masayag＠redhat.com 31 Oct '13

31 Oct '13

Moti Asayag has submitted this change and it was merged. Change subject: restapi: Fix incorrect api description ...................................................................... restapi: Fix incorrect api description The permissions delete api of vnic profile is fixed to describe the action correctly. Change-Id: I87c11586ff2b89c034884a0559703d31922ac122 Bug-Url: https://bugzilla.redhat.com/1022433 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20431 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I87c11586ff2b89c034884a0559703d31922ac122 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Allow using vnic profiles internally
by masayag＠redhat.com 31 Oct '13

31 Oct '13

Moti Asayag has submitted this change and it was merged. Change subject: engine: Allow using vnic profiles internally ...................................................................... engine: Allow using vnic profiles internally When action is being executed internally, there is no user associated with the action, and the action should be treated as executed by the admin. In that case, there is no need to search for a permissions on a vnic profile to be used by the user. Change-Id: I7665d5d53519cdb2560ae2aed0b02c4229c80964 Bug-Url: https://bugzilla.redhat.com/1018229 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreAllSnapshotsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TryBackToAllSnapshotsOfVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/template/VmTemplateInterfaceCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/AbstractVmInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/VnicProfileHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/SnapshotsManager.java 9 files changed, 32 insertions(+), 26 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20718 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7665d5d53519cdb2560ae2aed0b02c4229c80964 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: setup: properly support relative answer file
by sbonazzo＠redhat.com 31 Oct '13

31 Oct '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: properly support relative answer file ...................................................................... packaging: setup: properly support relative answer file Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1025313 Change-Id: I72d8e8c46528e492aa3339ff83227104bfb3ba9b Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-common/core/answerfile.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20761 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I72d8e8c46528e492aa3339ff83227104bfb3ba9b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Make VmBase isoPath field editable
by ofrenkel＠redhat.com 31 Oct '13

31 Oct '13

Omer Frenkel has submitted this change and it was merged. Change subject: engine: Make VmBase isoPath field editable ...................................................................... engine: Make VmBase isoPath field editable Make isoPath editable even when the VM is not 'Down' Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1014035 Change-Id: I07a8531e3254e4c297b7e6c8040de2c9fbbd7166 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20288 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I07a8531e3254e4c297b7e6c8040de2c9fbbd7166 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: fix typo in OvfReader comment
by amureini＠redhat.com 31 Oct '13

31 Oct '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: fix typo in OvfReader comment ...................................................................... core: fix typo in OvfReader comment s/in in/it in Change-Id: I509b16b422721ec8bba332976a8e5facf4c6ec8a Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20733 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I509b16b422721ec8bba332976a8e5facf4c6ec8a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: db: changedbowner.sh: fix usage typos
by emesika＠redhat.com 31 Oct '13

31 Oct '13

Eli Mesika has submitted this change and it was merged. Change subject: db: changedbowner.sh: fix usage typos ...................................................................... db: changedbowner.sh: fix usage typos Change-Id: I7cc12d340f549fe0c46892ad92cb6268608e745e Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/setup/dbutils/changedbowner.sh 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20670 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7cc12d340f549fe0c46892ad92cb6268608e745e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>

1 0