- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.3]: webadmin: Set uniform width to vNIC entries
by iheim＠redhat.com 31 Oct '13

31 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: Set uniform width to vNIC entries ...................................................................... webadmin: Set uniform width to vNIC entries Added a set width for the vNIC entries in the add/edit VM dialog, to avoid longer vNIC names indenting the other UI fields. Change-Id: If0695a84aaee747b7020961da3392a60507b2fe6 Bug-Url: https://bugzilla.redhat.com/1023035 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/profile/ProfileInstanceTypeEditor.ui.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20594 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If0695a84aaee747b7020961da3392a60507b2fe6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: restapi: fix vm link for template's watchdog
by iheim＠redhat.com 31 Oct '13

31 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: restapi: fix vm link for template's watchdog ...................................................................... restapi: fix vm link for template's watchdog Change-Id: Ie84c9809a8cbb0fddf0daf39f22be97a8eadb938 Bug-Url: https://bugzilla.redhat.com/1019211 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplateResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplateWatchdogsResource.java 2 files changed, 25 insertions(+), 1 deletion(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20708 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie84c9809a8cbb0fddf0daf39f22be97a8eadb938 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: restapi: Add support for JAXB annotations in JSON #...
by mpastern＠redhat.com 31 Oct '13

31 Oct '13

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: restapi: Add support for JAXB annotations in JSON #652883 ...................................................................... restapi: restapi: Add support for JAXB annotations in JSON #652883 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=652883 Change-Id: Ifd4dd0681df72a37e3090ea00509c0f5ec206b14 Signed-off-by: Michael pasternak <mpastern(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/pom.xml M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resteasy/json/CustomObjectMapper.java M backend/manager/modules/restapi/webapp/src/main/resources/META-INF/MANIFEST.MF 3 files changed, 34 insertions(+), 2 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20704 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifd4dd0681df72a37e3090ea00509c0f5ec206b14 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: Revert "restapi: Add support for JAXB annotations in JSON"
by mpastern＠redhat.com 31 Oct '13

31 Oct '13

Michael Pasternak has submitted this change and it was merged. Change subject: Revert "restapi: Add support for JAXB annotations in JSON" ...................................................................... Revert "restapi: Add support for JAXB annotations in JSON" same can be done against standard resteasy-jackson-provider (which we want stick to, cause by using jackson-jaxrs directly, we lose all resteasy extensions) This reverts commit e87a70e006b8638b206bad01c02918030b255a0c. Signed-off-by: Michael pasternak <mpastern(a)redhat.com> Change-Id: I5dfa9732952da951011c859e818daf6166c0436f --- M backend/manager/modules/restapi/interface/definition/pom.xml A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resteasy/json/CustomObjectMapper.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resteasy/json/JsonProvider.java M backend/manager/modules/restapi/webapp/src/main/resources/META-INF/MANIFEST.MF M backend/manager/modules/vdsbroker/pom.xml M pom.xml 6 files changed, 72 insertions(+), 49 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20703 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5dfa9732952da951011c859e818daf6166c0436f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: webadmin: Only close provider dialog if action succeeds
by iheim＠redhat.com 31 Oct '13

31 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: Only close provider dialog if action succeeds ...................................................................... webadmin: Only close provider dialog if action succeeds Give the dialog a chance to display an error message from the backend before closing. Change-Id: I8ecf9d1364935a2a9231b44131eca5ca725d6db6 Bug-Url: https://bugzilla.redhat.com/987949 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderModel.java 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20568 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8ecf9d1364935a2a9231b44131eca5ca725d6db6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: webadmin: Added scrolling to vNIC section in add VM
by iheim＠redhat.com 31 Oct '13

31 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: Added scrolling to vNIC section in add VM ...................................................................... webadmin: Added scrolling to vNIC section in add VM Added a vertical scroll bar to the vNIC section in the add VM dialog. Change-Id: I0d1c45470c23fdb561bfb5573e133591c138c276 Bug-Url: https://bugzilla.redhat.com/1012798 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/profile/ProfilesInstanceTypeEditor.ui.xml 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20566 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0d1c45470c23fdb561bfb5573e133591c138c276 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: webadmin: Added scrolling to vNIC profiles
by iheim＠redhat.com 31 Oct '13

31 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: Added scrolling to vNIC profiles ...................................................................... webadmin: Added scrolling to vNIC profiles In add/edit network, added a vertical scroll bar to the vNIC profile section. Change-Id: I2fedc75dfcd534775fdb80b3364b81d99aab74eb Bug-Url: https://bugzilla.redhat.com/1012798 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/AbstractNetworkPopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/vnicProfile/VnicProfilesEditor.ui.xml 2 files changed, 7 insertions(+), 8 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20565 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2fedc75dfcd534775fdb80b3364b81d99aab74eb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in otopi[master]: core: add prefix directories to pluin name
by Alon Bar-Lev 30 Oct '13

30 Oct '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: core: add prefix directories to pluin name ...................................................................... core: add prefix directories to pluin name Change-Id: I9391cff6b74b108e47798431aad6129c1f2ea3f7 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M src/otopi/context.py 1 file changed, 31 insertions(+), 13 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20727 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9391cff6b74b108e47798431aad6129c1f2ea3f7 Gerrit-PatchSet: 2 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Pools VMs sub-tab - fix name column
by derez＠redhat.com 30 Oct '13

30 Oct '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Pools VMs sub-tab - fix name column ...................................................................... webadmin: Pools VMs sub-tab - fix name column Pools -> VMs sub-tab: added width to name column for making it visible again. Change-Id: I8b8397d3d669682a21fb2ad73ad1840a707e326e Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/pool/SubTabPoolVmView.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20322 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8b8397d3d669682a21fb2ad73ad1840a707e326e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: prevent npe on VdcActionUtils canExecute
by derez＠redhat.com 30 Oct '13

30 Oct '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: prevent npe on VdcActionUtils canExecute ...................................................................... webadmin: prevent npe on VdcActionUtils canExecute VmSnapshotListModel -> updateActionAvailability: passing an empty list to VdcActionUtils.canExecute when VM is null to avoid an NPE. Change-Id: I63e3570b48f8039642a5f1ce3af1f9c4599d688c Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmSnapshotListModel.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20446 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I63e3570b48f8039642a5f1ce3af1f9c4599d688c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0