- Engine-commits - oVirt List Archives

Change in ovirt-engine-cli[master]: cli: implement prompt initialization
by mpastern＠redhat.com 28 Oct '13

28 Oct '13

Michael Pasternak has submitted this change and it was merged. Change subject: cli: implement prompt initialization ...................................................................... cli: implement prompt initialization Change-Id: Icabf65340463b31bb6457a6b3bef5fb1edf1e6bb Signed-off-by: Michael pasternak <mpastern(a)redhat.com> --- M src/ovirtcli/shell/engineshell.py 1 file changed, 9 insertions(+), 5 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved Ravi Nori: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/20573 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icabf65340463b31bb6457a6b3bef5fb1edf1e6bb Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: deadlock and related changes in domain monitoring/Init...
by tnisan＠redhat.com 28 Oct '13

28 Oct '13

Tal Nisan has submitted this change and it was merged. Change subject: core: deadlock and related changes in domain monitoring/InitVdsOnUp ...................................................................... core: deadlock and related changes in domain monitoring/InitVdsOnUp The following patches fixes few issues related to the given bug: 1. Deadlock between domain failover process and InitVdsOnUp flows - Thread 1 (domain failover process) - runs within the event queue (a), attempts to call SetVdsStatus command that waits for lock on VdsManager.getLockObj() (b) Thread 2 - InitVdsOnUp - runs through the VdsManager.OnTimer with lock on VdsManager.getLockObj() (b) and waits for event submitted to the event queue to be executed (a) The implemented solution is to call SetVdsStatus executed from thread 1 on a new thread which will also reduce the wait time for the mutex. 2. Domain monitoring information should be processed from hosts that are "Up", if the host is not UP it means that something is wrong with that domain regardless (for example, if the host was moved to non-op status because of problematic report of domain, there's no reason to analyze each time its domain report). 3. Reduce calls to SetVdsStatus thus reducing acquired locks and wait time in case that the host isn't UP (if the host is already not up because of some other reason, there's no need to change it's status). Change-Id: I334b450fcf29ed57675ec1f2e4bf3bc43f31b4aa Bug-Url: https://bugzilla.redhat.com/965972 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java 2 files changed, 31 insertions(+), 21 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20400 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I334b450fcf29ed57675ec1f2e4bf3bc43f31b4aa Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: New checkbox for volume delete permission under gl...
by kmayilsa＠redhat.com 28 Oct '13

28 Oct '13

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin: New checkbox for volume delete permission under gluster. ...................................................................... webadmin: New checkbox for volume delete permission under gluster. This patch adds a checkbox for delete volume permission under gluster which was missing before. Now permission to delete volume can be added to a role by using this. Change-Id: I576c940c628febf849442b7f52ecb498145ea1f9 Bug-url: https://bugzilla.redhat.com/show_bug.cgi?id=1015478 Signed-off-by: ndarshan <dnarayan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/roles_ui/RoleTreeView.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java 2 files changed, 5 insertions(+), 0 deletions(-) Approvals: Kanagaraj M: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20290 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I576c940c628febf849442b7f52ecb498145ea1f9 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Darshan N <dnarayan(a)redhat.com> Gerrit-Reviewer: Darshan N <dnarayan(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: action to retain the bricks being removed
by kmayilsa＠redhat.com 28 Oct '13

28 Oct '13

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin: action to retain the bricks being removed ...................................................................... webadmin: action to retain the bricks being removed Added a new 'Retain' action to 'Remove' action group in the Bricks subtab. On clicking, a confirmation will be shown with the list of bricks which are being removed. Upon the confirmation, the bricks will be retained with the gluster volume. Change-Id: I6b2c51bcd09dca6f8201c8caf265334e893cb0cd Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/RemoveBrickStatusModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeBrickListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVolumeView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/gluster/SubTabVolumeBrickView.java 6 files changed, 139 insertions(+), 14 deletions(-) Approvals: Kanagaraj M: Looks good to me, approved Ramesh N: Verified -- To view, visit http://gerrit.ovirt.org/20096 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6b2c51bcd09dca6f8201c8caf265334e893cb0cd Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: enabling StopRemoveBrick when data migration is comp...
by kmayilsa＠redhat.com 28 Oct '13

28 Oct '13

Kanagaraj M has submitted this change and it was merged. Change subject: engine: enabling StopRemoveBrick when data migration is completed ...................................................................... engine: enabling StopRemoveBrick when data migration is completed Changei canDoAction to allow Stop Remove brick to be called even when the task is finished( data migration complete). This helps to implement the Retain Bricks UI command. Also change the remove-brick step status to ABORTED. changing the step status from FINISHED to ABORTED is not allowed through Step.markStepEnded. Hence explicitly update the status and endtime in GlusterAsyncCommand.endStepJob. Change-Id: I88e53fa1772427ea1ae2b6943b76e9a71e772376 Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterAsyncCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StopRemoveGlusterVolumeBricksCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/StopRemoveGlusterVolumeBricksCommandTest.java 3 files changed, 16 insertions(+), 12 deletions(-) Approvals: Kanagaraj M: Looks good to me, approved Ramesh N: Verified -- To view, visit http://gerrit.ovirt.org/20110 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I88e53fa1772427ea1ae2b6943b76e9a71e772376 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Populate task entity on brick
by kmayilsa＠redhat.com 28 Oct '13

28 Oct '13

Kanagaraj M has submitted this change and it was merged. Change subject: engine: Populate task entity on brick ...................................................................... engine: Populate task entity on brick While returning the bricks list on volume, populate the task entity from volume as this is used by the GWT UI layer. Change-Id: I3f72371323ef7696313b5333707ef4f3f771e7e1 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterVolumeDaoDbFacadeImpl.java 1 file changed, 10 insertions(+), 1 deletion(-) Approvals: Kanagaraj M: Looks good to me, approved Sahina Bose: Verified -- To view, visit http://gerrit.ovirt.org/20017 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3f72371323ef7696313b5333707ef4f3f771e7e1 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: gluster: fix for host getting removed when moved to maintena...
by kmayilsa＠redhat.com 28 Oct '13

28 Oct '13

Kanagaraj M has submitted this change and it was merged. Change subject: gluster: fix for host getting removed when moved to maintenance(#980750) ...................................................................... gluster: fix for host getting removed when moved to maintenance(#980750) Now the host will not be eligible for removal when in maintenance state. Change-Id: Ib4cde89b8eff57be9a6c89735f6269dd57559f50 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=980750 Signed-off-by: ndarshan <dnarayan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSyncJob.java 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Kanagaraj M: Looks good to me, approved ndarshan: Verified -- To view, visit http://gerrit.ovirt.org/19327 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib4cde89b8eff57be9a6c89735f6269dd57559f50 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ndarshan <dnarayan(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: ndarshan <dnarayan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Correct remove-brick flow
by kmayilsa＠redhat.com 28 Oct '13

28 Oct '13

Kanagaraj M has submitted this change and it was merged. Change subject: engine: Correct remove-brick flow ...................................................................... engine: Correct remove-brick flow Stop remove-brick and commit remove brick should not be monitored as separate jobs. Once migration of data is completed for remove-brick the step status is updated. Corrected parameters passed to commit brick and the step message that is updated. Refactored the endStepJob method. Change-Id: I8f7a99f8ae87186c42e7346508b6abf0a2d1b7be Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/CommitRemoveGlusterVolumeBricksCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterAsyncCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterTasksSyncJob.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StopRebalanceGlusterVolumeCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StopRemoveGlusterVolumeBricksCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/CommitRemoveGlusterVolumeBricksCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/StopRebalanceGlusterVolumeCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/StopRemoveGlusterVolumeBricksCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/constants/gluster/GlusterConstants.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/AbstractGlusterBrokerCommand.java 11 files changed, 83 insertions(+), 33 deletions(-) Approvals: Kanagaraj M: Looks good to me, approved Sahina Bose: Verified -- To view, visit http://gerrit.ovirt.org/20023 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8f7a99f8ae87186c42e7346508b6abf0a2d1b7be Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Bricks sub-tab under Hosts
by kmayilsa＠redhat.com 28 Oct '13

28 Oct '13

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin: Bricks sub-tab under Hosts ...................................................................... webadmin: Bricks sub-tab under Hosts Adding a Bricks sub tab under Hosts to show list of bricks associated with the selected host Change-Id: Ic67c2aba2a5cd90832e6aa8c63c016ccef96ee50 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostBricksListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/ClientGinjectorExtension.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/PresenterModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/HostModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/place/ApplicationPlaces.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/host/SubTabHostBrickPresenter.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/host/SubTabHostGlusterSwiftPresenter.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostBrickView.java 12 files changed, 255 insertions(+), 1 deletion(-) Approvals: Kanagaraj M: Looks good to me, approved Sahina Bose: Verified -- To view, visit http://gerrit.ovirt.org/19989 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic67c2aba2a5cd90832e6aa8c63c016ccef96ee50 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Query to get bricks given a server id
by kmayilsa＠redhat.com 28 Oct '13

28 Oct '13

Kanagaraj M has submitted this change and it was merged. Change subject: engine: Query to get bricks given a server id ...................................................................... engine: Query to get bricks given a server id Query to get a list of bricks associated with a server given a server id. This is needed to show the list of bricks associated with server in a bricks tab Also refactored the dao to use a view instead of getting server name from a jdbc query. Change-Id: I045c027617f1a50270f2462def56dc74f52435cf Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeBricksByServerIdQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterBrickEntity.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterBrickDaoDbFacadeImpl.java M packaging/dbscripts/create_views.sql M packaging/dbscripts/gluster_volumes_sp.sql 6 files changed, 49 insertions(+), 21 deletions(-) Approvals: Kanagaraj M: Looks good to me, approved Sahina Bose: Verified -- To view, visit http://gerrit.ovirt.org/19975 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I045c027617f1a50270f2462def56dc74f52435cf Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0