- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.3.1]: frontend: NPE in Import*Model
by iheim＠redhat.com 28 Oct '13

28 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: frontend: NPE in Import*Model ...................................................................... frontend: NPE in Import*Model There was a NPE vulnerability in ImportTemplateModel and ImportVmModel. The problem was that the VmBackupModel.restore() called first the setItems() and than init(). The setItems have done some async call and set the result to the super.setItems(), while the init() already needed this in initDisksStorageDomainsList() method (which is also called in a callback). So if the callback from setItems returned sooner than the ones in init() it worked. If not, the initDisksStorageDomainsList failed on NPE. Fixed by calling the real init() logic only when the data are really prepared. Change-Id: Id97c8368ecf80ceb7ef1aa456d32a022dd5043bb Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1019862 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/VmBackupModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/ImportTemplateModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmModel.java 3 files changed, 68 insertions(+), 63 deletions(-) Approvals: Tomas Jelinek: Verified Daniel Erez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20544 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id97c8368ecf80ceb7ef1aa456d32a022dd5043bb Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3.1 Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: packaging: services: ovirt-engine: enforce log level for ser...
by iheim＠redhat.com 28 Oct '13

28 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: packaging: services: ovirt-engine: enforce log level for server.log ...................................................................... packaging: services: ovirt-engine: enforce log level for server.log due to unknown reason there was report that server.log was put into debug level. so let's be consistent and enforce its level as well. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1021346 Change-Id: Id1ec5786ef64986e38e3766b2aabd22f5e544225 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/services/ovirt-engine/ovirt-engine.xml.in 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20559 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id1ec5786ef64986e38e3766b2aabd22f5e544225 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: packaging: fix typo in java detection caused only version match
by iheim＠redhat.com 28 Oct '13

28 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: packaging: fix typo in java detection caused only version match ...................................................................... packaging: fix typo in java detection caused only version match Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1023538 Change-Id: Ia0224b3bd1172ef5167c7085d2dd29aba72abaff Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/bin/java-home 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20560 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia0224b3bd1172ef5167c7085d2dd29aba72abaff Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: wrong string comparison in comment column
by gchaplik＠redhat.com 28 Oct '13

28 Oct '13

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: wrong string comparison in comment column ...................................................................... webadmin: wrong string comparison in comment column Change-Id: Ice1087a8042a76697ef0b7f296cb485885dcb069 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/CommentColumn.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20592 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ice1087a8042a76697ef0b7f296cb485885dcb069 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: engine-backup: Safer password input
by sbonazzo＠redhat.com 28 Oct '13

28 Oct '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: engine-backup: Safer password input ...................................................................... packaging: engine-backup: Safer password input Allow passing db password also interactively and using an environment variable, in addition to using a file and using a command line option. Bug-Url: https://bugzilla.redhat.com/1002401 Change-Id: Icbc497af2653417beab54a9be307332cdf69a48a Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/bin/engine-backup.sh 1 file changed, 36 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20423 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icbc497af2653417beab54a9be307332cdf69a48a Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.3]: tools: Utilze SENSITIVE_KEYS to prevent logging of notifier'...
by iheim＠redhat.com 28 Oct '13

28 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: tools: Utilze SENSITIVE_KEYS to prevent logging of notifier's MAIL_PASSWORD ...................................................................... tools: Utilze SENSITIVE_KEYS to prevent logging of notifier's MAIL_PASSWORD Change-Id: Ic15eccae95c7d30667a9fefe0c6a43188887ad99 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1020871 Signed-off-by: Mooli Tayer <mtayer(a)redhat.com> --- M packaging/services/ovirt-engine-notifier/ovirt-engine-notifier.conf.in 1 file changed, 7 insertions(+), 0 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20593 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic15eccae95c7d30667a9fefe0c6a43188887ad99 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: Eli Mesika <elimesika(a)gmail.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: frontend: NPE in Import*Model
by iheim＠redhat.com 28 Oct '13

28 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: frontend: NPE in Import*Model ...................................................................... frontend: NPE in Import*Model There was a NPE vulnerability in ImportTemplateModel and ImportVmModel. The problem was that the VmBackupModel.restore() called first the setItems() and than init(). The setItems have done some async call and set the result to the super.setItems(), while the init() already needed this in initDisksStorageDomainsList() method (which is also called in a callback). So if the callback from setItems returned sooner than the ones in init() it worked. If not, the initDisksStorageDomainsList failed on NPE. Fixed by calling the real init() logic only when the data are really prepared. Change-Id: Id97c8368ecf80ceb7ef1aa456d32a022dd5043bb Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1019862 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/VmBackupModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/ImportTemplateModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmModel.java 3 files changed, 68 insertions(+), 63 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20542 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id97c8368ecf80ceb7ef1aa456d32a022dd5043bb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Set uniform width to vNIC entries
by lvernia＠redhat.com 27 Oct '13

27 Oct '13

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Set uniform width to vNIC entries ...................................................................... webadmin: Set uniform width to vNIC entries Added a set width for the vNIC entries in the add/edit VM dialog, to avoid longer vNIC names indenting the other UI fields. Change-Id: If0695a84aaee747b7020961da3392a60507b2fe6 Bug-Url: https://bugzilla.redhat.com/1023035 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/profile/ProfileInstanceTypeEditor.ui.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20590 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If0695a84aaee747b7020961da3392a60507b2fe6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Remove duplicate properties of VmTemplate
by ofrenkel＠redhat.com 27 Oct '13

27 Oct '13

Omer Frenkel has submitted this change and it was merged. Change subject: engine: Remove duplicate properties of VmTemplate ...................................................................... engine: Remove duplicate properties of VmTemplate Remove fields interfaces and diskList with corresponding accessor methods duplicitly declared on VmTemplate while being inherited from VmBase with no additional logic except for overriding said accessor methods to the same implementation. Change-Id: I765da987d21ddf7153715322be9b9156b2a0ddca Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmTemplate.java 2 files changed, 7 insertions(+), 31 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19409 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I765da987d21ddf7153715322be9b9156b2a0ddca Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Fail import vm if mac addresses are missing
by masayag＠redhat.com 27 Oct '13

27 Oct '13

Moti Asayag has submitted this change and it was merged. Change subject: engine: Fail import vm if mac addresses are missing ...................................................................... engine: Fail import vm if mac addresses are missing When a vm is imported as new entity, there is a mac allocation for any imported vnic. If the mac addresses pool has insufficient addresses, the action fails during the execution. The patch fails the operation on can-do-action with a proper message to the user for the failure reason. Change-Id: I86680baa28c22def751c9c092f4cfde26ab1c45c Bug-Url: https://bugzilla.redhat.com/1008168 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20517 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I86680baa28c22def751c9c092f4cfde26ab1c45c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0