- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: gluster: Corrected the skippedFile count setting
by kmayilsa＠redhat.com 28 Oct '13

28 Oct '13

Kanagaraj M has submitted this change and it was merged. Change subject: gluster: Corrected the skippedFile count setting ...................................................................... gluster: Corrected the skippedFile count setting By mistake the skipped file count value was being assigned into filesFailed field only and so was causing an issue. Change-Id: Idc097b1dab5d948f67f2e08c7f590fddf89e55a2 Bug-Url: https://bugzilla.redhat.com/1020779 Signed-off-by: Shubhendu Tripathi <shtripat(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterVolumeTaskReturnForXmlRpc.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Shubhendu Tripathi: Verified Kanagaraj M: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20356 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idc097b1dab5d948f67f2e08c7f590fddf89e55a2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Host activate -check gluster availability
by kmayilsa＠redhat.com 28 Oct '13

28 Oct '13

Kanagaraj M has submitted this change and it was merged. Change subject: engine: Host activate -check gluster availability ...................................................................... engine: Host activate -check gluster availability If cluster supports gluster service, need to check if gluster is running, while activating host. If gluster command fails on server, the host state should not be changed to UP on activate. Change-Id: If673e32ed6480187ddcf6f9ecf8f0007e203b98d Bug-Url: https://bugzilla.redhat.com/975382 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/GlusterMonitoringStrategy.java 1 file changed, 18 insertions(+), 0 deletions(-) Approvals: Kanagaraj M: Looks good to me, approved Sahina Bose: Verified -- To view, visit http://gerrit.ovirt.org/16898 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If673e32ed6480187ddcf6f9ecf8f0007e203b98d Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: gluster: Corrected coverity scan issue in PermissionDAODbFac...
by kmayilsa＠redhat.com 28 Oct '13

28 Oct '13

Kanagaraj M has submitted this change and it was merged. Change subject: gluster: Corrected coverity scan issue in PermissionDAODbFacadeImpl ...................................................................... gluster: Corrected coverity scan issue in PermissionDAODbFacadeImpl Corrected coverity scan issue in PermissionDAODbFacadeImpl Change-Id: Ib900b2e729bc3ef6d031d4f471840999c42c7912 Signed-off-by: Shubhendu Tripathi <shtripat(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/PermissionDAODbFacadeImpl.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Shubhendu Tripathi: Verified Kanagaraj M: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20339 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib900b2e729bc3ef6d031d4f471840999c42c7912 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: gluster: Set host name instead of IP in remove bricks status
by kmayilsa＠redhat.com 28 Oct '13

28 Oct '13

Kanagaraj M has submitted this change and it was merged. Change subject: gluster: Set host name instead of IP in remove bricks status ...................................................................... gluster: Set host name instead of IP in remove bricks status Modified the query to set the host name instead of localhost or IP in gluster volume remove bricks status details. Change-Id: I655a664956bae1bcd91564d5867e160409bd9403 Bug-Url: https://bugzilla.redhat.com/1019561 Signed-off-by: Shubhendu Tripathi <shtripat(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeRemoveBricksStatusQuery.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeRemoveBricksStatusQueryTest.java 2 files changed, 43 insertions(+), 0 deletions(-) Approvals: Shubhendu Tripathi: Verified Kanagaraj M: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20253 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I655a664956bae1bcd91564d5867e160409bd9403 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core, webadmin: Show only supported disk interfaces
by rgolan＠redhat.com 28 Oct '13

28 Oct '13

Roy Golan has submitted this change and it was merged. Change subject: core, webadmin: Show only supported disk interfaces ...................................................................... core, webadmin: Show only supported disk interfaces This change uses information from the osinfo to avoid the selection of disk interfaces that are not supported by the chosen operating system. Change-Id: I2b674a3481b3e7503b3a224fdda0f9071b9a0619 Signed-off-by: Vitor de Lima <vitor.lima(a)eldorado.org.br> Signed-off-by: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br> Signed-off-by: Gustavo Pedrosa <gustavo.pedrosa(a)eldorado.org.br> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/OsRepositoryQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/osinfo/OsRepository.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/OsQueryParameters.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/OsRepositoryImpl.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java M packaging/conf/osinfo-defaults.properties 7 files changed, 75 insertions(+), 20 deletions(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17964 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2b674a3481b3e7503b3a224fdda0f9071b9a0619 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <vitor.lima(a)eldorado.org.br> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br> Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vitor.lima(a)eldorado.org.br> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Fixed some typos
by lvernia＠redhat.com 28 Oct '13

28 Oct '13

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Fixed some typos ...................................................................... webadmin: Fixed some typos A couple of String constants were named "inteface" instead of "interface". Change-Id: Id6ba703b9e116cc98b5b764ff12a1460fe258a49 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/NicActivateStatusColumn.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/networkinterface/NetworkInterfacePopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/template/TemplateInterfaceListModelTable.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/PoolInterfaceListModelTable.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmInterfaceListModelTable.java 6 files changed, 33 insertions(+), 33 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19435 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id6ba703b9e116cc98b5b764ff12a1460fe258a49 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: restapi: Fixing action host install parameters
by iheim＠redhat.com 28 Oct '13

28 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: restapi: Fixing action host install parameters ...................................................................... restapi: Fixing action host install parameters Adding to yaml all missing ssh fields for action install. Change-Id: If72e4744d370e16e6eaf310fe25907872c726af2 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1013637 Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20024 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If72e4744d370e16e6eaf310fe25907872c726af2 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-setup[master]: bin: add --vm-start-paused to hosted-engine
by sbonazzo＠redhat.com 28 Oct '13

28 Oct '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: bin: add --vm-start-paused to hosted-engine ...................................................................... bin: add --vm-start-paused to hosted-engine Allow to start the hosted engine VM qith qemu paused. Change-Id: I749e877fe1fb259b99f1dfa46f580bcb1a5ec724 Bug-Url: https://bugzilla.redhat.com/1020858 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M man/hosted-engine.8 M src/bin/hosted-engine.in 2 files changed, 17 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20443 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I749e877fe1fb259b99f1dfa46f580bcb1a5ec724 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Leonid Natapov <leonidnatapov(a)gmail.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: core: scheduling: avoid running external filters in CDA
by iheim＠redhat.com 28 Oct '13

28 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: core: scheduling: avoid running external filters in CDA ...................................................................... core: scheduling: avoid running external filters in CDA External code is user responsibility, so for the sake of performance, avoiding running external plugins in CanDoAction. Bug-Url: https://bugzilla.redhat.com/1014698 Change-Id: I319ca2a5d9dbbc6634639e7b842beac1cf6c6ad9 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java 1 file changed, 11 insertions(+), 5 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20450 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I319ca2a5d9dbbc6634639e7b842beac1cf6c6ad9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: engine: Fail import vm if mac addresses are missing
by iheim＠redhat.com 28 Oct '13

28 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: engine: Fail import vm if mac addresses are missing ...................................................................... engine: Fail import vm if mac addresses are missing When a vm is imported as new entity, there is a mac allocation for any imported vnic. If the mac addresses pool has insufficient addresses, the action fails during the execution. The patch fails the operation on can-do-action with a proper message to the user for the failure reason. Change-Id: I86680baa28c22def751c9c092f4cfde26ab1c45c Bug-Url: https://bugzilla.redhat.com/1008168 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20589 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I86680baa28c22def751c9c092f4cfde26ab1c45c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0