- Engine-commits - oVirt List Archives

Change in ovirt-engine-cli[master]: cli: prepare for the next development iteration
by mpastern＠redhat.com 22 Oct '13

22 Oct '13

Michael Pasternak has submitted this change and it was merged. Change subject: cli: prepare for the next development iteration ...................................................................... cli: prepare for the next development iteration Change-Id: I0f07bddf73c4fa26c9c25b64ae2b4dd3ea067921 Signed-off-by: Michael pasternak <mpastern(a)redhat.com> --- M Makefile M setup.py 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20387 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0f07bddf73c4fa26c9c25b64ae2b4dd3ea067921 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.3.1]: packaging: post ovirt-engine-3.3.1_beta2
by oschreib＠redhat.com 22 Oct '13

22 Oct '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: post ovirt-engine-3.3.1_beta2 ...................................................................... packaging: post ovirt-engine-3.3.1_beta2 Updated version to 3.3.1-0.4 Change-Id: I5c3789494aa622109b7580a8a6ea67c66818c0be Signed-off-by: Ofer Schreiber <oschreib(a)redhat.com> --- M version.mak 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20383 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5c3789494aa622109b7580a8a6ea67c66818c0be Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3.1 Gerrit-Owner: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.3.1]: packaging: ovirt-engine-3.3.1_beta2
by oschreib＠redhat.com 22 Oct '13

22 Oct '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: ovirt-engine-3.3.1_beta2 ...................................................................... packaging: ovirt-engine-3.3.1_beta2 Updated version to be 3.3.1-0.3.beta2 Change-Id: I82656ac29bf4dcb673cd20f46810124cb02d77bc Signed-off-by: Ofer Schreiber <oschreib(a)redhat.com> --- M version.mak 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20382 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I82656ac29bf4dcb673cd20f46810124cb02d77bc Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3.1 Gerrit-Owner: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.3]: core: log instead of CanDo on illegal memory value
by iheim＠redhat.com 22 Oct '13

22 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: core: log instead of CanDo on illegal memory value ...................................................................... core: log instead of CanDo on illegal memory value Change-Id: I6ab029a1bec86cac86b0e29a8e9aaa38bcdf6c87 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1014952 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommandTestAbstract.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 14 files changed, 47 insertions(+), 81 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20327 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6ab029a1bec86cac86b0e29a8e9aaa38bcdf6c87 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin : The menu option "Rebalance" made to appear after ...
by kmayilsa＠redhat.com 22 Oct '13

22 Oct '13

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin : The menu option "Rebalance" made to appear after "Stop" in Volume tab ...................................................................... webadmin : The menu option "Rebalance" made to appear after "Stop" in Volume tab The menu option "Rebalance" made to appear after "Stop" in Volume tab Change-Id: I048a7183311f98760aee53628bb3974416a17344 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1019557 Signed-off-by: Anmol Babu <anbabu(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVolumeView.java 1 file changed, 6 insertions(+), 6 deletions(-) Approvals: Kanagaraj M: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20235 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I048a7183311f98760aee53628bb3974416a17344 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin : Change volume status to yellow when bricks down
by kmayilsa＠redhat.com 22 Oct '13

22 Oct '13

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin : Change volume status to yellow when bricks down ...................................................................... webadmin : Change volume status to yellow when bricks down Show yellow up arrow when one or more bricks of a volume are down Signed-off-by: Anmol Babu <anbabu(a)redhat.com> Change-Id: Iddaf1676bf9bf2c3aa0d4381e5057e21d4c8512e Signed-off-by: Anmol Babu <anbabu(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationResources.java A frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/images/volume_all_bricks_down_warning.png A frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/images/volume_bricks_down_warning.png M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/VolumeStatusCell.java 5 files changed, 41 insertions(+), 2 deletions(-) Approvals: Kanagaraj M: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19611 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iddaf1676bf9bf2c3aa0d4381e5057e21d4c8512e Gerrit-PatchSet: 21 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Renaming Add Brick UI action to Add
by kmayilsa＠redhat.com 22 Oct '13

22 Oct '13

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin: Renaming Add Brick UI action to Add ...................................................................... webadmin: Renaming Add Brick UI action to Add renamed the UI Action 'Add Bricks' in Bricks sub tab to just 'Add' for UI consitency. Change-Id: Iba0e7f9752893df37fa848b76a7698e3af139bc9 Bug-Url:://bugzilla.redhat.com/show_bug.cgi?id=1019568 Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeBrickListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java 4 files changed, 7 insertions(+), 4 deletions(-) Approvals: Kanagaraj M: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20318 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iba0e7f9752893df37fa848b76a7698e3af139bc9 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: webadmin: Disable static IP if equal to hostname
by iheim＠redhat.com 22 Oct '13

22 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: Disable static IP if equal to hostname ...................................................................... webadmin: Disable static IP if equal to hostname This to prevent a user from performing a move that would necessarily cause the engine to lost connectivity to a host. Change-Id: I46836fac331f3d510fc3be8d435bb71fb546d37c Bug-Url: https://bugzilla.redhat.com/989360 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostManagementNetworkModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java 4 files changed, 27 insertions(+), 4 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20347 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I46836fac331f3d510fc3be8d435bb71fb546d37c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: webadmin: Improved boot protocol behavior in host network di...
by iheim＠redhat.com 22 Oct '13

22 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: Improved boot protocol behavior in host network dialog ...................................................................... webadmin: Improved boot protocol behavior in host network dialog It used to be that if the address/subnet/gateway fields were edited, they would be committed to the VdsNetworkInterface upon pressing OK even if the chosen boot protocol was for example NONE, in which case it would be expected that these fields wouldn't be committed. So now changes are committed only if the chosen boot protocol is IP_STATIC. Change-Id: I76f3f8d5c3f214927761effa571ca23f2e6c239c Bug-Url: https://bugzilla.redhat.com/989360 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java 1 file changed, 10 insertions(+), 6 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20346 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I76f3f8d5c3f214927761effa571ca23f2e6c239c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: engine: Modified network static IP validation
by iheim＠redhat.com 22 Oct '13

22 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: engine: Modified network static IP validation ...................................................................... engine: Modified network static IP validation It used to not allow changing the management network's IP address whenever the hostname was given as an IP address, but actually problems only arise if the old management network's IP address was equal to the hostname. However, this validation should be applied to ANY network, not just the management network. Also modified the tests accordingly, as well as fixed some logic that was supposed to give existing NICs different IP addresses but I don't think did anything. Change-Id: I85f873fe4e87d16ec60da5bd8f9d6c90ee1e0030 Bug-Url: https://bugzilla.redhat.com/989360 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelper.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelperTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 7 files changed, 87 insertions(+), 30 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20345 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I85f873fe4e87d16ec60da5bd8f9d6c90ee1e0030 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0