- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: packaging: setup: quote database variables
by sbonazzo＠redhat.com 23 Oct '13

23 Oct '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: quote database variables ...................................................................... packaging: setup: quote database variables best to quote anything, especially if it contains special characters such as '&'. Change-Id: I8c05822580656e9b98d029fa39e8b37caf5b5736 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/config/database.py 1 file changed, 10 insertions(+), 8 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20360 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8c05822580656e9b98d029fa39e8b37caf5b5736 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: setup: add README file to configuration drop dirs
by sbonazzo＠redhat.com 23 Oct '13

23 Oct '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: add README file to configuration drop dirs ...................................................................... packaging: setup: add README file to configuration drop dirs Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1020675 Change-Id: I17797e329be28ba938fbc4c57703aa2d3517ec15 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M .gitignore M Makefile M ovirt-engine.spec.in A packaging/etc/engine.conf.d/README.in A packaging/etc/notifier/notifier.conf.d/README.in A packaging/etc/ovirt-websocket-proxy.conf.d/README.in 6 files changed, 36 insertions(+), 6 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20381 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I17797e329be28ba938fbc4c57703aa2d3517ec15 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: setup: turn engine.conf to ghost
by sbonazzo＠redhat.com 23 Oct '13

23 Oct '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: turn engine.conf to ghost ...................................................................... packaging: setup: turn engine.conf to ghost this file should not be used as drop dir resolves the rpmnew/rpmsave hell. it must remain as ghost for backward compatibility. Related-To: https://bugzilla.redhat.com/show_bug.cgi?id=1020675 Change-Id: I68ada5e69ec8fc255013b29ad47134f30bacd758 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ovirt-engine.spec.in D packaging/etc/engine.conf 2 files changed, 2 insertions(+), 8 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20380 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I68ada5e69ec8fc255013b29ad47134f30bacd758 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: setup: cleanup: sort generated files
by sbonazzo＠redhat.com 23 Oct '13

23 Oct '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: cleanup: sort generated files ...................................................................... packaging: setup: cleanup: sort generated files Related-To: https://bugzilla.redhat.com/show_bug.cgi?id=1020675 Change-Id: I69e8e030e8619282804cf1990af199941211b3d4 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M .gitignore M Makefile 2 files changed, 15 insertions(+), 15 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20379 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I69e8e030e8619282804cf1990af199941211b3d4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: setup: Do not fail with missing /etc/sysconfig/nfs
by sbonazzo＠redhat.com 23 Oct '13

23 Oct '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: Do not fail with missing /etc/sysconfig/nfs ...................................................................... packaging: setup: Do not fail with missing /etc/sysconfig/nfs Make engine-setup do not fail if /etc/sysconfig/nfs does not exist, instead behave as if it was empty. engine-cleanup leaves it behind empty. Change-Id: I62b22a12b9abd408657696caa8d34243ae521cbd Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/system/nfs.py 1 file changed, 5 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20402 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I62b22a12b9abd408657696caa8d34243ae521cbd Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Copying a quota drops consumers and permissions
by gchaplik＠redhat.com 23 Oct '13

23 Oct '13

Gilad Chaplik has submitted this change and it was merged. Change subject: engine: Copying a quota drops consumers and permissions ...................................................................... engine: Copying a quota drops consumers and permissions Add a option to copy consumers and permissions while cloning a Quota. A check box (copy consumers and permissions) added to clone quota dialog. Change-Id: Ide6f9ded5c19d16f7b4c7e373df9664e59fb1419 Bug-Url: https://bugzilla.redhat.com/908835 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddQuotaCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/QuotaCRUDParameters.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/quota/QuotaListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/quota/QuotaModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/quota/QuotaPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/quota/QuotaPopupView.ui.xml 7 files changed, 91 insertions(+), 5 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19960 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ide6f9ded5c19d16f7b4c7e373df9664e59fb1419 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: external scheduler dont pass empty guid
by gchaplik＠redhat.com 23 Oct '13

23 Oct '13

Gilad Chaplik has submitted this change and it was merged. Change subject: engine: external scheduler dont pass empty guid ...................................................................... engine: external scheduler dont pass empty guid When using external balance an empty string may return resulting in a 0000-00... guid, causing unnecessary logging of missing guid Change-Id: I4887100e99810d3d09af90a19f116f34ede3f99e Signed-off-by: Noam Slomianko <nslomian(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/external/ExternalSchedulerBrokerImpl.java 1 file changed, 5 insertions(+), 1 deletion(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20034 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4887100e99810d3d09af90a19f116f34ede3f99e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Noam Slomianko <nslomian(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Noam Slomianko <nslomian(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: select a host even if scheduling scoring failed
by gchaplik＠redhat.com 23 Oct '13

23 Oct '13

Gilad Chaplik has submitted this change and it was merged. Change subject: engine: select a host even if scheduling scoring failed ...................................................................... engine: select a host even if scheduling scoring failed If no internal scoring function is selected it can result In no host selected at all, even if some hosts did pass the filtering stage. Select the first host if none has returned from the scoring functions. Change-Id: I96082ccdfd8759619e98bc437fdb468b3b583992 Bug-Url: https://bugzilla.redhat.com/1001986 Signed-off-by: Noam Slomianko <nslomian(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Gilad Chaplik: Looks good to me, approved Noam Slomianko: Verified -- To view, visit http://gerrit.ovirt.org/20359 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I96082ccdfd8759619e98bc437fdb468b3b583992 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Noam Slomianko <nslomian(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Noam Slomianko <nslomian(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: Engine: pass default displays head as string
by iheim＠redhat.com 23 Oct '13

23 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: Engine: pass default displays head as string ...................................................................... Engine: pass default displays head as string New VM store the heads value as integer, which pass to vdsm to treat it as String. Change-Id: I938e7a9285282f72c6b08b23b804cd84f6f8d060 Bug-Url: https://bugzilla.redhat.com/1018760 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20401 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I938e7a9285282f72c6b08b23b804cd84f6f8d060 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Eli Mesika <elimesika(a)gmail.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: UI: support multi monitor only for cluster 3.3 and up
by iheim＠redhat.com 23 Oct '13

23 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: UI: support multi monitor only for cluster 3.3 and up ...................................................................... UI: support multi monitor only for cluster 3.3 and up When the cluster is less then 3.3 or non Linux OS we set the SinglePCI checkbox to false and hide it. Change-Id: I5f65dd3d5ca1409402b9b0b93e1585f4bfa47a64 Bug-Url: https://bugzilla.redhat.com/1009391 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java 2 files changed, 32 insertions(+), 10 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20340 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5f65dd3d5ca1409402b9b0b93e1585f4bfa47a64 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Eli Mesika <elimesika(a)gmail.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0