- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin, userportal: Support tab index handling in dialogs
by vszocs＠redhat.com 23 Oct '13

23 Oct '13

Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin,userportal: Support tab index handling in dialogs ...................................................................... webadmin,userportal: Support tab index handling in dialogs This patch adds the necessary infrastructure to support tab index handling consistently across all application dialogs. In general, tab index values are updated for both dialog content (i.e. widgets contained within popup view directly -or- widgets contained within popup view's content widget [1]) and dialog footer buttons. Tab index values are updated on following occasions: (a) right before the dialog gets revealed in UI, i.e. right after view.edit (before popup reveal) (b) when dialog footer button collection is modified, i.e. right after new button gets added via model (c) upon stopProgress, right before calling focusInput In other words, after this patch, the only thing a dialog class (AbstractModelBoundPopupView subclass -or- content widget [1]) needs to do is to override setTabIndexes method. [1] AbstractModelBoundWidgetPopupView.popupWidget Change-Id: I8b5c7d6a9e7b98c1f5e1fecbaaf193cd862ccb47 Bug-Url: https://bugzilla.redhat.com/1011445 Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com> Signed-off-by: Ravi Nori <rnori(a)redhat.com> Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractModelBoundPopupPresenterWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/AbstractModelBoundPopupView.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/AbstractModelBoundWidgetPopupView.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/FocusableComponentsContainer.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AbstractUiCommandButton.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AbstractValidatedWidgetWithLabel.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/UiCommandButton.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/SimpleDialogPanel.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractModelBoundPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/DisksAllocationView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.java 11 files changed, 110 insertions(+), 46 deletions(-) Approvals: Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19692 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8b5c7d6a9e7b98c1f5e1fecbaaf193cd862ccb47 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: engine-backup.sh output db creation info
by sbonazzo＠redhat.com 23 Oct '13

23 Oct '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: engine-backup.sh output db creation info ...................................................................... packaging: engine-backup.sh output db creation info Add to '--help' instructions for creating a database and making it accessible. Change-Id: I212bfdd3b362880faa7aee159866d928de83d6f3 Bug-Url: https://bugzilla.redhat.com/1002401 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/bin/engine-backup.sh 1 file changed, 23 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20374 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I212bfdd3b362880faa7aee159866d928de83d6f3 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Prevent vnic live update for if network not on host
by masayag＠redhat.com 23 Oct '13

23 Oct '13

Moti Asayag has submitted this change and it was merged. Change subject: engine: Prevent vnic live update for if network not on host ...................................................................... engine: Prevent vnic live update for if network not on host The patch blocks updating a plugged vnic on a running vm to a network which doesn't exist on the host. It also fixes a bug of setting an empty vnic profile while updating a plugged vnic. Change-Id: I0c9d8f2202efa2e45a2144bbdb70d374bdb9ff6f Bug-Url: https://bugzilla.redhat.com/1017602 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/UpdateVmInterfaceCommand.java 1 file changed, 23 insertions(+), 4 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20188 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0c9d8f2202efa2e45a2144bbdb70d374bdb9ff6f Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: setup: clean '&' in jdbcTlsOptions
by sbonazzo＠redhat.com 23 Oct '13

23 Oct '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: clean '&' in jdbcTlsOptions ...................................................................... packaging: setup: clean '&' in jdbcTlsOptions Without this change, we might get an '&' immediately after the '?' in ENGINE_DB_URL. Change-Id: If8bb485e03c9d9d4c967f763a157151b11cbb84d Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/config/database.py 1 file changed, 15 insertions(+), 12 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20361 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If8bb485e03c9d9d4c967f763a157151b11cbb84d Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-image-uploader[ovirt-image-uploader-3.3]: nfs: domain uuid directory must be specified as destination
by sbonazzo＠redhat.com 23 Oct '13

23 Oct '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: nfs: domain uuid directory must be specified as destination ...................................................................... nfs: domain uuid directory must be specified as destination Previously no check was done on -n parameter for ensuring that the destination was an export domain uuid directory. Now the -n parameter is validated checking for the export domain uuid directory as destination. The output of --help and the man page have been updated to explicitly refer to the domain uuid directory. Additionally, the path to the log direcotry has been updated in the man page. Change-Id: Ic3e2f1ab6a6788a0ce80130c32171f69e7562c56 Bug-Url: https://bugzilla.redhat.com/950634 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/__main__.py M src/engine-image-uploader.8 2 files changed, 19 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Kiril Nesenko: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20421 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic3e2f1ab6a6788a0ce80130c32171f69e7562c56 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-image-uploader Gerrit-Branch: ovirt-image-uploader-3.3 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-image-uploader[master]: nfs: domain uuid directory must be specified as destination
by sbonazzo＠redhat.com 23 Oct '13

23 Oct '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: nfs: domain uuid directory must be specified as destination ...................................................................... nfs: domain uuid directory must be specified as destination Previously no check was done on -n parameter for ensuring that the destination was an export domain uuid directory. Now the -n parameter is validated checking for the export domain uuid directory as destination. The output of --help and the man page have been updated to explicitly refer to the domain uuid directory. Additionally, the path to the log direcotry has been updated in the man page. Change-Id: Ic3e2f1ab6a6788a0ce80130c32171f69e7562c56 Bug-Url: https://bugzilla.redhat.com/950634 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/__main__.py M src/engine-image-uploader.8 2 files changed, 19 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Kiril Nesenko: Looks good to me, but someone else must approve Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/20362 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic3e2f1ab6a6788a0ce80130c32171f69e7562c56 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-image-uploader Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.3]: packaging: setup: drop tables on restore
by iheim＠redhat.com 23 Oct '13

23 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: packaging: setup: drop tables on restore ...................................................................... packaging: setup: drop tables on restore Without this change, running 'engine-backup.sh --mode=restore' twice causes some lines to be duplicated in the database. Bug-Url: https://bugzilla.redhat.com/1020277 Change-Id: I8bdd8c01349b3cb2a4b1ab79a048c09479c23f27 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/bin/engine-backup.sh 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20372 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8bdd8c01349b3cb2a4b1ab79a048c09479c23f27 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: packaging: Allow restore to different db location
by iheim＠redhat.com 23 Oct '13

23 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: packaging: Allow restore to different db location ...................................................................... packaging: Allow restore to different db location Change the engine-backup.sh utility to be able to restore a backup so that the database will have credentials (name/host/password/etc) different from the ones used when doing the backup. Bug-Url: https://bugzilla.redhat.com/1002401 Change-Id: Ie2c84111808c638a1c589cf3c14c271184a0a7c2 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/bin/engine-backup.sh 1 file changed, 105 insertions(+), 2 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20371 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie2c84111808c638a1c589cf3c14c271184a0a7c2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-scheduler-proxy[master]: Load Balancing: never return null in rpc
by dfediuck＠redhat.com 22 Oct '13

22 Oct '13

Doron Fediuck has submitted this change and it was merged. Change subject: Load Balancing: never return null in rpc ...................................................................... Load Balancing: never return null in rpc Because load balancing returned the results directly from user code it may try and send null/nil/none via rpc (not possible) Change-Id: Iaf572035a5c44c521525090156921e12d6eabe67 Signed-off-by: Noam Slomianko <nslomian(a)redhat.com> --- M plugins/examples/host_memory_balance.py M src/ovirtscheduler/request_handler.py 2 files changed, 9 insertions(+), 10 deletions(-) Approvals: Doron Fediuck: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20026 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaf572035a5c44c521525090156921e12d6eabe67 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-scheduler-proxy Gerrit-Branch: master Gerrit-Owner: Noam Slomianko <nslomian(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Noam Slomianko <nslomian(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: Engine: pass default displays head as string
by shavivi＠redhat.com 22 Oct '13

22 Oct '13

Shahar Havivi has submitted this change and it was merged. Change subject: Engine: pass default displays head as string ...................................................................... Engine: pass default displays head as string New VM store the heads value as integer, which pass to vdsm to treat it as String. Change-Id: I938e7a9285282f72c6b08b23b804cd84f6f8d060 Bug-Url: https://bugzilla.redhat.com/1018760 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20230 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I938e7a9285282f72c6b08b23b804cd84f6f8d060 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Eli Mesika <elimesika(a)gmail.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0