- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: add get*Type to template DAO
by ofrenkel＠redhat.com 14 Oct '13

14 Oct '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: add get*Type to template DAO ...................................................................... core: add get*Type to template DAO Add methods in VmTemplateDAO to get specific types Instance and Image, using these will assure the user that the object return is of the right type. Change-Id: Ic9f0eef1e61b51cc941b8dd9403f5733a69f9dfc Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmTemplateDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmTemplateDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmTemplateDAOTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml 4 files changed, 160 insertions(+), 0 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12280 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic9f0eef1e61b51cc941b8dd9403f5733a69f9dfc Gerrit-PatchSet: 24 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Add Image and Instance type interfaces
by ofrenkel＠redhat.com 14 Oct '13

14 Oct '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: Add Image and Instance type interfaces ...................................................................... core: Add Image and Instance type interfaces Add new interface InstanceType and ImageType to describe these entities. make VmTemplate implement these. Change-Id: Ia4ef6393038588383a6f110d9743e4412ee97f75 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ImageType.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/InstanceType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmTemplate.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml 4 files changed, 111 insertions(+), 1 deletion(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12279 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia4ef6393038588383a6f110d9743e4412ee97f75 Gerrit-PatchSet: 25 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: add support for instance type
by ofrenkel＠redhat.com 14 Oct '13

14 Oct '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: add support for instance type ...................................................................... core: add support for instance type This patch introduce Instance Types: Add Instance and Image type id to vm, which links to the instance/image type it was created from. Add new Types to VmEntityType enum, and add a field to template which now can be Template/Instance/Image Type. Change-Id: I110e74c6fc8906e3d257c7cf31d2af2b1b800218 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmEntityType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmStatic.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmTemplate.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmStaticDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmTemplateDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/Enums.properties M packaging/dbscripts/create_views.sql A packaging/dbscripts/upgrade/03_04_0010_add_instance_type_to_vm.sql M packaging/dbscripts/vm_templates_sp.sql M packaging/dbscripts/vms_sp.sql 14 files changed, 135 insertions(+), 30 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12278 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I110e74c6fc8906e3d257c7cf31d2af2b1b800218 Gerrit-PatchSet: 24 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: scheduling: fixups
by dfediuck＠redhat.com 14 Oct '13

14 Oct '13

Doron Fediuck has submitted this change and it was merged. Change subject: core: scheduling: fixups ...................................................................... core: scheduling: fixups - Remove unused method - List.contains() was comparing VDS and Guid wrongfully Change-Id: I9b645459ecdca96bf19fccadab551be7f4b00f3f Bug-Url: https://bugzilla.redhat.com/1007282 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java 1 file changed, 8 insertions(+), 28 deletions(-) Approvals: Doron Fediuck: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20148 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9b645459ecdca96bf19fccadab551be7f4b00f3f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: Reduce backend calls for DC network list
by masayag＠redhat.com 14 Oct '13

14 Oct '13

Moti Asayag has submitted this change and it was merged. Change subject: restapi: Reduce backend calls for DC network list ...................................................................... restapi: Reduce backend calls for DC network list In case user provides both ID and Name for the network to be attached to a cluster, same networks list returned by querying the backend could be reused. Change-Id: Icf65412ace7b5e2da44af9d9288362ab08505129 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendClusterNetworksResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendClusterNetworksResourceTest.java 2 files changed, 13 insertions(+), 10 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14780 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icf65412ace7b5e2da44af9d9288362ab08505129 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-reports[master]: packaging: setup: fixed log jar location
by ydary＠redhat.com 13 Oct '13

13 Oct '13

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: fixed log jar location ...................................................................... packaging: setup: fixed log jar location Fix for F19 as priority and F18 as fallback. Change-Id: I09032b12b5cd4f3fe4820aa9541eb654d07b4e15 Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M packaging/ovirt-engine-reports-setup.py 1 file changed, 19 insertions(+), 6 deletions(-) Approvals: Alex Lourie: Verified Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20027 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I09032b12b5cd4f3fe4820aa9541eb654d07b4e15 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Use pin to host only when present in cluster policy
by dfediuck＠redhat.com 13 Oct '13

13 Oct '13

Doron Fediuck has submitted this change and it was merged. Change subject: core: Use pin to host only when present in cluster policy ...................................................................... core: Use pin to host only when present in cluster policy This removes the explicit pin to host check in scheduling. The check is already present in cluster policy and will be used when the policy unit is selected by the administrator. It also restores the optimization we had in the code that used Pin To Host logic as the first filter for the provided cluster policies. Change-Id: If2c0496327c9f692b0dbe92e1cf481f900f4a747 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1007282 Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties A packaging/dbscripts/upgrade/03_03_0990_pin_to_host_first_in_powersaving_policy.sql 3 files changed, 8 insertions(+), 28 deletions(-) Approvals: Doron Fediuck: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19784 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If2c0496327c9f692b0dbe92e1cf481f900f4a747 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Allow vlan to serve as a migration network
by masayag＠redhat.com 13 Oct '13

13 Oct '13

Moti Asayag has submitted this change and it was merged. Change subject: engine: Allow vlan to serve as a migration network ...................................................................... engine: Allow vlan to serve as a migration network In order for a nic device to be entitled to serve as the underlying interface for a migration network, it should be UP. The nics statuses are reported by the getVdsStats verb of VDSM which doesn't report it for vlan devices. Therefore, until the statistics will be collected for vlans, we'll allow migration to go over the vlan if its underlying nic is UP. Change-Id: Icdfcca442d40d8f2c3b6b28dc9f520e286b7e8f2 Bug-Url: https://bugzilla.redhat.com/1014013 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java 1 file changed, 15 insertions(+), 2 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20039 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icdfcca442d40d8f2c3b6b28dc9f520e286b7e8f2 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: update formatter conf to java version 1.7
by amureini＠redhat.com 13 Oct '13

13 Oct '13

Allon Mureinik has submitted this change and it was merged. Change subject: engine: update formatter conf to java version 1.7 ...................................................................... engine: update formatter conf to java version 1.7 Update engine code formatter configuration file settings to format according to java 1.7 instead of 1.5. Change-Id: If15ff59ec2711ac43fa16b40f8cc31c08992c681 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M config/engine-code-format.xml 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20079 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If15ff59ec2711ac43fa16b40f8cc31c08992c681 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: set action/type in FenceVdsManualyCommand
by amureini＠redhat.com 13 Oct '13

13 Oct '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: set action/type in FenceVdsManualyCommand ...................................................................... core: set action/type in FenceVdsManualyCommand Set action and type in setActionMessageParameters so it will be properly resolved. Change-Id: I89bbd039d683e6b95b5ce930f3bae195414283d1 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/FenceVdsManualyCommand.java 1 file changed, 5 insertions(+), 2 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20143 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I89bbd039d683e6b95b5ce930f3bae195414283d1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0