- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: packaging: setup: Log setup/cleanup/upgrade actions
by juan.hernandez＠redhat.com 25 Jun '13

25 Jun '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: setup: Log setup/cleanup/upgrade actions ...................................................................... packaging: setup: Log setup/cleanup/upgrade actions Added ovirt-engine-log-setup-event.sh and calls to it from engine-setup/cleanup/upgrade. Change-Id: Iae455ff0ef6475f00243906738474134f6f4e6e3 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/889271 --- M .gitignore M Makefile M ovirt-engine.spec.in A packaging/bin/ovirt-engine-log-setup-event.sh.in M packaging/fedora/setup/basedefs.py M packaging/fedora/setup/engine-cleanup.py M packaging/fedora/setup/engine-setup.py M packaging/fedora/setup/engine-upgrade.py M packaging/setup/ovirt_engine_setup/constants.py A packaging/setup/plugins/ovirt-engine-common/distro-rpm/__init__.py A packaging/setup/plugins/ovirt-engine-common/distro-rpm/log_setup_event.py 11 files changed, 241 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15863 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iae455ff0ef6475f00243906738474134f6f4e6e3 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine-sdk-java[master]: sdk: regenerate against the latest api
by mpastern＠redhat.com 25 Jun '13

25 Jun '13

Michael Pasternak has submitted this change and it was merged. Change subject: sdk: regenerate against the latest api ...................................................................... sdk: regenerate against the latest api - to datacenter added new field [comment] - to disk added [sgio] field to enable|disable filtering for the ScsiGenericIo - to StorageDomain.delete() added storagedomain.host.id|name Change-Id: I08ed8b6ace9ca5da32a9e4d0b63879715ea3e1a5 Signed-off-by: Michael pasternak <mpastern(a)redhat.com> --- M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenter.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterStorageDomainDisks.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenters.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Disks.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/StorageDomain.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/StorageDomainDisks.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMDisk.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMDisks.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/BaseResource.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/Disk.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/ObjectFactory.java A ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/ScsiGenericIoOptions.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/VersionCaps.java 13 files changed, 225 insertions(+), 2 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16076 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I08ed8b6ace9ca5da32a9e4d0b63879715ea3e1a5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine-sdk-java[master]: codegen: use local sdk rather than latest mvn release
by mpastern＠redhat.com 25 Jun '13

25 Jun '13

Michael Pasternak has submitted this change and it was merged. Change subject: codegen: use local sdk rather than latest mvn release ...................................................................... codegen: use local sdk rather than latest mvn release Change-Id: If529b1e8ef4af653fe5bf57b355d873c2be3a85d Signed-off-by: Michael pasternak <mpastern(a)redhat.com> --- M ovirt-engine-sdk-java-codegen/pom.xml 1 file changed, 17 insertions(+), 11 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16075 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If529b1e8ef4af653fe5bf57b355d873c2be3a85d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in jenkins[master]: Backup plugins directory only on Sunday
by eedri＠redhat.com 25 Jun '13

25 Jun '13

Eyal Edri has submitted this change and it was merged. Change subject: Backup plugins directory only on Sunday ...................................................................... Backup plugins directory only on Sunday Change-Id: I685c026a7b9d882297aa43c84527d1a7a774b210 Signed-off-by: Kiril Nesenko <knesenko(a)redhat.com> --- M backup/backup-jenkins.sh 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: Ewoud Kohl van Wijngaarden: Looks good to me, but someone else must approve Eyal Edri: Looks good to me, approved Kiril Nesenko: Verified -- To view, visit http://gerrit.ovirt.org/16063 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I685c026a7b9d882297aa43c84527d1a7a774b210 Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud(a)kohlvanwijngaarden.nl> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com>

1 0

Change in ovirt-engine[master]: frontend: Fixed NPE on new pool dialog
by tjelinek＠redhat.com 25 Jun '13

25 Jun '13

Tomas Jelinek has submitted this change and it was merged. Change subject: frontend: Fixed NPE on new pool dialog ...................................................................... frontend: Fixed NPE on new pool dialog The 282f87b3b0a96008d87cad21cc48e4d8adcd4cf9 did bring a regression that the new pool throws an NPE. The problem was in the fact, that on some places the osId was taken from the getSelectedItem() and directly converted to int - but there are cases where it can be null and that throws an NPE. Null it can be for example when UnitVmModel.initOSType() sets getOSType().setItems(AsyncDataProvider.getOsIds()), which results in ListModel.itemsChanged() which does setSelectedItems(null); and just after than it sets the given items. Change-Id: If6eb8db7e59204a6a77fbd802fcf7a378c31388b Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java 2 files changed, 20 insertions(+), 4 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16062 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If6eb8db7e59204a6a77fbd802fcf7a378c31388b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: func to delete all versions of a config val
by rgolan＠redhat.com 25 Jun '13

25 Jun '13

Roy Golan has submitted this change and it was merged. Change subject: core: func to delete all versions of a config val ...................................................................... core: func to delete all versions of a config val Adding a function to delete all versions of a config value so we don't have to specify which versions specifically to delete. Change-Id: I72c482d39b7c48dff5b6125cc1b795fbaabefa60 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/dbscripts/common_sp.sql 1 file changed, 13 insertions(+), 0 deletions(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16029 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I72c482d39b7c48dff5b6125cc1b795fbaabefa60 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal, webadmin: BrandingManager fails with missing etcd...
by derez＠redhat.com 25 Jun '13

25 Jun '13

Daniel Erez has submitted this change and it was merged. Change subject: userportal,webadmin: BrandingManager fails with missing etcdir ...................................................................... userportal,webadmin: BrandingManager fails with missing etcdir - BrandingManager.getInstance() would fail when you have a missing etcDir configuration which is often the case in unit tests. This patch stops the failure and instead returns no branding information. Change-Id: Ifc34286323c1eda114f6a8b5570274faf53b566c Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/branding/BrandingManager.java 1 file changed, 11 insertions(+), 2 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16046 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifc34286323c1eda114f6a8b5570274faf53b566c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: a potential NPE when a user invokes actions
by derez＠redhat.com 25 Jun '13

25 Jun '13

Daniel Erez has submitted this change and it was merged. Change subject: restapi: a potential NPE when a user invokes actions ...................................................................... restapi: a potential NPE when a user invokes actions When a user invokes an action without sending filter=true property, the action may throw a NPE on command creation flow. The underlining issue is in AbstractBackendCollectionResource -> resolveCreated method. If an exception is thrown (e.g. due to lack of permissions to execute query), the method returns null. Instead of tolerating the exception, call handleError method (to output a proper error message). Change-Id: I55f5ae906d6c0d2023783e7b61abe3bf9d01f28f Bug-Url: https://bugzilla.redhat.com/915106 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendCollectionResource.java 1 file changed, 2 insertions(+), 5 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15394 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I55f5ae906d6c0d2023783e7b61abe3bf9d01f28f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Adding batch procedure call test to excludes part
by rgolan＠redhat.com 25 Jun '13

25 Jun '13

Roy Golan has submitted this change and it was merged. Change subject: core: Adding batch procedure call test to excludes part ...................................................................... core: Adding batch procedure call test to excludes part This makes sure that it won't be run during unit-tests Change-Id: I75333a557917d449c27836697773f1bbfe3b83b7 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/dal/pom.xml 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Roy Golan: Looks good to me, approved Yair Zaslavsky: Verified -- To view, visit http://gerrit.ovirt.org/16056 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I75333a557917d449c27836697773f1bbfe3b83b7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal, webadmin: Remove Java 7 construct in Frontend
by amureini＠redhat.com 25 Jun '13

25 Jun '13

Allon Mureinik has submitted this change and it was merged. Change subject: userportal,webadmin: Remove Java 7 construct in Frontend ...................................................................... userportal,webadmin: Remove Java 7 construct in Frontend - Frontend does not allow Java 7 constructs, so replaced it with a standard java 6 version. Change-Id: I79d7a8cff2cfbc8ea424b3f67266d34dbeb24b9a Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/BrandingServlet.java 1 file changed, 1 insertion(+), 3 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16038 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I79d7a8cff2cfbc8ea424b3f67266d34dbeb24b9a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0