- Engine-commits - oVirt List Archives

Change in ovirt-node-plugin-vdsm[master]: pep8: over indented line fix
by mburns＠redhat.com 25 Jun '13

25 Jun '13

Michael Burns has submitted this change and it was merged. Change subject: pep8: over indented line fix ...................................................................... pep8: over indented line fix Change-Id: I00bc1f8532fcab4541aac982130acdba2b957150 Signed-off-by: Mike Burns <mburns(a)redhat.com> --- M src/engine_page.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Michael Burns: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15171 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I00bc1f8532fcab4541aac982130acdba2b957150 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: master Gerrit-Owner: Michael Burns <mburns(a)redhat.com> Gerrit-Reviewer: Michael Burns <mburns(a)redhat.com>

1 0

Change in ovirt-node-plugin-vdsm[master]: move vdsm plugin code into dedicated directory
by mburns＠redhat.com 25 Jun '13

25 Jun '13

Michael Burns has submitted this change and it was merged. Change subject: move vdsm plugin code into dedicated directory ...................................................................... move vdsm plugin code into dedicated directory Change-Id: I8cb260d91c12629846b5f0fdd6bc30433c50ba4d Signed-off-by: Mike Burns <mburns(a)redhat.com> --- M ovirt-node-plugin-vdsm.spec.in M src/Makefile.am A src/__init__.py 3 files changed, 29 insertions(+), 3 deletions(-) Approvals: Douglas Schilling Landgraf: Looks good to me, but someone else must approve Michael Burns: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15140 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8cb260d91c12629846b5f0fdd6bc30433c50ba4d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: master Gerrit-Owner: Michael Burns <mburns(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Michael Burns <mburns(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: hide gluster-swift tab for non-gluster hosts
by kmayilsa＠redhat.com 24 Jun '13

24 Jun '13

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin: hide gluster-swift tab for non-gluster hosts ...................................................................... webadmin: hide gluster-swift tab for non-gluster hosts 'Gluster Swift' sub-tab under 'Hosts' will be visible only if the select host belongs to gluster supported cluster. Also made following version checks - 'Cluster General-> Gluster Swift' visible if cluster version is >=3.3 - 'Gluster Hooks' sub-tab will be visible if cluster version is >=3.3 - 'Services' sub-tab will be visible if cluster version is >=3.2 Change-Id: Ied1cc8dc29bb62fa7fbd9378214a652d22627560 Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/GlusterFeaturesUtil.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/SubTabClusterGeneralView.java 4 files changed, 51 insertions(+), 7 deletions(-) Approvals: Kanagaraj M: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15785 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ied1cc8dc29bb62fa7fbd9378214a652d22627560 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: hide PM alert for gluster host
by kmayilsa＠redhat.com 24 Jun '13

24 Jun '13

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin: hide PM alert for gluster host ...................................................................... webadmin: hide PM alert for gluster host PM not enabled warning('!' mark) will not be shown for the hosts which belongs to gluster-only cluster. Change-Id: I4af11175ee27cdbed2e11f242af936945c8e486c Bug-Url: https://bugzilla.redhat.com/955491 Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/HostStatusCell.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Kanagaraj M: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15637 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4af11175ee27cdbed2e11f242af936945c8e486c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: remove unused constants and variables
by lhornyak＠redhat.com 24 Jun '13

24 Jun '13

Laszlo Hornyak has submitted this change and it was merged. Change subject: engine: remove unused constants and variables ...................................................................... engine: remove unused constants and variables removed a pair of unused constants and variables Change-Id: Ic478afb639389c887c6636f1007a684eb344a20e Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/Notifier.java 1 file changed, 0 insertions(+), 4 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15722 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic478afb639389c887c6636f1007a684eb344a20e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: remove single default constructor
by lhornyak＠redhat.com 24 Jun '13

24 Jun '13

Laszlo Hornyak has submitted this change and it was merged. Change subject: engine: remove single default constructor ...................................................................... engine: remove single default constructor removed single default constructor from CustomPropertiesValueHelper Change-Id: I733a1404a7fedd32e896d86690526ad817801c45 Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/entity/helper/CustomPropertiesValueHelper.java 1 file changed, 0 insertions(+), 3 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15721 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I733a1404a7fedd32e896d86690526ad817801c45 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: simplify AppConfig
by lhornyak＠redhat.com 24 Jun '13

24 Jun '13

Laszlo Hornyak has submitted this change and it was merged. Change subject: engine: simplify AppConfig ...................................................................... engine: simplify AppConfig Since AppConfig does not have any subclasses, it's type parameter can be removed. Change-Id: If47b802876ec0b6021f2c3fdb73ba147749f3993 Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/AppConfig.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/EngineConfigLogic.java 2 files changed, 4 insertions(+), 8 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15720 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If47b802876ec0b6021f2c3fdb73ba147749f3993 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: checkstyle enabled in tools project
by lhornyak＠redhat.com 24 Jun '13

24 Jun '13

Laszlo Hornyak has submitted this change and it was merged. Change subject: engine: checkstyle enabled in tools project ...................................................................... engine: checkstyle enabled in tools project - fixes all current checkstyle violations - enables checkstyle plugin in tools project Change-Id: Ifb2c95a9ee9777eebbd8a1e38d087cf48751a27c Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/tools/pom.xml M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/EngineConfigMap.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/entity/helper/PasswordValueHelper.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/validation/ConfigActionType.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/validation/EngineConfigValidatorFactory.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/validation/SetValidator.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomains.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/EngineMonitorService.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/NotificationService.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/Notifier.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/methods/NotificationMethodMapBuilder.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/utils/NotificationProperties.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/utils/sender/mail/JavaMailSender.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/tools/common/db/StandaloneDataSource.java M backend/manager/tools/src/test/java/org/ovirt/engine/core/config/EngineConfigLogicTest.java M backend/manager/tools/src/test/java/org/ovirt/engine/core/config/EngineConfigValidatorTest.java M backend/manager/tools/src/test/java/org/ovirt/engine/core/notifier/utils/NotificationPropertiesTest.java M backend/manager/tools/src/test/java/org/ovirt/engine/core/notifier/utils/mail/MailSenderTest.java 18 files changed, 11 insertions(+), 33 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15719 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifb2c95a9ee9777eebbd8a1e38d087cf48751a27c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: RemoveDiskParameters - don't use Entity ID
by yzaslavs＠redhat.com 24 Jun '13

24 Jun '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: RemoveDiskParameters - don't use Entity ID ...................................................................... core: RemoveDiskParameters - don't use Entity ID Changed RemoveDiskParameters to stop using Entity ID (which should only be used by Async Tasks related classes) and instead added a diskId member. All current usages were fixed to use the new member. Change-Id: I70dabec5d542c343cbaf71b1a4fdb58b4ec970ff Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveDiskParameters.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendTemplateDisksResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmDisksResourceTest.java 4 files changed, 21 insertions(+), 12 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15956 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I70dabec5d542c343cbaf71b1a4fdb58b4ec970ff Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-reports[master]: packaging: fixed war removal on package removal (#977360)
by ydary＠redhat.com 24 Jun '13

24 Jun '13

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: fixed war removal on package removal (#977360) ...................................................................... packaging: fixed war removal on package removal (#977360) Bug-Url: https://bugzilla.redhat.com/977360 Change-Id: I3c2112f146aa2d6974dbc68d7aae16b325374062 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M packaging/ovirt-engine-reports.spec.in 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Alex Lourie: Looks good to me, but someone else must approve Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16042 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3c2112f146aa2d6974dbc68d7aae16b325374062 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0