- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: findbugs - check for null on a already dereferenced variable
by oourfali＠redhat.com 24 Jun '13

24 Jun '13

Oved Ourfali has submitted this change and it was merged. Change subject: findbugs - check for null on a already dereferenced variable ...................................................................... findbugs - check for null on a already dereferenced variable No need to check for null, as it cannot be null. Change-Id: I86f454d2cff51b249745fb508ff547528538a21c Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceVdsBaseCommand.java 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Roy Golan: Looks good to me, approved Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16034 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I86f454d2cff51b249745fb508ff547528538a21c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Introducing Batch updates to DAOs
by yzaslavs＠redhat.com 24 Jun '13

24 Jun '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Introducing Batch updates to DAOs ...................................................................... core: Introducing Batch updates to DAOs The following patch introduces the ability to perform a batch update Due to the fact spring-jdbc does not "natively" support postgresql we had to query the stored procedures meta-data on our own. Change-Id: If5ee0aa90bca3b5c257beb7b0eaa236f02f0206f Signed-off-by: Liran Zelkha <liran.zelkha(a)gmail.com> Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/BatchProcedureExecutionConnectionCallback.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbEngineDialect.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/PostgresDbEngineDialect.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/SimpleJdbcCallsHandler.java A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/SqlCallParameter.java A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/StoredProcToTypeMapping.java A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/StoredProcedureMetaData.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/InterfaceDaoDbFacadeImpl.java A backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/BatchProcedureCallTest.java 9 files changed, 452 insertions(+), 13 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15039 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If5ee0aa90bca3b5c257beb7b0eaa236f02f0206f Gerrit-PatchSet: 21 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <liran.zelkha(a)gmail.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: setup: add "action" to otopi environment
by juan.hernandez＠redhat.com 24 Jun '13

24 Jun '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: setup: add "action" to otopi environment ...................................................................... packaging: setup: add "action" to otopi environment Added "action" - currently setup or cleanup - to otopi environment, to allow common code know what action is being done. Change-Id: Ic34515956e7a374a8c255d6526f47603adda0bb5 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/constants.py M packaging/setup/plugins/ovirt-engine-remove/core/misc.py M packaging/setup/plugins/ovirt-engine-setup/core/misc.py 3 files changed, 10 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15915 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic34515956e7a374a8c255d6526f47603adda0bb5 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)gmail.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: refactoring VdsSelector API
by gchaplik＠redhat.com 24 Jun '13

24 Jun '13

Gilad Chaplik has submitted this change and it was merged. Change subject: core: refactoring VdsSelector API ...................................................................... core: refactoring VdsSelector API Host selection should become stateless, therefore moving failed host list out of this class (vdsBlackList), and pass it as a parameter. In addition, each vdsSelector call should supply a list of hosts that the selector should 'work' on. new VdsSelector API: // for Validation purposes canFindVdsToRunOn(List<VDS> vdsList, List<Guid> vdsBlackList, List<String> messages, boolean isMigrate) // for selecting a host to run on Guid getVdsToRunOn(List<VDS> vdsList, List<Guid> vdsBlackList, boolean isMigrate) Gerrit-cntr: 1 Change-Id: I6d936e1b96628e426e944d77730e3ca08a1357ee Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/VdsSelector.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/RunVmValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RunVmCommandTest.java 7 files changed, 109 insertions(+), 76 deletions(-) Approvals: Laszlo Hornyak: Looks good to me, approved Gilad Chaplik: Verified -- To view, visit http://gerrit.ovirt.org/16030 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6d936e1b96628e426e944d77730e3ca08a1357ee Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: fix method names
by oourfali＠redhat.com 24 Jun '13

24 Jun '13

Oved Ourfali has submitted this change and it was merged. Change subject: core: fix method names ...................................................................... core: fix method names Change-Id: I4612e4392400b0951423192756649c31d5eec1e3 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceQueryBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVdsFenceStatusQuery.java 2 files changed, 5 insertions(+), 5 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16028 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4612e4392400b0951423192756649c31d5eec1e3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: include VdsGroup virt, gluster flags in VDS entity
by kmayilsa＠redhat.com 24 Jun '13

24 Jun '13

Kanagaraj M has submitted this change and it was merged. Change subject: engine: include VdsGroup virt, gluster flags in VDS entity ...................................................................... engine: include VdsGroup virt, gluster flags in VDS entity Added virt_service and gluster_service flags to VDS entity. VDS view is modified accordingly to read these flags from vds_groups table. Change-Id: I961a37312425213fdbce446001fd2874f7661cd1 Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M backend/manager/dbscripts/create_views.sql M backend/manager/dbscripts/upgrade/post_upgrade/0010_add_object_column_white_list_table.sql M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/resources/fixtures.xml 5 files changed, 37 insertions(+), 2 deletions(-) Approvals: Kanagaraj M: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15636 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I961a37312425213fdbce446001fd2874f7661cd1 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: history: added vm's client ip to dwh views (#873790)
by yzaslavs＠redhat.com 24 Jun '13

24 Jun '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: history: added vm's client ip to dwh views (#873790) ...................................................................... history: added vm's client ip to dwh views (#873790) Bug-Url: https://bugzilla.redhat.com/873790 Change-Id: Ibb75a526070214ff6f909692d5f099367fb4eda3 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M backend/manager/dbscripts/create_dwh_views.sql 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, but someone else must approve Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16008 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibb75a526070214ff6f909692d5f099367fb4eda3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Eli Mesika <elimesika(a)gmail.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-dwh[master]: packaging: Added backup DB functionality to setup
by ydary＠redhat.com 24 Jun '13

24 Jun '13

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: Added backup DB functionality to setup ...................................................................... packaging: Added backup DB functionality to setup This patch adds user interaction asking to perform the backup of the DB before performing an upgrade. Prior to that it checks the available space and the size of the DB and prompts the user with option to perform the backup. Change-Id: I8ccf8938099207b4e73bb947d1bb5fd673605071 Bug-Url: https://bugzilla.redhat.com/910070 Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M packaging/common_utils.py M packaging/ovirt-engine-dwh-setup.py 2 files changed, 233 insertions(+), 5 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15772 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8ccf8938099207b4e73bb947d1bb5fd673605071 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: refactored host/cluster general tab mode checks
by kmayilsa＠redhat.com 24 Jun '13

24 Jun '13

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin: refactored host/cluster general tab mode checks ...................................................................... webadmin: refactored host/cluster general tab mode checks With the recent enhancements to form related tabs, an empty line is shown for the form items which are not added to the formpanel. For example "libvirt version" form item won't be added to formpanel if the application is not running in virt supported mode. This leaves an empty line between the previous and next row's form items. The code is refactored to make use of the setIsAvailable() method of FormItem instead leaving out the formitem itself. Change-Id: I1e57336b819ee12b66d5f22589b4b85470e1be5c Bug-Url: https://bugzilla.redhat.com/973607 Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/FormItem.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/ClusterGeneralModelForm.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostGeneralView.java 3 files changed, 56 insertions(+), 75 deletions(-) Approvals: Kanagaraj M: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15947 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1e57336b819ee12b66d5f22589b4b85470e1be5c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: dos2unix VdsmErrors.properties
by rgolan＠redhat.com 24 Jun '13

24 Jun '13

Roy Golan has submitted this change and it was merged. Change subject: core: dos2unix VdsmErrors.properties ...................................................................... core: dos2unix VdsmErrors.properties Run dos2unix on VdsmErrors.properties to remove the pesky \rs. Change-Id: I4d56640e68e6e13f250669323b7216883f3f90a7 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties 1 file changed, 367 insertions(+), 367 deletions(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16020 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4d56640e68e6e13f250669323b7216883f3f90a7 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0