- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: Disable select quota on edit vm-pool
by dfediuck＠redhat.com 23 Jun '13

23 Jun '13

Doron Fediuck has submitted this change and it was merged. Change subject: webadmin: Disable select quota on edit vm-pool ...................................................................... webadmin: Disable select quota on edit vm-pool Quota selection was enabled on edit vm-pool dialog (unlike all other fields). set the quota selection box to disabled. Change-Id: Ifebe28c31bf7f8a5320b70aa62f6eba733333b6c Bug-Url: https://bugzilla.redhat.com/966003 Signed-off-by: Ofri Masad <omasad(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/pool/PoolEditPopupWidget.java 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Doron Fediuck: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15320 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifebe28c31bf7f8a5320b70aa62f6eba733333b6c Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <omasad(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Added the quota to the Pool-general subtab
by dfediuck＠redhat.com 23 Jun '13

23 Jun '13

Doron Fediuck has submitted this change and it was merged. Change subject: webadmin: Added the quota to the Pool-general subtab ...................................................................... webadmin: Added the quota to the Pool-general subtab Added the quota name to the General sub-tab under the Pool main-tab Change-Id: Ib442572880ef75929eecfc19037cca4ad86f206b Bug-Url: https://bugzilla.redhat.com/965979 Signed-off-by: Ofri Masad <omasad(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolGeneralModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/pool/SubTabPoolGeneralView.java 2 files changed, 17 insertions(+), 0 deletions(-) Approvals: Doron Fediuck: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15283 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib442572880ef75929eecfc19037cca4ad86f206b Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <omasad(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: add validation to AddStorageServerConnection
by amureini＠redhat.com 23 Jun '13

23 Jun '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: add validation to AddStorageServerConnection ...................................................................... core: add validation to AddStorageServerConnection Prevent addition of a new connection if another one with same connection details already exists. Added more unitests for the AddStorageServerConnection command. Also added VAR__TYPE__STORAGE__CONNECTION to VdcBllMessages, so the connection related commands will return a proper message with correct entity type (instead of returning var type storage domain). AppErrors files already contain this var type, so no need to add it there. Also, fixed the failure handling of storage domain creation in webadmin UI - if connection command failed and no connection was created, there is no need to send command to backend to delete the connection. Change-Id: If9bcef8a413589654d36db8d878c844550ae6066 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageServerConnectionCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStorageServerConnectionCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStorageServerConnectionCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/AddStorageServerConnectionCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 9 files changed, 129 insertions(+), 37 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15388 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If9bcef8a413589654d36db8d878c844550ae6066 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Cheryn Tan <cheryntan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Add snapshot validation for empty guid.
by mlipchuk＠redhat.com 23 Jun '13

23 Jun '13

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Add snapshot validation for empty guid. ...................................................................... core: Add snapshot validation for empty guid. Currently when virt-v2v is used to convert a vm from a foreign hypervisor (Xen, VMware and etc), it sets the vm_snapshot_id of all disks of that vm to empty guid. This later causes issues doing different tasks on snapshots. The proposed fix is to add a validation whether the snapshot id is empty and provides an appropriate message. Change-Id: I19bc2982adecca198f8dc38ca011f4528dd58db9 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreAllSnapshotsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TryBackToAllSnapshotsOfVmCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVmCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/TryBackToAllSnapshotsOfVmCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 11 files changed, 62 insertions(+), 2 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15701 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I19bc2982adecca198f8dc38ca011f4528dd58db9 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Cheryn Tan <cheryntan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core : Automatic logout does not always happen as per UserSe...
by yzaslavs＠redhat.com 23 Jun '13

23 Jun '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: core : Automatic logout does not always happen as per UserSessionTimeOutInterval value ...................................................................... core : Automatic logout does not always happen as per UserSessionTimeOutInterval value After setting UserSessionTimeOutInterval value, automatic logout does not always happen after the set period for inactivity. It takes much longer than the time set by the UserSessionTimeOutInterval parameter. Change-Id: I4866a28749b0ae1313c07bdbf22779b711892026 Bug-Url: https://bugzilla.redhat.com/953614 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M packaging/etc/engine-config/engine-config.properties 4 files changed, 10 insertions(+), 1 deletion(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15804 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4866a28749b0ae1313c07bdbf22779b711892026 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: audit log - use hypervisor and not ovirt-node
by yzaslavs＠redhat.com 23 Jun '13

23 Jun '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: audit log - use hypervisor and not ovirt-node ...................................................................... core: audit log - use hypervisor and not ovirt-node When adding a hypervisor through the host the manager audit log should state "Host is hypervisor" and not "Host is ovirt-node" because the term hypervisor includes both ovirt-node and rhevh. Change-Id: Ie0dbe402c6c1fa1b5a01af30e4bbb320e12b11d5 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=921070 Signed-off-by: Mooli Tayer <mtayer(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsDeploy.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15806 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie0dbe402c6c1fa1b5a01af30e4bbb320e12b11d5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: Notification service should send a notification when Databas...
by yzaslavs＠redhat.com 23 Jun '13

23 Jun '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: Notification service should send a notification when Database is down. ...................................................................... Notification service should send a notification when Database is down. Send a notification email after first failure to fetch notifications, and then once every failedQueriesNotificationThreshold times (new conf parameter). The recipients is also a conf value, FAILED_QUERIES_NOTIFICATION_RECIPIENTS. A comma seperated email list is expected. If it is empty no notifications are sent on db connection failure. Change-Id: Id0d36b6140846bf98a33064cc69a9a398a8d4128 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=971324 Signed-off-by: Mooli Tayer <mtayer(a)redhat.com> --- M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/NotificationService.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/utils/NotificationProperties.java M packaging/conf/notifier.conf.defaults.in 3 files changed, 85 insertions(+), 2 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15768 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id0d36b6140846bf98a33064cc69a9a398a8d4128 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Underscores in tag names break tags
by yzaslavs＠redhat.com 23 Jun '13

23 Jun '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Underscores in tag names break tags ...................................................................... core: Underscores in tag names break tags Since '_' is treated in Postgres as '?' when using like, (i.e. match any single character) we have to escape this character in the value to make it treated as a regular character. Due to changes between PG8.x and PG9.x on ESCAPE representation in a string, we should figure out what PG Release is running in order to escape the special character(_) correctly The bug was that the above treatment was done on the value no matter what the operator is, while this change should be applied only for the LIKE or ILIKE operator. If the operator is '=' '!=' 'IN' etc. the '_' should stay as is in the passed value and not been manipulated. Change-Id: Ia4c289e198b59afc4acf3e671ea65f2cdf8e31ad Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=949484 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxChecker.java 1 file changed, 17 insertions(+), 16 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15594 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia4c289e198b59afc4acf3e671ea65f2cdf8e31ad Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in otopi[master]: doc: fix typo
by Alon Bar-Lev 21 Jun '13

21 Jun '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: doc: fix typo ...................................................................... doc: fix typo Change-Id: Ib8d46ec1209345bcb28440980e3beb24cc03fe3c Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M README 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15985 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib8d46ec1209345bcb28440980e3beb24cc03fe3c Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal, webadmin: Customized parameterized messages
by vszocs＠redhat.com 21 Jun '13

21 Jun '13

Vojtech Szocs has submitted this change and it was merged. Change subject: userportal,webadmin: Customized parameterized messages ...................................................................... userportal,webadmin: Customized parameterized messages - Implemented DynamicMessages to facilitate the use of parameterized messages in branding packages. - Renamed DynamicConstants to DynamicMessages. - Added {0} to version about. Change-Id: Iad253128d6bb48b0be93bb580803101b7e85bcea Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=816173 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/gin/BaseSystemModule.java D frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/DynamicConstants.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/DynamicMessages.java A frontend/webadmin/modules/gwt-common/src/test/java/org/ovirt/engine/ui/common/utils/DynamicMessagesTest.java D frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/ApplicationDynamicConstants.java A frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/ApplicationDynamicMessages.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/gin/SystemModule.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/login/view/LoginPopupView.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/HeaderPresenterWidget.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/AboutPopupView.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/AboutPopupView.ui.xml M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/HeaderView.ui.xml M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/system/ApplicationInit.java D frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationDynamicConstants.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationDynamicMessages.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/SystemModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/login/view/LoginPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/HeaderPresenterWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/AboutPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/AboutPopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/HeaderView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/HeaderView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/system/ApplicationInit.java M packaging/branding/ovirt.brand/ovirt_messages.properties 24 files changed, 464 insertions(+), 203 deletions(-) Approvals: Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15838 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iad253128d6bb48b0be93bb580803101b7e85bcea Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0