- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: introducing virtio-scsi support
by derez＠redhat.com 20 Jun '13

20 Jun '13

Daniel Erez has submitted this change and it was merged. Change subject: core: introducing virtio-scsi support ...................................................................... core: introducing virtio-scsi support A new DiskInterface type: VirtIO_SCSI * Available for both DiskImage and LunDisk * Supported for Cluster 3.3 and above - Added 'VirtIoScsiEnabled' ConfigValue * OS Guest support - Added 'VirtIoScsiUnsupportedOsList' ConfigValue * VmInfoBuilder - adapting to VDSM API - Interface attribute: iface='scsi' - Controller element is sent when required (if there's at least one disk with virtio-scsi interface) SGIO [1] * Avaiable for DirectLUN disks with VirtIO-SCSI interface * Added ScsiGenericIO enum: filtered/unfiltered * Added 'sgio' column to 'base_disks' table - Updated relevant views: vm_images_storage_domains_view, images_storage_domain_view storage_for_image_view, all_disks * Should be restricted by MLA permissions - A new ActionGroup: CONFIGURE_SCSI_GENERIC_IO - Granted to DataCenterAdmin and SuperUser roles - Verified on AddDiskCommand and UpdateVmDiskCommand * VmInfoBuilder - adapting to VDSM API - 'sgio' attribute on disk element [1] 'sgio': SCSI Generic IO - filtered/unfiltered (indicates whether the OS kernel will filter unprivileged SG_IO commands for the disk). * Feature page: http://www.ovirt.org/Features/Virtio-SCSI Change-Id: Ie572b8106b3fe5becec69c140546db81bc671c96 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/dbscripts/base_disks_sp.sql M backend/manager/dbscripts/create_views.sql A backend/manager/dbscripts/upgrade/03_03_0260_add_base_disks_sgio_column.sql A backend/manager/dbscripts/upgrade/03_03_0270_add_permission_to_configure_sgio.sql M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractDiskVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachDiskToVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/DiskValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddDiskToVmCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVmCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/FeatureSupported.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ActionGroup.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/BaseDisk.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DiskInterface.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ScsiGenericIO.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmDeviceType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AbstractBaseDiskRowMapper.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/BaseDiskDaoDbFacadeImpl.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/BaseDiskDaoTest.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HotPlugDiskVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java 30 files changed, 362 insertions(+), 36 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14906 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie572b8106b3fe5becec69c140546db81bc671c96 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: introducing virtio-scsi support
by derez＠redhat.com 20 Jun '13

20 Jun '13

Daniel Erez has submitted this change and it was merged. Change subject: restapi: introducing virtio-scsi support ...................................................................... restapi: introducing virtio-scsi support * A new DiskInterface: VIRTIO_SCSI - Updated DiskInterface and DiskMapper accordingly * SGIO attribute [1] - A new attribute for LunDisk with VIRTIO_SCSI interface - Added ScsiGenericIO enum - Updated api.xsd, rsdl_metadata.yaml and DiskMapper accordingly * New ActionGroup: CONFIGURE_SCSI_GENERIC_IO - Updated PermitType and PermitMapper accordingly [1] 'sgio': SCSI Generic IO - filtered/unfiltered (indicates whether the OS kernel will filter unprivileged SG_IO commands for the disk). * Feature page: http://www.ovirt.org/Features/Virtio-SCSI Change-Id: I8fdf89d826144885bcffd8ee29798102fcaceb44 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/DiskInterface.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/PermitType.java A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/ScsiGenericIO.java M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendCapabilitiesResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/utils/FeaturesHelper.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/DiskMapper.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/PermitMapper.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/DiskMapperTest.java 10 files changed, 107 insertions(+), 1 deletion(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14907 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8fdf89d826144885bcffd8ee29798102fcaceb44 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: introducing virtio-scsi support
by derez＠redhat.com 20 Jun '13

20 Jun '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: introducing virtio-scsi support ...................................................................... webadmin: introducing virtio-scsi support A new DiskInterface: VirtIO_SCSI * Updated GetDiskInterfaceList in AsyncDataProvider * Filtered for unsupported cluster versions (using VirtIoScsiEnabled ConfigurationValue) SGIO [1] * Avaiable only for DirectLUN disks with VirtIO_SCSI interface * Added a checkbox next to DiskInterface editor: "Allow Privileged SCSI I/O" * Restriced by MLA permissions - Added CONFIGURE_SCSI_GENERIC_IO ActionGroup to RoleTreeView under Disk node: "Manipulate SCSI I/O Privileges" (Admin roles only) [updated Enums, LocalizedEnums, AppErrors and Constants accordingly] [1] 'sgio': SCSI Generic IO - filtered/unfiltered (indicates whether the OS kernel will filter unprivileged SG_IO commands for the disk). * Feature page: http://www.ovirt.org/Features/Virtio-SCSI Change-Id: Ia5b3926650586783388bf36fae399e76999843dd Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.ui.xml M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/roles_ui/RoleTreeView.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/EditDiskModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewDiskModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Enums.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/Enums.properties M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 17 files changed, 100 insertions(+), 22 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14908 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia5b3926650586783388bf36fae399e76999843dd Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Cheryn Tan <cheryntan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: replace the word Weird with Unexpected in log
by yzaslavs＠redhat.com 20 Jun '13

20 Jun '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: replace the word Weird with Unexpected in log ...................................................................... core: replace the word Weird with Unexpected in log when xmlRpcStatus returned isn't found in VdcBllErrors enum write 'Unexpected return value: [xmlRpcStatus]' Change-Id: Ic06fe252f8e801973a44bb26092117f530a59cb6 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=951908 Signed-off-by: Mooli Tayer <mtayer(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/BrokerCommandBase.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: mooli tayer: Verified Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15950 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic06fe252f8e801973a44bb26092117f530a59cb6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>

1 0

Change in otopi[master]: doc: fix typo
by Alon Bar-Lev 20 Jun '13

20 Jun '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: doc: fix typo ...................................................................... doc: fix typo Change-Id: I998344c1db5ed4d3446560656299098b7191ad20 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> Reported-By: Yedidyah Bar David <didi(a)redhat.com> --- M README 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15913 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I998344c1db5ed4d3446560656299098b7191ad20 Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in gerrit-admin[master]: Added the hook dispatcher
by dcaroest＠redhat.com 20 Jun '13

20 Jun '13

David Caro has submitted this change and it was merged. Change subject: Added the hook dispatcher ...................................................................... Added the hook dispatcher This script is in charge of selecting which hooks will run and managing the execution flow Change-Id: Iada3d1bef5357366d5f319561efac8ee85a614f0 Signed-off-by: David Caro <dcaroest(a)redhat.com> --- A hooks/hook-dispatcher 1 file changed, 337 insertions(+), 0 deletions(-) Approvals: Giuseppe Vallarelli: Looks good to me, but someone else must approve David Caro: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15386 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iada3d1bef5357366d5f319561efac8ee85a614f0 Gerrit-PatchSet: 3 Gerrit-Project: gerrit-admin Gerrit-Branch: master Gerrit-Owner: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Giuseppe Vallarelli <gvallare(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Ohad Basan <obasan(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: setup: force Apache proxy on upgrade
by juan.hernandez＠redhat.com 20 Jun '13

20 Jun '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: setup: force Apache proxy on upgrade ...................................................................... packaging: setup: force Apache proxy on upgrade Forcing migration to Apache proxy while upgrading an existing instance if not already enabled. Configure Apache SSL if needed in order to allow application using Apache proxy. Change-Id: Ib46bcf40acff860cd3e52634ade683d7a8836cf6 Bug-Url: https://bugzilla.redhat.com/905754 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M packaging/fedora/setup/engine-upgrade.py 1 file changed, 71 insertions(+), 28 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15051 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib46bcf40acff860cd3e52634ade683d7a8836cf6 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: setup: enforcing Apache proxy on new install
by juan.hernandez＠redhat.com 20 Jun '13

20 Jun '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: setup: enforcing Apache proxy on new install ...................................................................... packaging: setup: enforcing Apache proxy on new install Always override Apache configuration for enabling Apache proxy on new install. Dropped any check on freeipa-server and ipaserver packages in engine-setup code. Added conflicts with freeipa-server and ipa-server in spec file for both ovirt-engine and ovirt-engine-setup. Upgrading or installing with IPA on the system will not be allowed by yum / rpm. Removed duplicated constant EXEC_SEMANAGE. Apache http and https ports are not changed anymore, preserving existing configuration. Removed ports validation since we're not touching them. Removed check on Apache config changes made by user. Align legacy installer to engine-setup-2 behavior in non developer mode for Apache configuration. Change-Id: Iedce53634b3d20867fbb6b07efd82ea8bebed5e7 Bug-Url: https://bugzilla.redhat.com/905754 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-engine.spec.in M packaging/fedora/setup/basedefs.py M packaging/fedora/setup/common_utils.py M packaging/fedora/setup/engine-setup.py M packaging/fedora/setup/engine_validators.py M packaging/fedora/setup/output_messages.py 6 files changed, 45 insertions(+), 297 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15038 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iedce53634b3d20867fbb6b07efd82ea8bebed5e7 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in otopi[master]: core: add late setup and early misc to database
by Alon Bar-Lev 20 Jun '13

20 Jun '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: core: add late setup and early misc to database ...................................................................... core: add late setup and early misc to database Change-Id: I487c92e48133bef63c83e12850f528b6007f79aa Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> Reported-By: Yedidyah Bar David <didi(a)redhat.com> --- M src/otopi/plugin.py 1 file changed, 16 insertions(+), 0 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15891 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I487c92e48133bef63c83e12850f528b6007f79aa Gerrit-PatchSet: 2 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Users manage event tree view crash
by shavivi＠redhat.com 19 Jun '13

19 Jun '13

Shahar Havivi has submitted this change and it was merged. Change subject: webadmin: Users manage event tree view crash ...................................................................... webadmin: Users manage event tree view crash The dialog "Add new notifications" from Users->'Event Notifier'->'Manage Events' Have GWT Tree, currently GWT have a bug on clicking and dragging the mouse between the Tree rows cause the tree to crash. The workaround is to remove the row margins and increase the row spacing. Change-Id: Ifbaea5da050a0b044f2f1ccd20f2e536b9e59d7d Bug-Url: https://bugzilla.redhat.com/974206 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/user/ManageEventsPopupView.java A frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/css/NotificationsTree.css 2 files changed, 70 insertions(+), 1 deletion(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15885 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifbaea5da050a0b044f2f1ccd20f2e536b9e59d7d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0