- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: doc: developer: gwt fixups
by vszocs＠redhat.com 19 Jun '13

19 Jun '13

Vojtech Szocs has submitted this change and it was merged. Change subject: doc: developer: gwt fixups ...................................................................... doc: developer: gwt fixups Change-Id: I4aae2c5866a226d86acfb83415a52ef4b380d222 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M README.developer 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15827 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4aae2c5866a226d86acfb83415a52ef4b380d222 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Unable to restore from 3.1 LogCollector...
by yzaslavs＠redhat.com 19 Jun '13

19 Jun '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Unable to restore from 3.1 LogCollector... ...................................................................... core: Unable to restore from 3.1 LogCollector... Enhancing restore.sh to handle TAR files backup files created with LogCollector on 3.1 will fail to restore. This is due to the fact that LogCollector is using PG pg_dump utility with the TAR format in order to backup the database. Unfortunately, there is a bug (Tom Lane claims that this is a feature,) that in case that TAR format is used the -c flag of pg_dump is not honoured and will create always DROP statements for all database objects in the generated restore.sql script. (See http://www.postgresql.org/message-id/E1TrqX7-0002qd-4e@wrigleys.postgresql.…) The DROP statements caused DB errors when attempting to restore the backup by restore.sh was enhanced to check for the backup file type and handle it differently if it is a TAR. Steps to restore database: 1) drop existing DB with dropdb 2) re create a new blank db with the same name with createdb 3) use restore.sh to restore database from the backup file Change-Id: Id17f718d5acf7a4df00092875d308f52e6dd7e3f Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=960760 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/dbscripts/restore.sh 1 file changed, 43 insertions(+), 8 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15068 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id17f718d5acf7a4df00092875d308f52e6dd7e3f Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin, userportal: Add gwtdraft profile
by vszocs＠redhat.com 19 Jun '13

19 Jun '13

Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin,userportal: Add gwtdraft profile ...................................................................... webadmin,userportal: Add gwtdraft profile This patch adds new 'gwtdraft' profile that can be used during GWT compilation, for example: $ mvn clean install -Pdep,gwt-admin,gwtdraft When activated, 'gwtdraft' profile does following: - enable draft compile, i.e. prevent JavaScript code optimizations - set output style to 'detailed', i.e. produce pretty JavaScript without obfuscation This profile replaces 'gwtdev' when used during GWT compilation. 'gwtdev' now impacts debugging (launching GWT Development Mode) only. Change-Id: I447becb89a29f7c231007e33e1c5003829198ccb Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M Makefile M frontend/webadmin/modules/pom.xml M frontend/webadmin/modules/userportal-gwtp/pom.xml M frontend/webadmin/modules/webadmin/pom.xml 4 files changed, 18 insertions(+), 17 deletions(-) Approvals: Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15849 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I447becb89a29f7c231007e33e1c5003829198ccb Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: GMT timezone for linux vms
by tjelinek＠redhat.com 19 Jun '13

19 Jun '13

Tomas Jelinek has submitted this change and it was merged. Change subject: engine: GMT timezone for linux vms ...................................................................... engine: GMT timezone for linux vms frontend: - timezone list box is not changable for linux vms, default timezone is used backend: - forbid utcDiff update on VM for linux VMS - when creating vm, zero offset is default for linux vms (instead of general offset specified in config) - db upgrade - set utc_diff to 0 and time_zone = '' for linux vms in db Change-Id: If681a23a450a22685c7110a337b08f3c67609c34 Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=967861 --- A backend/manager/dbscripts/upgrade/03_03_0250_upgrade_utcdiff_and_timezone_for_linux.sql M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java 5 files changed, 19 insertions(+), 3 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Frank Kobzik: Verified -- To view, visit http://gerrit.ovirt.org/15802 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If681a23a450a22685c7110a337b08f3c67609c34 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Aaron Bawcom <abawcom(a)reflexsystems.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Martin Beták <mbetak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: history: change minimal etl version to 3.3.0
by yzaslavs＠redhat.com 19 Jun '13

19 Jun '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: history: change minimal etl version to 3.3.0 ...................................................................... history: change minimal etl version to 3.3.0 Change-Id: Ie48f5c1808ae254524d82fe15f64d487c310bd0c Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15880 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie48f5c1808ae254524d82fe15f64d487c310bd0c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Eli Mesika <elimesika(a)gmail.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine:Gluster events added to event_map
by emesika＠redhat.com 19 Jun '13

19 Jun '13

Eli Mesika has submitted this change and it was merged. Change subject: engine:Gluster events added to event_map ...................................................................... engine:Gluster events added to event_map Gluster hooks and swift service events added to event_map for notifications Change-Id: I3eb138f7364015a6e759fcd6f2911d3ac5a6b33e Bug-Url: https://bugzilla.redhat.com/971824 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- A backend/manager/dbscripts/upgrade/03_03_0240_add_gluster_hooks_services_events.sql 1 file changed, 17 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15712 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3eb138f7364015a6e759fcd6f2911d3ac5a6b33e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Eli Mesika <elimesika(a)gmail.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine:Delete action version map entry for remove gluster se...
by emesika＠redhat.com 19 Jun '13

19 Jun '13

Eli Mesika has submitted this change and it was merged. Change subject: engine:Delete action version map entry for remove gluster server ...................................................................... engine:Delete action version map entry for remove gluster server There's currently an action_version_map entry for RemoveGlusterServer command set to 3.2 cluster level. This causes inconsistency as detach server does not work in a 3.1 cluster, while remove host does. Changing the cluster level to 3.1 as Remove gluster server works in 3.1 cluster as well Change-Id: I8accb418a646a14f822602be577567e2fc169ad1 Bug-Url: https://bugzilla.redhat.com/971078 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- A backend/manager/dbscripts/upgrade/03_03_0230_update_removeglusterserver_action_version_map.sql 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved Sahina Bose: Verified -- To view, visit http://gerrit.ovirt.org/15826 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8accb418a646a14f822602be577567e2fc169ad1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Eli Mesika <elimesika(a)gmail.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: move images handling methods to ImagesHandler
by amureini＠redhat.com 19 Jun '13

19 Jun '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: move images handling methods to ImagesHandler ...................................................................... core: move images handling methods to ImagesHandler Currently there are images related methods placed in ImportVmCommand that are also being executed from other commands than ImportVm - therefore in this patch those methods are moved to ImagesHandler. Change-Id: Ic548bd5a805c0b7d702c0d363434234f6484fc25 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetVmsFromExportDomainQuery.java 3 files changed, 73 insertions(+), 73 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15627 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic548bd5a805c0b7d702c0d363434234f6484fc25 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: add canDoAction to remove storage connection
by amureini＠redhat.com 19 Jun '13

19 Jun '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: add canDoAction to remove storage connection ...................................................................... core: add canDoAction to remove storage connection Add canDoAction validations before removing a storage connection that there are no storage domains nor lun disks using that connection. Also add corresponding unitests. Change-Id: Ib7a633b06195a7b8ca1cd4fc5023c05010a3161d Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStorageServerConnectionCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageServerConnectionCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStorageServerConnectionCommand.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/RemoveStorageServerConnectionCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 9 files changed, 374 insertions(+), 18 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15269 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib7a633b06195a7b8ca1cd4fc5023c05010a3161d Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Cheryn Tan <cheryntan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: add validation non empty connection field
by amureini＠redhat.com 19 Jun '13

19 Jun '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: add validation non empty connection field ...................................................................... core: add validation non empty connection field Check that the connection field is not empty in StorageServerConnections object. Add corresponding error message, use the error in AddStorageServerConnection and UpdateStorageServerConnection commands, and add unit tests. Change-Id: I0d9d133faa54e74a9c4c14a93edb6bd16a9ee796 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageServerConnectionCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStorageServerConnectionCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/AddStorageServerConnectionCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 9 files changed, 65 insertions(+), 0 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15560 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0d9d133faa54e74a9c4c14a93edb6bd16a9ee796 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Cheryn Tan <cheryntan(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0