- Engine-commits - oVirt List Archives

Change in ovirt-engine-sdk-java[master]: codegen: implement support for the /capabilities resource
by mpastern＠redhat.com 12 Jun '13

12 Jun '13

Michael Pasternak has submitted this change and it was merged. Change subject: codegen: implement support for the /capabilities resource ...................................................................... codegen: implement support for the /capabilities resource Change-Id: Ie4d3b54769efaa4dbf51622c1d3be3c73a5675c9 Signed-off-by: Michael pasternak <mpastern(a)redhat.com> --- M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/rsdl/RsdlCodegen.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/Api.java A ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Capabilities.java A ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VersionCaps.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/BaseResources.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/Capabilities.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/VersionCaps.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/utils/CollectionUtils.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/utils/StringUtils.java 9 files changed, 435 insertions(+), 63 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15611 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie4d3b54769efaa4dbf51622c1d3be3c73a5675c9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine-sdk-java[master]: build: auto-generate and deploy javadoc
by mpastern＠redhat.com 12 Jun '13

12 Jun '13

Michael Pasternak has submitted this change and it was merged. Change subject: build: auto-generate and deploy javadoc ...................................................................... build: auto-generate and deploy javadoc Change-Id: Id8e8a84d58cf0162ec69dd8cdbf538c9537457c5 Signed-off-by: Michael pasternak <mpastern(a)redhat.com> --- M ovirt-engine-sdk-java/ovirt-engine-sdk-java.spec.in 1 file changed, 4 insertions(+), 3 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15610 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id8e8a84d58cf0162ec69dd8cdbf538c9537457c5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: save memory state on live snapshot with memory
by ofrenkel＠redhat.com 12 Jun '13

12 Jun '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: save memory state on live snapshot with memory ...................................................................... core: save memory state on live snapshot with memory On creation of live snapshot with memory, we create two volumes, one for the memory dump and one for the vm configuration at the moment of the snapshot creation (that vdsm saves). Those volumes are stored on the snapshot entity in a similar way to how the hibernation volumes which are created on suspend VM command are stored, and they are passed to the live snapshot verb in vdsm. Change-Id: Ic7ceb07bf73e722bf4566989446e7dbba78a2ccb Bug-Url: https://bugzilla.redhat.com/960931 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/dbscripts/snapshots_sp.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HibernateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/DefaultMemoryImageBuilder.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/MemoryImageBuilder.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/NullableMemoryImageBuilder.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/SnapshotsManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/TaskHandlerCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/CreateAllSnapshotsFromVmParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/SnapshotDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/SnapshotDaoDbFacadeImpl.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/SnapshotDaoTest.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 20 files changed, 442 insertions(+), 61 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15608 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic7ceb07bf73e722bf4566989446e7dbba78a2ccb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: make Capabilities::BaseResources in sake of complia...
by mpastern＠redhat.com 12 Jun '13

12 Jun '13

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: make Capabilities::BaseResources in sake of compliance with cross api collection pattern ...................................................................... restapi: make Capabilities::BaseResources in sake of compliance with cross api collection pattern Change-Id: I39cb724a154b9abe952d83235f318eafe72d15a6 Signed-off-by: Michael pasternak <mpastern(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd 1 file changed, 16 insertions(+), 12 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15605 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I39cb724a154b9abe952d83235f318eafe72d15a6 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: Added VmPool.max_assigned_vms_per_user
by mpastern＠redhat.com 12 Jun '13

12 Jun '13

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: Added VmPool.max_assigned_vms_per_user ...................................................................... restapi: Added VmPool.max_assigned_vms_per_user Added max_assigned_vms_per_user to vmpool Change-Id: I9bbe202d92761b5ea2597ef5a87bd62cfec2a9bc Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmPoolMapper.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/VmPoolMapperTest.java 4 files changed, 8 insertions(+), 2 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14006 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9bbe202d92761b5ea2597ef5a87bd62cfec2a9bc Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Beták <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Beták <mbetak(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: edit path for localstorage
by derez＠redhat.com 12 Jun '13

12 Jun '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: edit path for localstorage ...................................................................... webadmin: edit path for localstorage Add ability to edit path for local storage in Storage tab in webadmin. The edit will be possible for storage domains in maintenance. Change-Id: Ice7ee59325fb5a6d0eafde6e6e37c866bc662bc9 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStorageServerConnectionCommand.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/AbstractStorageView.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/LocalStorageView.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 8 files changed, 44 insertions(+), 59 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15540 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ice7ee59325fb5a6d0eafde6e6e37c866bc662bc9 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: userportal, webadmin: Fix failing unit tests
by vszocs＠redhat.com 12 Jun '13

12 Jun '13

Vojtech Szocs has submitted this change and it was merged. Change subject: userportal,webadmin: Fix failing unit tests ...................................................................... userportal,webadmin: Fix failing unit tests - Fixed failing unit tests when the environment doesn't have ENGINE_ETC defined. Change-Id: I8ad20a52daa459188e15e512bb78c97a07364cbc Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/BrandingServlet.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/GwtDynamicHostPageServlet.java M frontend/webadmin/modules/frontend/src/test/java/org/ovirt/engine/ui/frontend/server/gwt/AbstractGwtDynamicHostPageServletTest.java M frontend/webadmin/modules/frontend/src/test/java/org/ovirt/engine/ui/frontend/server/gwt/BrandingServletTest.java 4 files changed, 17 insertions(+), 23 deletions(-) Approvals: Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15575 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8ad20a52daa459188e15e512bb78c97a07364cbc Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: pki: scripts rework
by oschreib＠redhat.com 12 Jun '13

12 Jun '13

Ofer Schreiber has submitted this change and it was merged. Change subject: pki: scripts rework ...................................................................... pki: scripts rework there is a need to reuse some of the logic post installation. split scripts, fixup shell usage, add error handling, named parameters and more. move scripts to engine bin directory, /etc is no place for executables. yet there is a long way to go to cleanup the pki module. Usage: pki-create-ca.sh [OPTIONS] Create certificate authority. --subject=subject X.500 subject name. --keystore-password=password Password for keystore. Usage: pki-enroll-pkcs12.sh [OPTIONS] Generate key, enroll certificate, store in PKCS#12 format. Result will be at /etc/pki/ovirt-engine/keys/PREFIX.p12 --name=prefix file name without prefix. --password=password password of PKCS#12. --subject=subject X.500 subject name. --keep-key reissue certificate based on previous request. Usage: pki-enroll-request.sh [OPTIONS] Sign certificate request. Certificate request should be put at: /etc/pki/ovirt-engine/requests/PREFIX.req Certificate will be available at: /etc/pki/ovirt-engine/certs/PREFIX.cer --name=prefix file name. --subject=subject X.500 subject name. --days=n issue days. --timeout=n lock timeout, default=20 Change-Id: I8f3a8ae1fb061532cdafd5bc7961c5178d7948a0 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M .gitignore M Makefile M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsDeploy.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/hostinstall/OpenSslCAWrapper.java M ovirt-engine.spec.in A packaging/bin/pki-common.sh.in A packaging/bin/pki-create-ca.sh A packaging/bin/pki-enroll-pkcs12.sh A packaging/bin/pki-enroll-request.sh D packaging/etc/pki/CreateCA.sh D packaging/etc/pki/SignReq.lock D packaging/etc/pki/SignReq.sh M packaging/etc/pki/cacert.template.in M packaging/etc/pki/cert.template.in D packaging/etc/pki/certs/.keep D packaging/etc/pki/installCA.sh D packaging/etc/pki/keys/.keep D packaging/etc/pki/private/.keep D packaging/etc/pki/requests/.keep M packaging/fedora/setup/basedefs.py M packaging/fedora/setup/engine-setup.py M packaging/setup/ovirt_engine_setup/constants.py M packaging/setup/plugins/ovirt-engine-setup/pki/ca.py 23 files changed, 460 insertions(+), 312 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15499 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8f3a8ae1fb061532cdafd5bc7961c5178d7948a0 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: findbugs: method may fail to close resource
by shavivi＠redhat.com 12 Jun '13

12 Jun '13

Shahar Havivi has submitted this change and it was merged. Change subject: findbugs: method may fail to close resource ...................................................................... findbugs: method may fail to close resource OBL: Method may fail to clean up stream or resource on checked exception (OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE) Change-Id: I717fa1ecf687517a0b952d8649e2a0cda7a9fd26 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/KrbConfCreator.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomains.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/tools/common/db/StandaloneDataSource.java 3 files changed, 17 insertions(+), 18 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15324 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I717fa1ecf687517a0b952d8649e2a0cda7a9fd26 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: findbugs: convert to double on integer values before casting...
by shavivi＠redhat.com 12 Jun '13

12 Jun '13

Shahar Havivi has submitted this change and it was merged. Change subject: findbugs: convert to double on integer values before casting them ...................................................................... findbugs: convert to double on integer values before casting them Doing division on integers truncates the result to the integer value closest to zero. ICAST: integral division result cast to double or float (ICAST_IDIV_CAST_TO_DOUBLE) Change-Id: I3f3aa3ccef90c2cc63d5192d892eadb054254def Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/IntegerSlider.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/SliderBar.java 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15281 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3f3aa3ccef90c2cc63d5192d892eadb054254def Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0