- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: reuse updateStorageDomain in StorageListModel
by derez＠redhat.com 16 Jun '13

16 Jun '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: reuse updateStorageDomain in StorageListModel ...................................................................... webadmin: reuse updateStorageDomain in StorageListModel Reuse updateStorageDomain code in StorageListModel by extracting it to a separate method instead of duplicating it as it is today. Change-Id: Ie9c28c751237876f85df360cf29dc8e1d16e4a77 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java 1 file changed, 14 insertions(+), 35 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15661 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie9c28c751237876f85df360cf29dc8e1d16e4a77 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: reuse command creation in StorageListModel
by derez＠redhat.com 16 Jun '13

16 Jun '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: reuse command creation in StorageListModel ...................................................................... webadmin: reuse command creation in StorageListModel Reuse UICommand creation (OK, Cancel, etc) in StorageListModel by extracting it to separate methods. Change-Id: Ib3dc143c78ddb7371b7e2ec77f3b6600391b470d Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java 1 file changed, 31 insertions(+), 46 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15658 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib3dc143c78ddb7371b7e2ec77f3b6600391b470d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: Correcting nfs service (nfs-server) name for Fedo...
by juan.hernandez＠redhat.com 16 Jun '13

16 Jun '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: Correcting nfs service (nfs-server) name for Fedora ...................................................................... packaging: Correcting nfs service (nfs-server) name for Fedora The current service name "nfs-service" is wrong. The consequence is nfs service not being started by engine-setup. This patch fixes the nfs servie name to "nfs-server", the correct name for Fedora. Change-Id: Idb273004e6123b2ed771eec19c986eb0f84de957 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=974633 Signed-off-by: Amador Pahim <apahim(a)redhat.com> --- M packaging/fedora/setup/engine-setup.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15730 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idb273004e6123b2ed771eec19c986eb0f84de957 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Amador Pahim <apahim(a)redhat.com> Gerrit-Reviewer: Amador Pahim <apahim(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>

1 0

Change in otopi[master]: packaging: setup: handle a yum error when no groups
by Alon Bar-Lev 15 Jun '13

15 Jun '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: packaging: setup: handle a yum error when no groups ...................................................................... packaging: setup: handle a yum error when no groups apparently, when querying yum for group, if no groups at all it raises an exception instead of return empty set. this is unexpected behavior of an api. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=973383 Change-Id: Ifb1f196006662d6571c7ca80554e0a9a17aaec2a Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M src/otopi/miniyum.py 1 file changed, 7 insertions(+), 4 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15746 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifb1f196006662d6571c7ca80554e0a9a17aaec2a Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: build: gwt draft build support
by derez＠redhat.com 14 Jun '13

14 Jun '13

Daniel Erez has submitted this change and it was merged. Change subject: packaging: build: gwt draft build support ...................................................................... packaging: build: gwt draft build support Change-Id: I90e52c7880a5b403937c3b179db6ea39e35fd2e7 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M Makefile M README.developer 2 files changed, 8 insertions(+), 1 deletion(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15726 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I90e52c7880a5b403937c3b179db6ea39e35fd2e7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>

1 0

Change in ovirt-engine[master]: build: enhance gwt-debug target
by derez＠redhat.com 14 Jun '13

14 Jun '13

Daniel Erez has submitted this change and it was merged. Change subject: build: enhance gwt-debug target ...................................................................... build: enhance gwt-debug target 1. add dev build flags to maven execution. 2. set default application port to 8080. Change-Id: I3b2d466b0bef36483f4a688f98eb603d67b2dc8e Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> Reported-By: Daniel Erez <derez(a)redhat.com> --- M Makefile M frontend/webadmin/modules/pom.xml 2 files changed, 10 insertions(+), 2 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15723 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3b2d466b0bef36483f4a688f98eb603d67b2dc8e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>

1 0

Change in ovirt-engine[master]: gluster: Added missing messages for gluster hooks
by kmayilsa＠redhat.com 14 Jun '13

14 Jun '13

Kanagaraj M has submitted this change and it was merged. Change subject: gluster: Added missing messages for gluster hooks ...................................................................... gluster: Added missing messages for gluster hooks Added missing front-end messages for gluster hooks. Change-Id: Ic73940937f7ca427bfdf96ff898922010c72199d Bug-Url: https://bugzilla.redhat.com/971676 Bug-Url: https://bugzilla.redhat.com/971658 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 4 files changed, 20 insertions(+), 0 deletions(-) Approvals: Kanagaraj M: Looks good to me, approved Sahina Bose: Verified -- To view, visit http://gerrit.ovirt.org/15711 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic73940937f7ca427bfdf96ff898922010c72199d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com>

1 0

Change in ovirt-engine[master]: gluster: Corrected cluster service status value
by kmayilsa＠redhat.com 14 Jun '13

14 Jun '13

Kanagaraj M has submitted this change and it was merged. Change subject: gluster: Corrected cluster service status value ...................................................................... gluster: Corrected cluster service status value Corrected the cluster service status value to be shown as Up/Down instead of RUNNING/STOPPED. Change-Id: I20306b662c23f22e1228f560f8b82c0a031da81b Bug-Url: https://bugzilla.redhat.com/973608 Signed-off-by: Shubhendu Tripathi <shtripat(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/SubTabClusterServiceView.java 1 file changed, 7 insertions(+), 3 deletions(-) Approvals: Shubhendu Tripathi: Verified Kanagaraj M: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15709 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I20306b662c23f22e1228f560f8b82c0a031da81b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com>

1 0

Change in otopi[master]: system: info: add user id information
by Alon Bar-Lev 13 Jun '13

13 Jun '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: system: info: add user id information ...................................................................... system: info: add user id information Change-Id: I6b00e6a2310d58aa8efbc825637d73506afe315e Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M src/plugins/otopi/system/info.py 1 file changed, 8 insertions(+), 0 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15689 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6b00e6a2310d58aa8efbc825637d73506afe315e Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in ovirt-dwh[master]: history: change needed fuction location to pre-upgrade
by ydary＠redhat.com 13 Jun '13

13 Jun '13

Yaniv Dary has submitted this change and it was merged. Change subject: history: change needed fuction location to pre-upgrade ...................................................................... history: change needed fuction location to pre-upgrade Change-Id: Id0e0bd79e75df17c6ff01b50ae8184cc910db66b Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M data-warehouse/historydbscripts_postgres/create_sp.sql M data-warehouse/historydbscripts_postgres/upgrade/03_02_0050_add_function_to_update_enum_table.sql A data-warehouse/historydbscripts_postgres/upgrade/pre_upgrade/add_function_to_update_enum_table.sql 3 files changed, 15 insertions(+), 28 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15677 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id0e0bd79e75df17c6ff01b50ae8184cc910db66b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0