- Engine-commits - oVirt List Archives

Change in ovirt-engine-sdk-java[master]: codegen: remove trailing whitespaces
by mpastern＠redhat.com 13 Jun '13

13 Jun '13

Michael Pasternak has submitted this change and it was merged. Change subject: codegen: remove trailing whitespaces ...................................................................... codegen: remove trailing whitespaces Change-Id: I1f4db18485cd483bb9208328394dd0f85a66249f Signed-off-by: Michael pasternak <mpastern(a)redhat.com> --- M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/templates/CollectionAddMethodTemplate M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/templates/CollectionGetterTemplate M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/templates/CollectionTemplate M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/templates/ResourceTemplate M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/templates/SubCollectionAddMethodTemplate M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/templates/SubResourceTemplate M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/Api.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Capabilities.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Cluster.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/ClusterGlusterVolume.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/ClusterGlusterVolumeGlusterBrick.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/ClusterGlusterVolumeGlusterBrickStatistic.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/ClusterGlusterVolumeGlusterBricks.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/ClusterGlusterVolumes.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/ClusterNetwork.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/ClusterNetworks.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/ClusterPermission.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/ClusterPermissions.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Clusters.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenter.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterCluster.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterClusterGlusterVolume.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterClusterGlusterVolumeGlusterBrick.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterClusterGlusterVolumeGlusterBrickStatistic.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterClusterGlusterVolumeGlusterBricks.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterClusterGlusterVolumes.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterClusterNetwork.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterClusterNetworks.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterClusterPermission.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterClusterPermissions.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterClusters.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterPermission.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterPermissions.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterQuota.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterStorageDomain.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterStorageDomainDisk.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterStorageDomainDiskPermission.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterStorageDomainDiskPermissions.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterStorageDomainDiskStatistic.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterStorageDomainDisks.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterStorageDomains.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenters.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Disk.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DiskPermission.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DiskPermissions.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DiskStatistic.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Disks.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Domain.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DomainGroup.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DomainUser.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Domains.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Event.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Events.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Group.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/GroupPermission.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/GroupPermissions.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/GroupRole.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/GroupRolePermit.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/GroupRolePermits.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/GroupRoles.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/GroupTag.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/GroupTags.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Groups.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Host.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/HostHook.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/HostNIC.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/HostNICStatistic.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/HostNICs.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/HostPermission.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/HostPermissions.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/HostStatistic.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/HostTag.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/HostTags.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Hosts.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Network.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/NetworkPermission.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/NetworkPermissions.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Networks.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Role.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/RolePermit.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/RolePermits.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Roles.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/StorageDomain.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/StorageDomainDisk.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/StorageDomainDiskPermission.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/StorageDomainDiskPermissions.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/StorageDomainDiskStatistic.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/StorageDomainDisks.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/StorageDomainFile.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/StorageDomainPermission.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/StorageDomainPermissions.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/StorageDomainTemplate.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/StorageDomainTemplateDisk.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/StorageDomainVM.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/StorageDomainVMDisk.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/StorageDomains.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Tag.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Tags.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Template.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/TemplateCdRom.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/TemplateDisk.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/TemplateNIC.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/TemplateNICs.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/TemplatePermission.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/TemplatePermissions.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Templates.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/User.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/UserPermission.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/UserPermissions.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/UserRole.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/UserRolePermit.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/UserRolePermits.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/UserRoles.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/UserTag.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/UserTags.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Users.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VM.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMApplication.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMCdRom.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMCdRoms.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMDisk.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMDiskPermission.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMDiskPermissions.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMDiskStatistic.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMDisks.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMNIC.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMNICReportedDevice.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMNICStatistic.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMNICs.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMPermission.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMPermissions.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMReportedDevice.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMSnapshot.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMSnapshotCdRom.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMSnapshotDisk.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMSnapshotNIC.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMSnapshots.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMStatistic.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMTag.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMTags.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMs.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VersionCaps.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VmPool.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VmPoolPermission.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VmPoolPermissions.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VmPools.java 146 files changed, 260 insertions(+), 257 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15616 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1f4db18485cd483bb9208328394dd0f85a66249f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine[master]: findbugs: ignore: Transient field is not set by deserializat...
by shavivi＠redhat.com 13 Jun '13

13 Jun '13

Shahar Havivi has submitted this change and it was merged. Change subject: findbugs: ignore: Transient field is not set by deserialization ...................................................................... findbugs: ignore: Transient field is not set by deserialization findbugs reason: Se: Transient field that isn't set by deserialization. (SE_TRANSIENT_FIELD_NOT_RESTORED) Change-Id: I7bb8a32a3d458f40ca8beba7c0115927c1f4bd42 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M backend/manager/modules/common/exclude-filters.xml 1 file changed, 30 insertions(+), 0 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15329 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7bb8a32a3d458f40ca8beba7c0115927c1f4bd42 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: findbugs: Loaded null value of local variables
by shavivi＠redhat.com 13 Jun '13

13 Jun '13

Shahar Havivi has submitted this change and it was merged. Change subject: findbugs: Loaded null value of local variables ...................................................................... findbugs: Loaded null value of local variables findbugs reason: NP: Load of known null value (NP_LOAD_OF_KNOWN_NULL_VALUE) Change-Id: Ic0e90d1783caac1e9e769550c15f46c868d45bb2 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/LocaleUtils.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ObjectIdentityChecker.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmReader.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/basic/VmTypeImage.java 5 files changed, 10 insertions(+), 6 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15321 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic0e90d1783caac1e9e769550c15f46c868d45bb2 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Don't use IsVmWithSameNameExistsQuery in BE
by amureini＠redhat.com 13 Jun '13

13 Jun '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Don't use IsVmWithSameNameExistsQuery in BE ...................................................................... core: Don't use IsVmWithSameNameExistsQuery in BE Backend does not have to use IsVmWithSameNameExistsQuery, it can invoke VmHandler directly, saving the overhead of another query object. Change-Id: Iad6411245bf53a8f07139b3b36c9892e55809cea Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmManagementCommandBase.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmCommandTest.java 7 files changed, 12 insertions(+), 40 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15060 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iad6411245bf53a8f07139b3b36c9892e55809cea Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Remove name query parameters containers
by amureini＠redhat.com 13 Jun '13

13 Jun '13

Allon Mureinik has submitted this change and it was merged. Change subject: engine: Remove name query parameters containers ...................................................................... engine: Remove name query parameters containers This patch removes all the query parameter classes that are nothing more than containers for an entity name and replaces all their usages with NameQueryParameters. Change-Id: Ie17feb6bb06323b090dafeefa00ea96c4cc4d5a4 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllAuditLogsByVMNameQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllAuditLogsByVMTemplateNameQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetRoleByNameQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetTagByTagNameQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVdsByNameQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVdsGroupByNameQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsVmPoolWithSameNameExistsQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsVmTemlateWithSameNameExistQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsVmWithSameNameExistQuery.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetAllAuditLogsByVMNameQueryTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetAllAuditLogsByVMTemplateNameQueryTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/IsVmWithSameNameExistQueryTest.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetAllAuditLogsByVMNameParameters.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetAllAuditLogsByVMTemplateNameParameters.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetTagByTagNameParameters.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetTagByTagNameParametersBase.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetVdsByNameParameters.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetVdsGroupByNameParameters.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/IsVmPoolWithSameNameExistsParameters.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/IsVmTemlateWithSameNameExistParameters.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/IsVmWithSameNameExistParameters.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/MultilevelAdministrationByRoleNameParameters.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/NameQueryParameters.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendActionableResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendAssignedRolesResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTagsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmsResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendAssignedRolesResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendTagResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendTagsResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmResourceTest.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/UserPortalTemplateEventListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UserPortalVmEventListModel.java 34 files changed, 92 insertions(+), 259 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15182 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie17feb6bb06323b090dafeefa00ea96c4cc4d5a4 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Remove Guid query parameters containers
by amureini＠redhat.com 13 Jun '13

13 Jun '13

Allon Mureinik has submitted this change and it was merged. Change subject: engine: Remove Guid query parameters containers ...................................................................... engine: Remove Guid query parameters containers This patch removes all the query parameter classes that are nothing more than containers for a Guid and replaces all their usages with IdQueryParameters. Change-Id: I636818d92b87cdb40cb745f28b049d4bd7cabec7 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllDisksByStorageDomainIdQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllDisksByVmIdQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllRelevantQuotasForStorageQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllRelevantQuotasForVdsGroupQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllVdsByStoragePoolQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllVmSnapshotsByVmIdQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAvailableClusterVersionsByStoragePoolQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAvailableStoragePoolVersionsQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetEventSubscribersBySubscriberIdGroupedQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetHostsByClusterIdQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetHostsForStorageOperationQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetJobByJobIdQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetNextAvailableDiskAliasNameByVMIdQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetPermissionByIdQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetPermissionByRoleIdQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetPermissionsByAdElementIdQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetPermissionsToConsumeQuotaByQuotaIdQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetQuotaByQuotaIdQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetQuotaByStoragePoolIdQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetQuotaStorageByQuotaIdQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetQuotaVdsGroupByQuotaIdQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetRoleActionGroupsByRoleIdQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetRoleByIdQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetTagByTagIdQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetTemplatesRelatedToQuotaIdQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVdsGroupByIdQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVdsGroupByVdsGroupIdQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVdsGroupsByStoragePoolIdQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVdsHooksByIdQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmConfigurationBySnapshotQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmDataByPoolIdQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmPoolByIdQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmTemplatesByImageGuidQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmTemplatesByStoragePoolIdQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmTemplatesDisksQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmTemplatesFromStorageDomainQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmsByDiskGuidQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmsRelatedToQuotaIdQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmsRunningOnOrMigratingToVdsQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetStorageDomainByIdQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetStorageDomainListByIdQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetStorageDomainsByImageIdQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetStorageDomainsByStoragePoolIdQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetStorageDomainsByVmTemplateIdQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetStoragePoolByIdQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetStoragePoolsByStorageDomainIdQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetVmsByStorageDomainQuery.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetAllDisksByVmIdQueryTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetAllRelevantQuotasForStorageQueryTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetAllRelevantQuotasForVdsGroupQueryTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetAllVdsByStoragePoolQueryTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetAllVmSnapshotsByVmIdQueryTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetHostsForStorageOperationQueryTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetNextAvailableDiskAliasNameByVMIdQueryTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetPermissionsByAdElementIdQueryTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetPermissionsToConsumeQuotaByQuotaIdQueryTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetQuotaStorageByQuotaIdQueryTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetQuotaVdsGroupByQuotaIdQueryTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetRoleActionGroupsByRoleIdQueryTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetTemplatesRelatedToQuotaIdQueryTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetVdsGroupByIdQueryTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetVdsGroupsByStoragePoolIdQueryTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetVmConfigurationBySnapshotQueryTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetVmPoolByIdQueryTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetVmTemplatesByImageGuidQueryTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetVmsByImageGuidQueryTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetVmsRelatedToQuotaIdTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetVmsRunningOnOrMigratingToVdsQueryTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/GetStorageDomainByIdQueryTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/GetStorageDomainsByImageIdQueryTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/GetStorageDomainsByStoragePoolIdQueryTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/GetStoragePoolByIdQueryTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/GetVmsByStorageDomainQueryTest.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetAllDisksByVmIdParameters.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetAllRelevantQuotasForStorageParameters.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetAllRelevantQuotasForVdsGroupParameters.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetAllVdsByStoragePoolParameters.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetAllVmSnapshotsByVmIdParameters.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetAvailableClusterVersionsByStoragePoolParameters.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetAvailableStoragePoolVersionsParameters.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetEntitiesRelatedToQuotaIdParameters.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetEventSubscribersBySubscriberIdParameters.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetHostsByClusterIdParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetHostsForStorageOperationParameters.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetJobByJobIdQueryParameters.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetQuotaByQuotaIdQueryParameters.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetQuotaByStoragePoolIdQueryParameters.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetQuotaStorageByQuotaIdQueryParameters.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetQuotaVdsGroupByQuotaIdQueryParameters.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetStorageDomainsByImageIdParameters.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetStorageDomainsByVmTemplateIdQueryParameters.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetTagByTagIdParameters.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetVdsGroupByIdParameters.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetVdsGroupByVdsGroupIdParameters.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetVdsHooksByIdParameters.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetVmConfigurationBySnapshotQueryParams.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetVmPoolByIdParameters.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetVmPoolByIdParametersBase.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetVmTemplatesByImageGuidParameters.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetVmTemplatesByStoragePoolIdParameters.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetVmTemplatesDisksParameters.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetVmdataByPoolIdParameters.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetVmsByDiskGuidParameters.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetVmsRunningOnOrMigratingToVdsParameters.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/MultilevelAdministrationByAdElementIdParameters.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/MultilevelAdministrationByPermissionIdParameters.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/MultilevelAdministrationByRoleIdParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/StorageDomainQueryParametersBase.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/StoragePoolQueryParametersBase.java D backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/queries/GetAllRelevantQuotasForStorageParametersTest.java D backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/queries/GetAllRelevantQuotasForVdsGroupParametersTest.java D backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/queries/GetVmTemplatesByImageGuidParametersTest.java D backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/queries/GetVmsByImageGuidParametersTest.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendAssignedTagsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendStorageDomainContentResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendStorageDomainContentsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendAssignedPermissionsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendAssignedRolesResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendAttachedStorageDomainsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendClusterNetworksResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendClusterResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendClustersResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDataCenterClustersResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDataCenterResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDataCentersResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendFilesResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendGroupResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostHooksResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendPermissionResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendPermitsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendQuotaResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendQuotasResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendReadOnlyDisksResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendRoleResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendRolesResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendSnapshotsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainDisksResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTagResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplateResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplatesResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendUserResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmPoolResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmPoolsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmsResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendAssignedPermissionsResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendAssignedTagsResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendBaseTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendRoleResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendAssignedRolesResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendAttachedStorageDomainsResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendClusterNetworkResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendClusterNetworksResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendClusterResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendClustersResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendDataCenterClusterResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendDataCenterClustersResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendDataCenterResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendDataCentersResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendEntityAssignedPermissionsResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendExportDomainDiskResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendExportDomainDisksResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendFilesResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendGroupAssignedPermissionsResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendHostHooksResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendPermissionResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendPermitsResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendQuotasResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendReadOnlyDiskResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendReadOnlyDisksResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendRoleResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendRolesResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendSnapshotResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendSnapshotsResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainDisksResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainTemplateResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainTemplatesResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainVmResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainVmsResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainsResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendTagResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendTagsResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendTemplateDiskResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendTemplateDisksResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendTemplateResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendTemplatesResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendUserAssignedPermissionsResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmDiskResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmDisksResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmPoolResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmsResourceTest.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SystemTreeModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/roles_ui/RoleListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/roles_ui/RolePermissionListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterQuotaListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterStorageListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/disks/DiskStorageListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/disks/DiskTemplateListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/disks/DiskVmListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/events/TaskListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostHooksListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolDiskListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolGeneralModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolInterfaceListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/quota/ChangeQuotaModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/quota/QuotaClusterListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/quota/QuotaListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/quota/QuotaStorageListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/quota/QuotaTemplateListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/quota/QuotaUserListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/quota/QuotaVmListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/DisksAllocationModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageDataCenterListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageDiskListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageTemplateListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageVmListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateDiskListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateStorageListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/PoolItemBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalBasicListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalLoginModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/VmBasicDiskListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/users/UserEventNotifierListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/users/UserPermissionListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/RunOnceModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UserPortalExistingVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UserPortalNewVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UserPortalTemplateVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmAppListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmDiskListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmGeneralModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmSnapshotListModel.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 251 files changed, 978 insertions(+), 1,886 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15017 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I636818d92b87cdb40cb745f28b049d4bd7cabec7 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Noam Slomianko <nslomian(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: install-dev: Fix typo in README.developer
by mkolesni＠redhat.com 13 Jun '13

13 Jun '13

Mike Kolesnik has submitted this change and it was merged. Change subject: install-dev: Fix typo in README.developer ...................................................................... install-dev: Fix typo in README.developer Change-Id: I7a830b517dc71458f9513d83b76f17f8176b24cc Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M README.developer 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Mike Kolesnik: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/15617 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7a830b517dc71458f9513d83b76f17f8176b24cc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: build: add gwt-debug target
by ecohen＠redhat.com 12 Jun '13

12 Jun '13

Einav Cohen has submitted this change and it was merged. Change subject: build: add gwt-debug target ...................................................................... build: add gwt-debug target Change-Id: I620d59668a5a707778841fece2318cfd3271e7a9 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M Makefile M README.developer 2 files changed, 19 insertions(+), 0 deletions(-) Approvals: Einav Cohen: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15577 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I620d59668a5a707778841fece2318cfd3271e7a9 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: doc: branding: remove comment of unsupported development env...
by ecohen＠redhat.com 12 Jun '13

12 Jun '13

Einav Cohen has submitted this change and it was merged. Change subject: doc: branding: remove comment of unsupported development environment ...................................................................... doc: branding: remove comment of unsupported development environment the only supported environment is the development environment outlined in README.developer, no need to specify hacks nor effect system state (/etc) for development. Change-Id: I51562d60a179f7da9ba928746cd2d61e19b308a0 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M README.branding 1 file changed, 0 insertions(+), 4 deletions(-) Approvals: Einav Cohen: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15572 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I51562d60a179f7da9ba928746cd2d61e19b308a0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal, webadmin: Fix behavior unsupported locale
by vszocs＠redhat.com 12 Jun '13

12 Jun '13

Vojtech Szocs has submitted this change and it was merged. Change subject: userportal,webadmin: Fix behavior unsupported locale ...................................................................... userportal,webadmin: Fix behavior unsupported locale - Changed behavior to select en_US locale if the browser returns an unsupported locale. - Changed behavior to select close enough locale if the browser returns a close but unsupported locale for instance if the browser return es, then it will be transformed into es_ES as that is 'close' Change-Id: Ic5beceaf7f4ce2333e83cd72c3fa8721103cf805 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=838456 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M backend/manager/modules/root/src/main/java/org/ovirt/engine/core/SplashServlet.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/LocaleUtils.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/servlet/LocaleFilter.java R backend/manager/modules/utils/src/main/resources/org/ovirt/engine/core/utils/servlet/languages.properties M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/servlet/LocaleFilterTest.java 5 files changed, 73 insertions(+), 32 deletions(-) Approvals: Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15520 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic5beceaf7f4ce2333e83cd72c3fa8721103cf805 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0