- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: packaging: service: add debug when module returns
by oschreib＠redhat.com 07 Jun '13

07 Jun '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: service: add debug when module returns ...................................................................... packaging: service: add debug when module returns Change-Id: I0edd674e408087dc772ff58c274c1bbe0f392469 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/services/service.py 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15376 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0edd674e408087dc772ff58c274c1bbe0f392469 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0

Change in ovirt-engine[master]: novnc: use service debug instead of configuration
by oschreib＠redhat.com 07 Jun '13

07 Jun '13

Ofer Schreiber has submitted this change and it was merged. Change subject: novnc: use service debug instead of configuration ...................................................................... novnc: use service debug instead of configuration Change-Id: I8cf66fcbd19a72bd3ffebb82984124dc9e51d83c Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/conf/ovirt-websocket-proxy.conf.defaults.in M packaging/services/ovirt-websocket-proxy.py M packaging/services/service.py 3 files changed, 5 insertions(+), 2 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15387 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8cf66fcbd19a72bd3ffebb82984124dc9e51d83c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0

Change in ovirt-engine[master]: novnc: override get_target instead of new_client
by oschreib＠redhat.com 07 Jun '13

07 Jun '13

Ofer Schreiber has submitted this change and it was merged. Change subject: novnc: override get_target instead of new_client ...................................................................... novnc: override get_target instead of new_client seems to better follow the base class implementation, and does not duplicate communication logic into our code. Change-Id: I55d72f8f51d4502feec045138b31eaf69b46a323 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/services/ovirt-websocket-proxy.py 1 file changed, 9 insertions(+), 22 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15384 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I55d72f8f51d4502feec045138b31eaf69b46a323 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0

Change in ovirt-engine[master]: novnc: log file is actually trace file
by oschreib＠redhat.com 07 Jun '13

07 Jun '13

Ofer Schreiber has submitted this change and it was merged. Change subject: novnc: log file is actually trace file ...................................................................... novnc: log file is actually trace file disable per default, do not have default for name Change-Id: I2c0f9568b911d9985b9375baf5dac648ab211ea7 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/conf/ovirt-websocket-proxy.conf.defaults.in M packaging/services/ovirt-websocket-proxy.py 2 files changed, 6 insertions(+), 6 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15383 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2c0f9568b911d9985b9375baf5dac648ab211ea7 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0

Change in ovirt-engine[master]: novnc: cleanup defaults file
by oschreib＠redhat.com 07 Jun '13

07 Jun '13

Ofer Schreiber has submitted this change and it was merged. Change subject: novnc: cleanup defaults file ...................................................................... novnc: cleanup defaults file Change-Id: I7a88a18d1fac63385cfeb78c68bdd84b2b641d27 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/conf/ovirt-websocket-proxy.conf.defaults.in 1 file changed, 0 insertions(+), 4 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15382 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7a88a18d1fac63385cfeb78c68bdd84b2b641d27 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0

Change in ovirt-engine[master]: novnc: no need to raise terminate exception on termination
by oschreib＠redhat.com 07 Jun '13

07 Jun '13

Ofer Schreiber has submitted this change and it was merged. Change subject: novnc: no need to raise terminate exception on termination ...................................................................... novnc: no need to raise terminate exception on termination Change-Id: I95a23d72f87391bb4682a447c307129089bce3d2 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/services/ovirt-websocket-proxy.py 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15373 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I95a23d72f87391bb4682a447c307129089bce3d2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: multiple gateways
by alkaplan＠redhat.com 06 Jun '13

06 Jun '13

Alona Kaplan has submitted this change and it was merged. Change subject: engine: multiple gateways ...................................................................... engine: multiple gateways Allow configuring gateway also for networks that are not the management. Change-Id: I0d8e713a40086fda029e8f69388ee72c9540e8b8 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/AddBondCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelper.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/FeatureSupported.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/NetworkInterfaceValidator.java 7 files changed, 38 insertions(+), 11 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15330 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0d8e713a40086fda029e8f69388ee72c9540e8b8 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: findbugs: Unwritten public fields
by shavivi＠redhat.com 06 Jun '13

06 Jun '13

Shahar Havivi has submitted this change and it was merged. Change subject: findbugs: Unwritten public fields ...................................................................... findbugs: Unwritten public fields its mainly events or handlers that use by UI, assigned null instead of adding to ignore list findbugs reason: UwF: Unwritten public or protected field (UWF_UNWRITTEN_PUBLIC_OR_PROTECTED_FIELD) Change-Id: I8a8872dd0eb76ae0e4d92af54acec2807f6a1b64 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/BaseConditionFieldAutoCompleter.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AsyncQuery.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/tree/AbstractSubTabActionTree.java 3 files changed, 3 insertions(+), 3 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15402 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8a8872dd0eb76ae0e4d92af54acec2807f6a1b64 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0

Change in ovirt-engine[master]: findbugs: inaccurate floating point comparison
by shavivi＠redhat.com 06 Jun '13

06 Jun '13

Shahar Havivi has submitted this change and it was merged. Change subject: findbugs: inaccurate floating point comparison ...................................................................... findbugs: inaccurate floating point comparison This operation compares two floating point values for equality. Because floating point calculations may involve rounding, calculated float and double values may not be accurate findbugs reason: FE: Test for floating point equality (FE_FLOATING_POINT_EQUALITY) Change-Id: I0a5e61d30bff34ae5e381ff861dcdf4f97c65018 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaManager.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/EntityModelInputWithSlider.java 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15413 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0a5e61d30bff34ae5e381ff861dcdf4f97c65018 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0

Change in ovirt-engine[master]: findbugs: resultSet is not close after use
by shavivi＠redhat.com 06 Jun '13

06 Jun '13

Shahar Havivi has submitted this change and it was merged. Change subject: findbugs: resultSet is not close after use ...................................................................... findbugs: resultSet is not close after use findbugs reason: OBL: Method may fail to clean up stream or resource (OBL_UNSATISFIED_OBLIGATION) Change-Id: I8c00d797b737291e3aac8cea1817dfddc04f39a2 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/db/ConfigDaoImpl.java 1 file changed, 10 insertions(+), 2 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15415 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8c00d797b737291e3aac8cea1817dfddc04f39a2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0