- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: Use NetworkUtils.getEngineNetwork where possible
by masayag＠redhat.com 09 Jun '13

09 Jun '13

Moti Asayag has submitted this change and it was merged. Change subject: engine: Use NetworkUtils.getEngineNetwork where possible ...................................................................... engine: Use NetworkUtils.getEngineNetwork where possible The patch replaces same logic for resolving the management network name with NetworkUtils.getEngineNetwork. Change-Id: I76bd3d0de7d5d2db1656f17670d820f6384c0712 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsGroupCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/NetworkConfigurator.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UpdateNetworkCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/AddBondCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/UpdateNetworkToVdsInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddEmptyStoragePoolCommand.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/NetworkUtils.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CollectVdsNetworkDataVDSCommand.java 9 files changed, 21 insertions(+), 25 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15447 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I76bd3d0de7d5d2db1656f17670d820f6384c0712 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine-cli[cli_3.2]: cli: "exit" command fails after "disconnect" from script #97...
by mpastern＠redhat.com 09 Jun '13

09 Jun '13

Michael Pasternak has submitted this change and it was merged. Change subject: cli: "exit" command fails after "disconnect" from script #971285 ...................................................................... cli: "exit" command fails after "disconnect" from script #971285 Change-Id: Ie4a3807e9016d7a6007d938c0ca9aad50f9c50d9 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=971285 Signed-off-by: Michael pasternak <mpastern(a)redhat.com> --- M src/ovirtcli/shell/engineshell.py 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15481 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie4a3807e9016d7a6007d938c0ca9aad50f9c50d9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: cli_3.2 Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine-cli[master]: cli: "exit" command fails after "disconnect" from script #97...
by mpastern＠redhat.com 09 Jun '13

09 Jun '13

Michael Pasternak has submitted this change and it was merged. Change subject: cli: "exit" command fails after "disconnect" from script #971285 ...................................................................... cli: "exit" command fails after "disconnect" from script #971285 Change-Id: Ie6579879fa45e97e2d13f2e32202ab5f17665b24 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=971285 Signed-off-by: Michael pasternak <mpastern(a)redhat.com> --- M src/ovirtcli/shell/engineshell.py 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15475 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie6579879fa45e97e2d13f2e32202ab5f17665b24 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi : memory_policy-guaranteed option doesn't exists in ...
by mpastern＠redhat.com 09 Jun '13

09 Jun '13

Michael Pasternak has submitted this change and it was merged. Change subject: restapi : memory_policy-guaranteed option doesn't exists in 'add vm' autocompletion ...................................................................... restapi : memory_policy-guaranteed option doesn't exists in 'add vm' autocompletion >From cli --memory_policy-guaranteed option doesn't exists in 'add vm' autocompletion options, when it passed it is working (should be added to autocompletion options) Change-Id: I1e201343a782e0fb947ce3055a304db03950d6dd Bug-Url: https://bugzilla.redhat.com/962447 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14718 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1e201343a782e0fb947ce3055a304db03950d6dd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: RSDL Missing 'fence_type' param - #969797
by mpastern＠redhat.com 09 Jun '13

09 Jun '13

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: RSDL Missing 'fence_type' param - #969797 ...................................................................... restapi: RSDL Missing 'fence_type' param - #969797 For .../api/hosts/xxx/fence - fence_type is a mandatory parameter. Added this information to rsdl_metadata.yaml file. Bug-Url: http://bugzilla.redhat.com/969797 Change-Id: I2ee34a0698e9c6df9ae07b2c0665bacac86da845 Signed-off-by: Ori Liel <oliel(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15289 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2ee34a0698e9c6df9ae07b2c0665bacac86da845 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine[engine_3.2]: restapi: RSDL rename power_management.user_name-->username (...
by mpastern＠redhat.com 09 Jun '13

09 Jun '13

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: RSDL rename power_management.user_name-->username (#969097) ...................................................................... restapi: RSDL rename power_management.user_name-->username (#969097) Bug-Url: http://bugzilla.redhat.com/969097 Change-Id: Ibba24543d971b4950f0adc8712f33c7f30be7e89 Signed-off-by: Ori Liel <oliel(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15304 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibba24543d971b4950f0adc8712f33c7f30be7e89 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.2 Gerrit-Owner: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: RSDL rename power_management.user_name-->username (...
by mpastern＠redhat.com 09 Jun '13

09 Jun '13

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: RSDL rename power_management.user_name-->username (#969097) ...................................................................... restapi: RSDL rename power_management.user_name-->username (#969097) Bug-Url: http://bugzilla.redhat.com/969097 Change-Id: I4609f3a508a12fa1e833adbd03c005310211d95d Signed-off-by: Ori Liel <oliel(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15299 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4609f3a508a12fa1e833adbd03c005310211d95d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine[master]: findbugs: fix for inaccurate floating point comparison
by shavivi＠redhat.com 09 Jun '13

09 Jun '13

Shahar Havivi has submitted this change and it was merged. Change subject: findbugs: fix for inaccurate floating point comparison ...................................................................... findbugs: fix for inaccurate floating point comparison in commit 50680f0eb434080ad147dd2b479ced02375e50dc added a fix for floating point equality with a bug, comparing Double to long. This commit fix it to compare Double to Double. Change-Id: Icf3081c6d7d495dbfbd47a2092fe0e9a67be4299 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaManager.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Shahar Havivi: Verified ofri masad: Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15474 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icf3081c6d7d495dbfbd47a2092fe0e9a67be4299 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Make GUID encoders singletons
by rgolan＠redhat.com 07 Jun '13

07 Jun '13

Roy Golan has submitted this change and it was merged. Change subject: core: Make GUID encoders singletons ...................................................................... core: Make GUID encoders singletons The GUID encoders used in LDAP operations are stateless and can be reused, so we don't need to create a new instance each time we need them. This patch makes them singletons. Change-Id: If8683e90ac3a2a6c0ed129686c9e06ccb47ad82d Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/ADLdapGuidEncoder.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/DefaultLdapGuidEncoder.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/IPALdapGuidEncoder.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/ITDSLdapGuidEncoder.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapQueryMetadataFactoryImpl.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/RHDSLdapGuidEncoder.java 6 files changed, 83 insertions(+), 68 deletions(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14263 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If8683e90ac3a2a6c0ed129686c9e06ccb47ad82d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Multiple gateways test failure fixed
by lhornyak＠redhat.com 07 Jun '13

07 Jun '13

Laszlo Hornyak has submitted this change and it was merged. Change subject: engine: Multiple gateways test failure fixed ...................................................................... engine: Multiple gateways test failure fixed Fixed failing junit tests 1) at org.junit.Assert.assertFalse(Assert.java:79) at org.ovirt.engine.core.bll.SetupNetworksParametersTest.validateParameters(SetupNetworksParametersTest.java:37) 2) NPE in gatewayChanged(org.ovirt.engine.core.bll.network.host.SetupNetworksHelperTest) Change-Id: Ie0f697a198b064dabc603f3ec438d5ea670b474e Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/SetupNetworksParametersTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelperTest.java 2 files changed, 5 insertions(+), 2 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15434 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie0f697a198b064dabc603f3ec438d5ea670b474e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>

1 0