- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: add memory snapshots capability to VdsBroker
by ofrenkel＠redhat.com 09 Jun '13

09 Jun '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: add memory snapshots capability to VdsBroker ...................................................................... core: add memory snapshots capability to VdsBroker This patch adds the capability of taking a snapshot with memory state to VdsBroker project: 1. add new call in the interface against VDSM that also pass an image which will contain the memory state when calling to snapshot verb 2. a memory image parameter was added to SnapshotVDSCommandParameters that indicates where to dump the memory to 3. SnapshotVDSCommand was changed such that if the parameters contain memory image, then it invokes the new call added to the interfact against VDSM Change-Id: Id928c76562d520acbf36ca01e074e51cbdcccaf9 Bug-Url: https://bugzilla.redhat.com/960931 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/SnapshotVDSCommandParameters.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SnapshotVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java 5 files changed, 44 insertions(+), 6 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14201 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id928c76562d520acbf36ca01e074e51cbdcccaf9 Gerrit-PatchSet: 17 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: add memory volume to snapshot entity
by ofrenkel＠redhat.com 09 Jun '13

09 Jun '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: add memory volume to snapshot entity ...................................................................... core: add memory volume to snapshot entity This patch adds attribute of memory volume to snapshot. Change-Id: Iecda4c491fe6e207386edf2a9bf2488ec81a332a Bug-Url: https://bugzilla.redhat.com/960931 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/dbscripts/snapshots_sp.sql A backend/manager/dbscripts/upgrade/03_03_0190_add_memory_volume_to_snapshots.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/SnapshotsManager.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Snapshot.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/SnapshotDaoDbFacadeImpl.java M backend/manager/modules/dal/src/test/resources/fixtures.xml 6 files changed, 53 insertions(+), 7 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14053 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iecda4c491fe6e207386edf2a9bf2488ec81a332a Gerrit-PatchSet: 20 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: findbugs: ignore: Unread public-protected fields
by shavivi＠redhat.com 09 Jun '13

09 Jun '13

Shahar Havivi has submitted this change and it was merged. Change subject: findbugs: ignore: Unread public-protected fields ...................................................................... findbugs: ignore: Unread public-protected fields We add to ignore list fields that we do use in reflection or GWT and findbugs fail to recognize. findbugs reason: UrF: Unread public/protected field (URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD) Change-Id: I7e0a285d71bbed1a9201c6a919cb57e7a8c16406 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M backend/manager/modules/compat/exclude-filters.xml A exclude-filters.xml M frontend/webadmin/modules/gwt-common/exclude-filters.xml 3 files changed, 53 insertions(+), 0 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15392 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7e0a285d71bbed1a9201c6a919cb57e7a8c16406 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0

Change in ovirt-engine[master]: findbugs: remove unread public or protected fields
by shavivi＠redhat.com 09 Jun '13

09 Jun '13

Shahar Havivi has submitted this change and it was merged. Change subject: findbugs: remove unread public or protected fields ...................................................................... findbugs: remove unread public or protected fields findbugs reason: UrF: Unread public/protected field (URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD) Change-Id: Ib320ef93c723bdee810fd27ebfd306c890b1d11e Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveSnapshotTaskHandler.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendSnapshotElementsResource.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsStatsAndStatusXmlRpc.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/tree/AbstractSubTabActionTree.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/AddDataCenterRM.java 6 files changed, 0 insertions(+), 15 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15391 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib320ef93c723bdee810fd27ebfd306c890b1d11e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: add memory snapshot feature support
by ofrenkel＠redhat.com 09 Jun '13

09 Jun '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: add memory snapshot feature support ...................................................................... core: add memory snapshot feature support Support snapshots with memory state as from version 3.3. Feature page: http://www.ovirt.org/Features/RAM_Snapshots Change-Id: I69484598af0205d043b6f0438182a20adfeffff8 Bug-Url: https://bugzilla.redhat.com/960931 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/FeatureSupported.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java 3 files changed, 17 insertions(+), 0 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14167 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I69484598af0205d043b6f0438182a20adfeffff8 Gerrit-PatchSet: 19 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: findbugs: remove unread fields
by shavivi＠redhat.com 09 Jun '13

09 Jun '13

Shahar Havivi has submitted this change and it was merged. Change subject: findbugs: remove unread fields ...................................................................... findbugs: remove unread fields findbugs reason: UrF: Unread field (URF_UNREAD_FIELD) Change-Id: Ied4990cd90e58e566679851b3e2c5dcde05629cd Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendActionResource.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ReapedMap.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/IscsiStorageView.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmGeneralModelForm.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterGuideModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostHardwareGeneralModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateInterfaceListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmGuideModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInterfaceListModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/storage/TemplatesTree.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/template/StoragesTree.java 11 files changed, 2 insertions(+), 44 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15390 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ied4990cd90e58e566679851b3e2c5dcde05629cd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>

1 0

Change in ovirt-engine[master]: findbugs: ignore Unwritten public fields
by shavivi＠redhat.com 09 Jun '13

09 Jun '13

Shahar Havivi has submitted this change and it was merged. Change subject: findbugs: ignore Unwritten public fields ...................................................................... findbugs: ignore Unwritten public fields This classes are GWT classes and will generated code that will write to this fields findbugs reason: UwF: Unwritten public or protected field (UWF_UNWRITTEN_PUBLIC_OR_PROTECTED_FIELD) Change-Id: I0453d3d7e4404727afe4d356f49547969cef951b Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- A frontend/webadmin/modules/uicompat/exclude-filters.xml M frontend/webadmin/modules/uicompat/pom.xml 2 files changed, 40 insertions(+), 0 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15403 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0453d3d7e4404727afe4d356f49547969cef951b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0

Change in ovirt-engine[master]: findbugs: ignore: Log interface should not be the same as th...
by shavivi＠redhat.com 09 Jun '13

09 Jun '13

Shahar Havivi has submitted this change and it was merged. Change subject: findbugs: ignore: Log interface should not be the same as the implemented class name ...................................................................... findbugs: ignore: Log interface should not be the same as the implemented class name findbugs warns about using namespace interface 'Log' is the same name as the implemented interface name 'Log'. The class is deeply embedded in the code so we are ignoring findbugs warning for now Nm: Class names shouldn't shadow simple name of implemented interface (NM_SAME_SIMPLE_NAME_AS_INTERFACE) Change-Id: Icef5b803ad9aacaf5f6150f3e0744ccc22ec7936 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M backend/manager/modules/utils/exclude-filters.xml 1 file changed, 14 insertions(+), 0 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icef5b803ad9aacaf5f6150f3e0744ccc22ec7936 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: rename methods to start with lowercase
by amureini＠redhat.com 09 Jun '13

09 Jun '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: rename methods to start with lowercase ...................................................................... core: rename methods to start with lowercase Rename several methods to start with lowercase -java standard. Change-Id: I13d9f2ee1d107abaa78519f1714998f09317cab1 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddEmptyStoragePoolCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/FenceVdsManualyCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBaseTest.java 5 files changed, 9 insertions(+), 9 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15327 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I13d9f2ee1d107abaa78519f1714998f09317cab1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Some network cleanups
by masayag＠redhat.com 09 Jun '13

09 Jun '13

Moti Asayag has submitted this change and it was merged. Change subject: engine: Some network cleanups ...................................................................... engine: Some network cleanups Some cleanup for networks related code. Change-Id: I546f6081f285a758ea810de2b080bc2cb8c0d9a3 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/VmInterfaceManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/AddBondCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/AttachNetworkToVdsInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/DetachNetworkFromVdsInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/AddVmInterfaceCommand.java M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/MTUValidatorTest.java 6 files changed, 11 insertions(+), 22 deletions(-) Approvals: Mike Kolesnik: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/15448 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I546f6081f285a758ea810de2b080bc2cb8c0d9a3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0