- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: findbugs: remove duplicate ignore from filter
by shavivi＠redhat.com 16 May '13

16 May '13

Shahar Havivi has submitted this change and it was merged. Change subject: findbugs: remove duplicate ignore from filter ...................................................................... findbugs: remove duplicate ignore from filter Change-Id: I2e9563d758f89ffb02b041005f57922f0f614bad Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M backend/manager/modules/bll/exclude-filters.xml 1 file changed, 0 insertions(+), 6 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14771 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2e9563d758f89ffb02b041005f57922f0f614bad Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0

Change in ovirt-engine[master]: findbugs: adding comments to exclude filter xml files
by shavivi＠redhat.com 16 May '13

16 May '13

Shahar Havivi has submitted this change and it was merged. Change subject: findbugs: adding comments to exclude filter xml files ...................................................................... findbugs: adding comments to exclude filter xml files Change-Id: Ica8fcbcbf012b57c2c3289970129c08c4a235d0f Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M backend/manager/modules/bll/exclude-filters.xml M backend/manager/modules/utils/exclude-filters.xml M backend/manager/tools/exclude-filters.xml M frontend/webadmin/modules/webadmin/exclude-filters.xml 4 files changed, 43 insertions(+), 0 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14770 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ica8fcbcbf012b57c2c3289970129c08c4a235d0f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Move animal-sniffer to pluginManagement
by amureini＠redhat.com 16 May '13

16 May '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Move animal-sniffer to pluginManagement ...................................................................... core: Move animal-sniffer to pluginManagement Moved animal-sniffer definition from <plugins> to <pluginManagement> so maven does not download the plugin if the animal-sniffer goal is not invoked. Change-Id: I6748886415f8be2ae970b962ec67473dec1729b1 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M pom.xml 1 file changed, 16 insertions(+), 19 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14610 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6748886415f8be2ae970b962ec67473dec1729b1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: tools: manage-domains: have it respect runtime and buildtime...
by yzaslavs＠redhat.com 16 May '13

16 May '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: tools: manage-domains: have it respect runtime and buildtime configuration ...................................................................... tools: manage-domains: have it respect runtime and buildtime configuration Change-Id: I21c5ecb6ceffa9cf0f6292bd5c63dedc3bcf94a3 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M .gitignore M Makefile M backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomains.java D packaging/etc/engine-manage-domains/engine-manage-domains.conf A packaging/etc/engine-manage-domains/engine-manage-domains.conf.in 5 files changed, 9 insertions(+), 7 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14766 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I21c5ecb6ceffa9cf0f6292bd5c63dedc3bcf94a3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-log-collector[master]: db: drop the obfuscation of database password
by sbonazzo＠redhat.com 16 May '13

16 May '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: db: drop the obfuscation of database password ...................................................................... db: drop the obfuscation of database password Added support for the new configuration structure for database related parameters. If the new configuration structure can't be found fallback to legacy pg_pass file. Don't ask the DB password if already read from configuration files. Change-Id: I763f5a9d1d3307ee384281b13db5c6c9436060df Bug-Url: https://bugzilla.redhat.com/958532 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M build/subst.inc M src/Makefile.am M src/__main__.py M src/config.py.in.in A src/util.py 5 files changed, 152 insertions(+), 15 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Sandro Bonazzola: Verified; Looks good to me, approved Kiril Nesenko: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/14741 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I763f5a9d1d3307ee384281b13db5c6c9436060df Gerrit-PatchSet: 4 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal: Console buttons clickable area fix
by tjelinek＠redhat.com 16 May '13

16 May '13

Tomas Jelinek has submitted this change and it was merged. Change subject: userportal: Console buttons clickable area fix ...................................................................... userportal: Console buttons clickable area fix [extended userportal] Console buttons of VMs are clickable on wider area as expected (table cell where the button is present). This patch fixes this incorrect behavior. Now the buttons respond when clicking on their area only. Change-Id: Ib8a0da49e86bc01c73e7a2a7226da773d659a6fc Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=953140 Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> --- M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/extended/vm/ConsoleButtonCell.java 1 file changed, 38 insertions(+), 22 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Vojtech Szocs: Verified; Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/14535 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib8a0da49e86bc01c73e7a2a7226da773d659a6fc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-guest-agent[master]: agent: Use the locale module to get the preferred encoding
by bazulay＠redhat.com 15 May '13

15 May '13

Barak Azulay has submitted this change and it was merged. Change subject: agent: Use the locale module to get the preferred encoding ...................................................................... agent: Use the locale module to get the preferred encoding The guest agent used for the string sanitization sys.stdout.encoding which is set to None when you're running without an allocated console. This is the case on Windows as a service. The locale module provides the function getpreferredencoding() which returns the required value. Resolves: BZ#962667 Change-Id: I9ff6e3c7165599f80d13115e0173eefe0e79e664 Bug-Url: https://bugzilla.redhat.com/962667 Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> --- M ovirt-guest-agent/VirtIoChannel.py 1 file changed, 2 insertions(+), 3 deletions(-) Approvals: Giuseppe Vallarelli: Looks good to me, but someone else must approve Vinzenz Feenstra: Verified; Looks good to me, but someone else must approve Barak Azulay: Looks good to me, approved Michal Skrivanek: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/14739 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9ff6e3c7165599f80d13115e0173eefe0e79e664 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Giuseppe Vallarelli <gvallare(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Element IDs in System Tree and Tags
by vszocs＠redhat.com 15 May '13

15 May '13

Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin: Element IDs in System Tree and Tags ...................................................................... webadmin: Element IDs in System Tree and Tags 1. Added TreeNodeInfo interface which acts as adapter for providing tree node information, all models and model-like classes used in CellTree widgets implement this interface. 2. Updated ElementIdUtils.createTreeCellElementId() to support IDs in case of single root node, methods which calculate node index now use equals() instead of comparing references. 3. Fixed SystemTreeItemModel hierarchy mismatch in SystemTreeModel (different child nodes now correctly refer to their parents). 4. Added {get|set}Parent() methods in TagModel due to TreeNodeInfo interface, updated TagListModel to reflect parent relationship. 5. Fixed CellTree.Resources being GWT.create()'d for each instance. 6. Fixed CellTree cells being created each time when TreeViewModel getNodeInfo() is called, the core principle of cell widgets is to use single (flyweight, reusable, stateless) cell to do the rendering. 7. Methods to deal with CellTree moved away from TagModelProvider directly into TagList (widget managing the CellTree) class. Example System Tree (node) element ID: SystemTree_display_root0_node1_node0 --> label (root0 = System, node1 = 2nd DataCenter, node0 = 1st Storage) Example Tag (node) element ID: TagList_display_label_root0_node0 --> label TagList_display_pinButton_root0_node0 --> pin tag button (root0 = Root, node0 = 1st Tag) Change-Id: Ie4341a4c4e1740c075987e2a57c0844fa72b971e Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/idhandler/HasElementId.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/idhandler/ProvidesElementId.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/model/TreeNodeModel.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/ElementIdUtils.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/action/AbstractActionPanel.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/action/AbstractActionStackPanelItem.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/ElementIdCellTable.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/tree/ElementIdCellTree.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/TreeNodeInfo.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SystemTreeItemModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SystemTreeModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/tags/TagListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/tags/TagModel.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/tab/basic/MainTabBasicListPresenterWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationTemplates.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/AssignTagsPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/configure/RolePopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/user/ManageEventsPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/uicommon/model/ModelListTreeViewModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/uicommon/model/SimpleSelectionTreeNodeModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/uicommon/model/SystemTreeModelProvider.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/uicommon/model/TagModelProvider.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/bookmark/BookmarkList.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/tags/TagItemCell.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/tags/TagList.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/tree/SystemTree.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/tree/SystemTreeItemCell.java 27 files changed, 390 insertions(+), 282 deletions(-) Approvals: Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14165 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie4341a4c4e1740c075987e2a57c0844fa72b971e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Element IDs in Assign Tags and Role dialogs
by vszocs＠redhat.com 15 May '13

15 May '13

Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin: Element IDs in Assign Tags and Role dialogs ...................................................................... webadmin: Element IDs in Assign Tags and Role dialogs 1. Assign Tags dialog (Users main tab) now supports element IDs for Tree nodes 2. Role dialog (Configure dialog | Roles tab) now supports element IDs for Tree nodes and some other UI elements: - Name and Description text box - User and Admin radio button - Expand and Collapse button Change-Id: Ic37627d382d529fe7f8c11a55e6799a6d8617a6a Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/AssignTagsPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/configure/RolePopupView.java 2 files changed, 30 insertions(+), 22 deletions(-) Approvals: Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14055 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic37627d382d529fe7f8c11a55e6799a6d8617a6a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin, userportal: Improve form-based sub tabs
by vszocs＠redhat.com 15 May '13

15 May '13

Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin,userportal: Improve form-based sub tabs ...................................................................... webadmin,userportal: Improve form-based sub tabs This patch improves existing form-based sub tab implementation: 1. FormBuilder/AbstractFormPanel no longer clears and re-attaches form item widgets (name/value) to detail views on each update. Instead, it merely updates existing form items. 2. CSS styles improved so that AbstractFormPanel.setColumnsWidth() is now redundant. HorizontalPanel that wraps all detail views ensures that all columns are equally wide, allowing consistent look & feel for all form-based sub tabs. 3. FormBuilder.showForm() renamed to update() since it now just updates all form items. It also makes sure that the property change listener is removed from the old model. 4. In FormItem, instead of overriding UIObject.isVisible(), we use getIsAvailable() method for controlling form item availability (visibility) within the detail view. 5. Updated related classes due to FormItem/FormBuilder API change. Change-Id: I8b2f2577b1b488d5514dc05c2590a2bb53fcfe4f Bug-Url: https://bugzilla.redhat.com/915904 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/AbstractFormPanel.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/FormBuilder.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/FormItem.java D frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/FormItemWithDefaultValue.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/GeneralFormPanel.ui.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/AbstractModelBoundFormWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/template/TemplateGeneralModelForm.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/PoolGeneralModelForm.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmGeneralModelForm.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmSessionsModelForm.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmSnapshotInfoGeneral.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/ClusterGeneralModelForm.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/disk/SubTabDiskGeneralView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/gluster/SubTabVolumeGeneralView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostGeneralView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostHardwareView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/network/SubTabNetworkGeneralView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/pool/SubTabPoolGeneralView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/storage/SubTabStorageGeneralView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/user/SubTabUserGeneralView.java 20 files changed, 335 insertions(+), 443 deletions(-) Approvals: Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12325 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8b2f2577b1b488d5514dc05c2590a2bb53fcfe4f Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0