- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Fix testGetRootDSENoServers
by amureini＠redhat.com 14 May '13

14 May '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Fix testGetRootDSENoServers ...................................................................... core: Fix testGetRootDSENoServers Since urls is a zero length list, urls.get(0) throws an IndexOutOfBoundsException. This exception is caught, and thus the test passes, but it's kind of meaningless - it does not execute any of the DirectorySearcher's code, and essentially tests Java's ArrayList.get(int) implementation. I guess it's safe to assume that it works correctly. Change-Id: I295d9b10495efabf892107187de7ccd91334062f Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/adbroker/DirectorySearcherTest.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14418 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I295d9b10495efabf892107187de7ccd91334062f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Reduce timeout in DiretorySearcherTest
by amureini＠redhat.com 14 May '13

14 May '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Reduce timeout in DiretorySearcherTest ...................................................................... core: Reduce timeout in DiretorySearcherTest Reduced timeout to 1 millisecond instead of 1 second. The timeout here is meaningless since all the test are done against mock servers anyway, and reducing the timeout allows the test to pass in in environments where network connectivity is disabled. Change-Id: I2cd5b543963a3c6c16b8cfe2a40e5433c5ac3422 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/adbroker/DirectorySearcherTest.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14416 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2cd5b543963a3c6c16b8cfe2a40e5433c5ac3422 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove DirectorySearcherTest's @BeforeClass
by amureini＠redhat.com 14 May '13

14 May '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove DirectorySearcherTest's @BeforeClass ...................................................................... core: Remove DirectorySearcherTest's @BeforeClass This is a POJO test, there is no need to interact with JBoss' logging folder. Change-Id: I1b9c4df4b79dd061d941aa8d38715572fa0482b8 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/adbroker/DirectorySearcherTest.java 1 file changed, 0 insertions(+), 6 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14417 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1b9c4df4b79dd061d941aa8d38715572fa0482b8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: DirectorySearcherTest proper failures
by amureini＠redhat.com 14 May '13

14 May '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: DirectorySearcherTest proper failures ...................................................................... core: DirectorySearcherTest proper failures Used the proper JUnit 4 syntax for failures - @Test with the expected parameter, instead of the ugly hack of catching an exception and returning before the test reaches a fail() statement. Change-Id: Icdc729f0aa78674f45ce11aab844cbf9751a6ac6 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/adbroker/DirectorySearcherTest.java 1 file changed, 9 insertions(+), 31 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14419 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icdc729f0aa78674f45ce11aab844cbf9751a6ac6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Removed unused Roles queries
by amureini＠redhat.com 14 May '13

14 May '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Removed unused Roles queries ...................................................................... core: Removed unused Roles queries This patch removes several queries for Roles which are not used anymore. This patch includes: 1. Removing GetRolesByAdElementIdQuery, GerRolesByAdElementIdAndNullTagQuery and GetRolesForDelegationByUserQuery. 2. Removing the VdcQueryType constants corresponding to the aforementioned queries. 3. Removing the GetRolesByAdElement constant from VdcQueryType, as it has no corresponding query class. 4. Removing RoleDAO.getAllForAdElement(Guid) and RoleDAO.getForAdElement(Guid) which were only used by the aforementioned queries. This removal includes the interfaces, implementations, underlying stored procedures and tests. Change-Id: If424d0936dc9c7dc89400c7b492febde1d2bf075 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/dbscripts/multi_level_administration_sp.sql D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetRolesByAdElementIdAndNullTagQuery.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetRolesByAdElementIdQuery.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetRolesForDelegationByUserQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/RoleDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/RoleDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/RoleDAOTest.java 8 files changed, 0 insertions(+), 197 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13442 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If424d0936dc9c7dc89400c7b492febde1d2bf075 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: custom properties: allow '=' in regex
by gchaplik＠redhat.com 13 May '13

13 May '13

Gilad Chaplik has submitted this change and it was merged. Change subject: engine: custom properties: allow '=' in regex ...................................................................... engine: custom properties: allow '=' in regex In custom properties sheet when regex contains '=', we cannot parse the string using split('=') (the parsing is invalid). To solve that added a hard limit of 2 for the string split. Bug-Url: https://bugzilla.redhat.com/956467 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> Change-Id: Ic845e2ab5a0f23d48c1506f4f834a851009ea253 --- M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/vmproperties/VmPropertiesUtils.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/entity/helper/CustomPropertiesValueHelper.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/key_value/KeyValueModel.java 4 files changed, 5 insertions(+), 5 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14182 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic845e2ab5a0f23d48c1506f4f834a851009ea253 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: findbugs: ignore: Method might ignore exception
by shavivi＠redhat.com 13 May '13

13 May '13

Shahar Havivi has submitted this change and it was merged. Change subject: findbugs: ignore: Method might ignore exception ...................................................................... findbugs: ignore: Method might ignore exception Change-Id: Id1b56c036f2899d8ac53b7dd8e863e16e63429ae Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M backend/manager/modules/utils/exclude-filters.xml M backend/manager/modules/utils/pom.xml A backend/manager/tools/exclude-filters.xml M backend/manager/tools/pom.xml 4 files changed, 36 insertions(+), 11 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14713 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id1b56c036f2899d8ac53b7dd8e863e16e63429ae Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: Validating DB encoding during setup
by juan.hernandez＠redhat.com 13 May '13

13 May '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: Validating DB encoding during setup ...................................................................... packaging: Validating DB encoding during setup This patch adds a DB encoding validation during setup on remote DBs. There's no need to validate the default encoding on local installation because on local installation we perform initdb, which creates template1 (and, as result other DBs created within) with a default desired encoding utf8. Change-Id: I583b115cf60142cafc5ba66b0dc22e92b4807c84 Bug-Url: https://bugzilla.redhat.com/920565 Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M packaging/fedora/setup/common_utils.py M packaging/fedora/setup/engine_validators.py M packaging/fedora/setup/output_messages.py M packaging/setup/plugins/ovirt-engine-setup/db/connection.py 4 files changed, 76 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14615 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I583b115cf60142cafc5ba66b0dc22e92b4807c84 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal: added space between protocol and edit button
by tjelinek＠redhat.com 13 May '13

13 May '13

Tomas Jelinek has submitted this change and it was merged. Change subject: userportal: added space between protocol and edit button ...................................................................... userportal: added space between protocol and edit button Details of the basic view, there was no space between the protocol type and the edit button. Added 5px. Change-Id: I81832b613edd85af8605aea74c71cf8f2ccb1729 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/basic/MainTabBasicDetailsView.ui.xml 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14711 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I81832b613edd85af8605aea74c71cf8f2ccb1729 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: gluster: Use Set instead of List for serviceNames
by sanjal＠redhat.com 13 May '13

13 May '13

Shireesh Anjal has submitted this change and it was merged. Change subject: gluster: Use Set instead of List for serviceNames ...................................................................... gluster: Use Set instead of List for serviceNames Use Set instead of List for serviceNames in GlusterServicesListVDSParameters Change-Id: I26109a71448968fea0055c3d2df3c843e23d70f3 Signed-off-by: Shireesh Anjal <anjalshireesh(a)gmail.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterServicesListVDSParameters.java 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Shireesh Anjal: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14642 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I26109a71448968fea0055c3d2df3c843e23d70f3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com>

1 0