- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: findbugs: Unwritten field
by shavivi＠redhat.com 13 May '13

13 May '13

Shahar Havivi has submitted this change and it was merged. Change subject: findbugs: Unwritten field ...................................................................... findbugs: Unwritten field Change-Id: I4095a8157c06070cb3fdc40d0f6749faf1e7b737 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/model/CommonModelManager.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14705 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4095a8157c06070cb3fdc40d0f6749faf1e7b737 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0

Change in ovirt-engine[master]: findbugs: ignore: Possible double check of field
by shavivi＠redhat.com 13 May '13

13 May '13

Shahar Havivi has submitted this change and it was merged. Change subject: findbugs: ignore: Possible double check of field ...................................................................... findbugs: ignore: Possible double check of field Change-Id: I7e9956f27af23191ce6e5e6869d8120af9e12b91 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M backend/manager/modules/bll/exclude-filters.xml M backend/manager/modules/bll/pom.xml A backend/manager/modules/utils/exclude-filters.xml M backend/manager/modules/utils/pom.xml 4 files changed, 25 insertions(+), 2 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14704 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7e9956f27af23191ce6e5e6869d8120af9e12b91 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0

Change in ovirt-engine[master]: usertportal: Console buttons are still active after VM is la...
by tjelinek＠redhat.com 13 May '13

13 May '13

Tomas Jelinek has submitted this change and it was merged. Change subject: usertportal: Console buttons are still active after VM is launched. ...................................................................... usertportal: Console buttons are still active after VM is launched. After spice console connecting/disconnecting in extended usertportar view, the ui state of the console buttons was not updated. This behavior is reproducible since patch 09f1acafa2a508f90ea9a7a77f79693d8e8224d6 in upstream. The problem was in not comparing console state in the logic that was responsible for deciding whether to refresh the view. Fixed by adding check for console state change (console username). Change-Id: I6b260c338dbc2f1156f00732842caf59d7fd1bb2 Bug-Url: https://bugzilla.redhat.com/951666 Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalItemModel.java 1 file changed, 7 insertions(+), 2 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Frank Kobzik: Verified -- To view, visit http://gerrit.ovirt.org/14641 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6b260c338dbc2f1156f00732842caf59d7fd1bb2 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: findbugs: ignore: Call to static DateFormat
by shavivi＠redhat.com 13 May '13

13 May '13

Shahar Havivi has submitted this change and it was merged. Change subject: findbugs: ignore: Call to static DateFormat ...................................................................... findbugs: ignore: Call to static DateFormat Change-Id: Ia5b73279230455d7b4ddeb57f97e36cf420abe38 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- A backend/manager/modules/dal/exclude-filters.xml M backend/manager/modules/dal/pom.xml 2 files changed, 30 insertions(+), 0 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14686 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia5b73279230455d7b4ddeb57f97e36cf420abe38 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: findbugs: ignore: Possible null pointer dereference
by shavivi＠redhat.com 13 May '13

13 May '13

Shahar Havivi has submitted this change and it was merged. Change subject: findbugs: ignore: Possible null pointer dereference ...................................................................... findbugs: ignore: Possible null pointer dereference Change-Id: I310aed3ed02ff3683506b07f1a2155e9830f7893 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M backend/manager/modules/bll/exclude-filters.xml 1 file changed, 12 insertions(+), 0 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14684 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I310aed3ed02ff3683506b07f1a2155e9830f7893 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: findbugs: ignore: Boolean return value should not return nul...
by shavivi＠redhat.com 13 May '13

13 May '13

Shahar Havivi has submitted this change and it was merged. Change subject: findbugs: ignore: Boolean return value should not return null ...................................................................... findbugs: ignore: Boolean return value should not return null Change-Id: I90f16b1b5941aadcb2c7488500ce63eb2bf57436 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- A frontend/webadmin/modules/webadmin/exclude-filters.xml M frontend/webadmin/modules/webadmin/pom.xml 2 files changed, 41 insertions(+), 0 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14682 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I90f16b1b5941aadcb2c7488500ce63eb2bf57436 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: findbugs error
by masayag＠redhat.com 13 May '13

13 May '13

Moti Asayag has submitted this change and it was merged. Change subject: restapi: findbugs error ...................................................................... restapi: findbugs error Fixing a findbug error although the warned NPE by findbugs shouldn't occur (there is no code path which will end in NPE), it is easier to pass its warning by using the 'else' statement. Change-Id: I8b6749df88b78c3cdb6ef187bebc86de912856b7 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendClusterNetworksResource.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14691 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8b6749df88b78c3cdb6ef187bebc86de912856b7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: solve conflict with versionlocked 3.2 packages
by oschreib＠redhat.com 13 May '13

13 May '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: solve conflict with versionlocked 3.2 packages ...................................................................... packaging: solve conflict with versionlocked 3.2 packages setup is not version locked, so the move of these files to setup created a conflict in setup installation as the ovirt-engine package could not be updated at the same transaction. leave these files for now at base package. Change-Id: I82187ed1d661fa8bb1613ef336cb837deac80a9a Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ovirt-engine.spec.in 1 file changed, 7 insertions(+), 2 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14678 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I82187ed1d661fa8bb1613ef336cb837deac80a9a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: build: update documentation
by oschreib＠redhat.com 13 May '13

13 May '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: build: update documentation ...................................................................... packaging: build: update documentation Change-Id: I868db82f8a8a5061e6912bf96dfd5d80d66a164f Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M README.developer 1 file changed, 30 insertions(+), 1 deletion(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14689 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I868db82f8a8a5061e6912bf96dfd5d80d66a164f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: build: allow to control build of gwt components
by oschreib＠redhat.com 13 May '13

13 May '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: build: allow to control build of gwt components ...................................................................... packaging: build: allow to control build of gwt components Add BUILD_GWT_* flags, update documentation. Change-Id: I147232f57e3d565b8264c45795d48d59d349e0ae Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M Makefile M README.developer 2 files changed, 42 insertions(+), 12 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14683 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I147232f57e3d565b8264c45795d48d59d349e0ae Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0