- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: Fixed upgrade script with duplicate number
by ofrenkel＠redhat.com 07 May '13

07 May '13

Omer Frenkel has submitted this change and it was merged. Change subject: engine: Fixed upgrade script with duplicate number ...................................................................... engine: Fixed upgrade script with duplicate number Change-Id: I563aa8c81b5ba1d609f72a83d592bf7655b98995 Signed-off-by: Shireesh Anjal <anjalshireesh(a)gmail.com> --- R backend/manager/dbscripts/upgrade/03_03_0130_add_gluster_services_tables.sql 1 file changed, 0 insertions(+), 0 deletions(-) Approvals: Shireesh Anjal: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14548 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I563aa8c81b5ba1d609f72a83d592bf7655b98995 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: gluster: Tables, SPs and DAOs for gluster services
by ofrenkel＠redhat.com 07 May '13

07 May '13

Omer Frenkel has submitted this change and it was merged. Change subject: gluster: Tables, SPs and DAOs for gluster services ...................................................................... gluster: Tables, SPs and DAOs for gluster services These tables will store information about gluster related services running on servers of gluster storage clusters. gluster_service_types : Type of the service e.g. gluster-swift gluster_services : Service type to services mapping (gluster-swift-proxy, gluster-swift-container, etc) gluster_cluster_services : Cluster to service types mapping gluster_server_services : Server to services mapping In this process, renamed the class ServiceInfo to GlusterServerService Change-Id: I1ded8d39203009bc66974e136c41b5de180ffbff Signed-off-by: Shireesh Anjal <sanjal(a)redhat.com> --- A backend/manager/dbscripts/gluster_services_sp.sql A backend/manager/dbscripts/upgrade/03_03_0120_add_gluster_services_tables.sql A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterClusterService.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterServerService.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterService.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterServiceStatus.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterVolumeAdvancedDetails.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/ServiceInfo.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/ServiceType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacade.java A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterClusterServiceDao.java A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterClusterServiceDaoDbFacadeImpl.java A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterServerServiceDao.java A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterServerServiceDaoDbFacadeImpl.java A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterServiceDao.java A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterServiceDaoDbFacadeImpl.java M backend/manager/modules/dal/src/main/jdbc-resources/engine-daos.properties A backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/gluster/GlusterClusterServiceDaoTest.java A backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/gluster/GlusterServerServiceDaoTest.java A backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/gluster/GlusterServiceDaoTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterServicesReturnForXmlRpc.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterVolumeStatusReturnForXmlRpc.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterServiceModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/SubTabClusterServiceView.java 26 files changed, 1,317 insertions(+), 156 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14344 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1ded8d39203009bc66974e136c41b5de180ffbff Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine-cli[cli_3.2]: cli: Add brick operation fails from ovirt-shell(#923169)
by mpastern＠redhat.com 07 May '13

07 May '13

Michael Pasternak has submitted this change and it was merged. Change subject: cli: Add brick operation fails from ovirt-shell(#923169) ...................................................................... cli: Add brick operation fails from ovirt-shell(#923169) Duplicate bricks are send when --brick-brick option is specified for add brick operation. Change-Id: Ia42557b26dbaacb0a00da461e07dae60fee4ae5e Bug-Url: https://bugzilla.redhat.com/923169 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M src/ovirtcli/command/command.py 1 file changed, 3 insertions(+), 4 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14544 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia42557b26dbaacb0a00da461e07dae60fee4ae5e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: cli_3.2 Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine-cli[master]: cli: Add brick operation fails from ovirt-shell(#923169)
by mpastern＠redhat.com 07 May '13

07 May '13

Michael Pasternak has submitted this change and it was merged. Change subject: cli: Add brick operation fails from ovirt-shell(#923169) ...................................................................... cli: Add brick operation fails from ovirt-shell(#923169) Duplicate bricks are send when --brick-brick option is specified for add brick operation. Change-Id: Ia42557b26dbaacb0a00da461e07dae60fee4ae5e Bug-Url: https://bugzilla.redhat.com/923169 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M src/ovirtcli/command/command.py 1 file changed, 3 insertions(+), 4 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13756 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia42557b26dbaacb0a00da461e07dae60fee4ae5e Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Cleaning up InitVdsOnUpCommand
by sanjal＠redhat.com 07 May '13

07 May '13

Shireesh Anjal has submitted this change and it was merged. Change subject: engine: Cleaning up InitVdsOnUpCommand ...................................................................... engine: Cleaning up InitVdsOnUpCommand Removed the '_' prefixes from the private fields. Change-Id: I4023d9eb66504ff2648b7567626fc962de08b53c Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java 1 file changed, 24 insertions(+), 24 deletions(-) Approvals: Shireesh Anjal: Looks good to me, approved Kanagaraj M: Verified -- To view, visit http://gerrit.ovirt.org/14492 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4023d9eb66504ff2648b7567626fc962de08b53c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine-cli[master]: cli: fail nicely on AttributeError #959740
by mpastern＠redhat.com 07 May '13

07 May '13

Michael Pasternak has submitted this change and it was merged. Change subject: cli: fail nicely on AttributeError #959740 ...................................................................... cli: fail nicely on AttributeError #959740 Change-Id: I534beb603be224a8103d5900ea6fb34b5315a18b Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=959740 Signed-off-by: Michael pasternak <mpastern(a)redhat.com> --- M src/cli/messages.py M src/ovirtcli/command/command.py 2 files changed, 5 insertions(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14539 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I534beb603be224a8103d5900ea6fb34b5315a18b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine-cli[cli_3.2]: cli: fail nicely on AttributeError #959740
by mpastern＠redhat.com 07 May '13

07 May '13

Michael Pasternak has submitted this change and it was merged. Change subject: cli: fail nicely on AttributeError #959740 ...................................................................... cli: fail nicely on AttributeError #959740 Change-Id: Ib08ea039a4ee44334ce797c00b183248871c3071 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=959740 Signed-off-by: Michael pasternak <mpastern(a)redhat.com> --- M src/cli/messages.py M src/ovirtcli/command/command.py 2 files changed, 5 insertions(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14540 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib08ea039a4ee44334ce797c00b183248871c3071 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: cli_3.2 Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: Updated Makefile to create dbutils folder
by juan.hernandez＠redhat.com 07 May '13

07 May '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: Updated Makefile to create dbutils folder ...................................................................... packaging: Updated Makefile to create dbutils folder This patch is an addition to the gerrit.ovirt.org/12512 which in some cases doesn't handle the creation of the dbutils folder correctly. Change-Id: I211910edec4bf99c8cfafba6fe8cfe9683d09b01 Bug-Url: https://bugzilla.redhat.com/893459 Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M Makefile 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14513 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I211910edec4bf99c8cfafba6fe8cfe9683d09b01 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: core:unlock_entity is not locating locked snapshot
by yzaslavs＠redhat.com 07 May '13

07 May '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: core:unlock_entity is not locating locked snapshot ...................................................................... core:unlock_entity is not locating locked snapshot fix caused a regression when handling disk , sql statement is prepared but not executed Change-Id: I4a991183517c580d651f6a0e7c92749b66a163b3 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=958370 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/dbscripts/dbfunctions.sh 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Eli Mesika: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14530 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4a991183517c580d651f6a0e7c92749b66a163b3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Fix enabling gluster hooks actions
by kmayilsa＠redhat.com 07 May '13

07 May '13

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin: Fix enabling gluster hooks actions ...................................................................... webadmin: Fix enabling gluster hooks actions 'Enable' action was getting enable even though the selected hook is already enabled. This is fixed now. Change-Id: Icf5984305986f00a663d35218a3ead86a849fac5 Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterGlusterHookListModel.java 1 file changed, 7 insertions(+), 0 deletions(-) Approvals: Kanagaraj M: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14515 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icf5984305986f00a663d35218a3ead86a849fac5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0