- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: fix disk image json serialization/deserialization
by amureini＠redhat.com 08 May '13

08 May '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: fix disk image json serialization/deserialization ...................................................................... core: fix disk image json serialization/deserialization Change-Id: Id40ef08ea341e6abf2bd5e6e815bb79814141c20 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DiskImage.java 1 file changed, 3 insertions(+), 4 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13659 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id40ef08ea341e6abf2bd5e6e815bb79814141c20 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>

1 0

Change in ovirt-engine[master]: pki: fix engine-upgrade config creation
by oschreib＠redhat.com 08 May '13

08 May '13

Ofer Schreiber has submitted this change and it was merged. Change subject: pki: fix engine-upgrade config creation ...................................................................... pki: fix engine-upgrade config creation Change-Id: I9af1bbb2be895f4d77d9a060454b72109bb5a382 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/fedora/setup/engine-upgrade.py 1 file changed, 12 insertions(+), 5 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14566 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9af1bbb2be895f4d77d9a060454b72109bb5a382 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: modify enigne.conf.d setup files prefix
by oschreib＠redhat.com 08 May '13

08 May '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: modify enigne.conf.d setup files prefix ...................................................................... packaging: modify enigne.conf.d setup files prefix previously we used '50-' prefix, however there is no reason for setup default to be loaded so late in change, so now it was modified to '10-' prefix. clean all configuration files when engine-clean is executed to avoid leftovers. Change-Id: I173faede1f39b87a14ede05c04e0ab4da7e8e5d3 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/fedora/setup/basedefs.py M packaging/fedora/setup/engine-cleanup.py M packaging/fedora/setup/engine-setup.py 3 files changed, 18 insertions(+), 6 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14562 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I173faede1f39b87a14ede05c04e0ab4da7e8e5d3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: findbugs: equals between different types
by oourfali＠redhat.com 08 May '13

08 May '13

Oved Ourfali has submitted this change and it was merged. Change subject: findbugs: equals between different types ...................................................................... findbugs: equals between different types Change-Id: I125e5df8def7a223f9469decc7aa43dab61f4a47 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/DiskStatisticalQueryTest.java 1 file changed, 9 insertions(+), 9 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14296 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I125e5df8def7a223f9469decc7aa43dab61f4a47 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: nothing was left in conf to ovirt-engine
by oschreib＠redhat.com 08 May '13

08 May '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: nothing was left in conf to ovirt-engine ...................................................................... packaging: nothing was left in conf to ovirt-engine move last file to backend. Change-Id: I5813d6846ff8e16d32c805a6ca35546449a42830 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ovirt-engine.spec.in 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14573 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5813d6846ff8e16d32c805a6ca35546449a42830 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[engine_3.2]: packaging: stricter FQDN validation
by oschreib＠redhat.com 08 May '13

08 May '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: stricter FQDN validation ...................................................................... packaging: stricter FQDN validation common_utils.getConfiguredIps now returns only Ips configured on non loopback devices. engine_validators.validateFQDN now tolerates that the FQDN provided could not be resolved through a DNS but just only by /etc/hosts. However, if the FQDN is resolved by DNS, it has also to reverse resolve the ip address provided by the DNS. engine-setup doesn't accept anymore a FQDN that doesn't pass the validation, avoiding failures at later stages. Change-Id: I512446c80dfa9c83adb179a445bfae82736d403f Bug-Url: https://bugzilla.redhat.com/948311 Bug-Url: https://bugzilla.redhat.com/928667 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M packaging/fedora/setup/common_utils.py M packaging/fedora/setup/engine-setup.py M packaging/fedora/setup/engine_validators.py M packaging/fedora/setup/output_messages.py 4 files changed, 86 insertions(+), 46 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Sandro Bonazzola: Verified Ofer Schreiber: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14529 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I512446c80dfa9c83adb179a445bfae82736d403f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.2 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[engine_3.2]: packaging: modified validation of fqdn input during setup
by oschreib＠redhat.com 08 May '13

08 May '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: modified validation of fqdn input during setup ...................................................................... packaging: modified validation of fqdn input during setup validateFQDN now explicitly states that an IP address is not supported instead of just saying "<ip address here> did not resolve to an ip address. User input failed validation..." Change-Id: I99d3727f0e2205f6cd90ff5c2a003fb6f0643eab Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=843623 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M packaging/fedora/setup/engine_validators.py M packaging/fedora/setup/output_messages.py 2 files changed, 8 insertions(+), 0 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Sandro Bonazzola: Verified Ofer Schreiber: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14528 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I99d3727f0e2205f6cd90ff5c2a003fb6f0643eab Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.2 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[engine_3.2]: packaging: fixing fqdn validation
by oschreib＠redhat.com 08 May '13

08 May '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: fixing fqdn validation ...................................................................... packaging: fixing fqdn validation if _getPatternFromNslookup returns an empty set, the validation will have caused a traceback. Change-Id: I4bf1385fbb1770c990c4b31c59d829ce91e4ed00 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M packaging/fedora/setup/engine_validators.py 1 file changed, 5 insertions(+), 3 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Sandro Bonazzola: Verified Ofer Schreiber: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14527 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4bf1385fbb1770c990c4b31c59d829ce91e4ed00 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.2 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[engine_3.2]: packaging: make validateFQDN case insensitive
by oschreib＠redhat.com 08 May '13

08 May '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: make validateFQDN case insensitive ...................................................................... packaging: make validateFQDN case insensitive If the specified FQDN to rhevm-setup is a different case to that returned by the DNS PTR record, then validateFQDN reports that the reverse-resolved name doesn't match the supplied name and fails the validation and hence rhevm-setup fails. This patch makes validateFQDN case insensitive so it doesn't matter if the supplied FQDN differs in case to that retured by the DNS PTR record, because DNS itself is case insensitive. Change-Id: I7619971956c1eba8b6d3f2a345b8fc85a778384e Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=928165 Signed-off-by: Mark Huth <mhuth(a)redhat.com> --- M packaging/fedora/setup/engine_validators.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Mark Huth: Verified; Looks good to me, but someone else must approve Alon Bar-Lev: Looks good to me, but someone else must approve Sandro Bonazzola: Verified Ofer Schreiber: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14526 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7619971956c1eba8b6d3f2a345b8fc85a778384e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.2 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Mark Huth <mhuth(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine-cli[cli_3.2]: cli: release 3.2.0.12-1
by mpastern＠redhat.com 08 May '13

08 May '13

Michael Pasternak has submitted this change and it was merged. Change subject: cli: release 3.2.0.12-1 ...................................................................... cli: release 3.2.0.12-1 Change-Id: Ie89303dbabf2346e274e9445c2d8e20d9bf01de6 Signed-off-by: Michael pasternak <mpastern(a)redhat.com> --- M Makefile M ovirt-engine-cli.spec.in M setup.py 3 files changed, 16 insertions(+), 2 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14578 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie89303dbabf2346e274e9445c2d8e20d9bf01de6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: cli_3.2 Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0