- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Disable unit test
by ecohen＠redhat.com 08 May '13

08 May '13

Einav Cohen has submitted this change and it was merged. Change subject: core: Disable unit test ...................................................................... core: Disable unit test - Disabled DocsServlet unit test as they are giving trouble during jenkins job. Change-Id: Iab18612d463cc5fe1270aca6a81bad60e6fa8595 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M backend/manager/modules/root/src/test/java/org/ovirt/engine/core/DocsServletTest.java 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Alexander Wels: Verified Einav Cohen: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14563 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iab18612d463cc5fe1270aca6a81bad60e6fa8595 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: fix rpm errors due to services separation
by oschreib＠redhat.com 07 May '13

07 May '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: fix rpm errors due to services separation ...................................................................... packaging: fix rpm errors due to services separation these errors were not show previously, even in CI... weired! Change-Id: I5d93aea07b4c65e235d47a17d4b106132479803d Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ovirt-engine.spec.in 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Alon Bar-Lev: Verified Ofer Schreiber: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14561 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5d93aea07b4c65e235d47a17d4b106132479803d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: ReplicateDisk - prevent rollback on engine restart
by derez＠redhat.com 07 May '13

07 May '13

Daniel Erez has submitted this change and it was merged. Change subject: core: ReplicateDisk - prevent rollback on engine restart ...................................................................... core: ReplicateDisk - prevent rollback on engine restart VmReplicateDiskFinishTaskHandler: Rollback should be prevented on VmReplicateDiskFinish success, but we can't rely on the command's returnValue since it's not persistent. Instead, to make sure rollback is prevented on restart, query the DB to verify that the disk indeed moved to the target storage domain. Change-Id: Ibd088940d6e3f7be79fb0381076499ea1c1d73c7 Bug-Url: https://bugzilla.redhat.com/958848 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/VmReplicateDiskFinishTaskHandler.java 1 file changed, 6 insertions(+), 2 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14441 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibd088940d6e3f7be79fb0381076499ea1c1d73c7 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove GlobalCatalogSrvLocator
by juan.hernandez＠redhat.com 07 May '13

07 May '13

Juan Hernandez has submitted this change and it was merged. Change subject: core: Remove GlobalCatalogSrvLocator ...................................................................... core: Remove GlobalCatalogSrvLocator This class is not used. Change-Id: I3b4b4bbf41c6c138b4370479719c45eab6a28299 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- D backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/ldap/GlobalCatalogSrvLocator.java 1 file changed, 0 insertions(+), 33 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14549 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3b4b4bbf41c6c138b4370479719c45eab6a28299 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: [cleanup] tiny cleanups
by ofrenkel＠redhat.com 07 May '13

07 May '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: [cleanup] tiny cleanups ...................................................................... core: [cleanup] tiny cleanups This patch contains: 1. change the indentation in HibernateVmCommand#getAuditLogTypeValue to make it more readable 2. simplified AsyncTaskManager#hasTasksForEntityIdAndAction structure 3. replace ArrayList with List in VdsActionParameterBase public methods signatures Change-Id: I7bbfc040e06ff1cfd48ba02a5992d0d533d9e75f Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmAndCloneImageCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AsyncTaskManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HibernateVmCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionParametersBase.java 4 files changed, 13 insertions(+), 15 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14532 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7bbfc040e06ff1cfd48ba02a5992d0d533d9e75f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: sort disks by ID in webadmin
by tnisan＠redhat.com 07 May '13

07 May '13

Tal Nisan has submitted this change and it was merged. Change subject: engine: sort disks by ID in webadmin ...................................................................... engine: sort disks by ID in webadmin Add to search of Disks tab the ability to sort by disk id. Change-Id: I373260552d1656dc15da8def6ecfed9e74022675 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/DiskConditionFieldAutoCompleter.java 1 file changed, 5 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14534 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I373260552d1656dc15da8def6ecfed9e74022675 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Fix mispelling in member name INSTANCE
by tnisan＠redhat.com 07 May '13

07 May '13

Tal Nisan has submitted this change and it was merged. Change subject: engine: Fix mispelling in member name INSTANCE ...................................................................... engine: Fix mispelling in member name INSTANCE Change-Id: Ibb07bd1b3f61826dc71a092acff20e858974b561 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/BiggerOrSmallerRelationAutoCompleter.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/DiskConditionFieldAutoCompleter.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/VmConditionFieldAutoCompleter.java 3 files changed, 3 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14531 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibb07bd1b3f61826dc71a092acff20e858974b561 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: fix typo in scheduler error message
by tnisan＠redhat.com 07 May '13

07 May '13

Tal Nisan has submitted this change and it was merged. Change subject: core: fix typo in scheduler error message ...................................................................... core: fix typo in scheduler error message Change-Id: I4f2f80002d26edefbca5aa43c124ebcb668127d8 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M backend/manager/modules/scheduler/src/main/java/org/ovirt/engine/core/utils/timer/JobWrapper.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14517 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4f2f80002d26edefbca5aa43c124ebcb668127d8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: build: Explicit versions definitions for maven plugins.
by asaf＠redhat.com 07 May '13

07 May '13

Asaf Shakarchi has submitted this change and it was merged. Change subject: build: Explicit versions definitions for maven plugins. ...................................................................... build: Explicit versions definitions for maven plugins. Maven 3.x deprecates definition of plugins and dependencies without explicit version specified, This commit defines explicit version for some maven plugins thus eliminates the startup maven warnings when a build occurs. Change-Id: I968a9ef2e4741acd313d2e165348bee1ccd1b0ed Signed-off-by: Asaf Shakarchi <asaf(a)redhat.com> --- M pom.xml 1 file changed, 22 insertions(+), 0 deletions(-) Approvals: Asaf Shakarchi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14289 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I968a9ef2e4741acd313d2e165348bee1ccd1b0ed Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin, userportal: Fix action table element IDs
by vszocs＠redhat.com 07 May '13

07 May '13

Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin,userportal: Fix action table element IDs ...................................................................... webadmin,userportal: Fix action table element IDs This patch fixes a problem in AbstractActionTable which uses two table widgets internally (optional header + main table). Since both above mentioned table widgets are now derived from ColumnResizeCellTable, and sice column definition objects are shared between both tables, we must not set element IDs for the optional header table. Change-Id: I318338a8e92b3967b4ce40ac288add846f0a1444 Bug-Url: https://bugzilla.redhat.com/960519 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/AbstractActionTable.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/ElementIdCellTable.java 2 files changed, 7 insertions(+), 6 deletions(-) Approvals: Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14546 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I318338a8e92b3967b4ce40ac288add846f0a1444 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0