- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: findbugs: Class define clone but not cloneable
by shavivi＠redhat.com 06 May '13

06 May '13

Shahar Havivi has submitted this change and it was merged. Change subject: findbugs: Class define clone but not cloneable ...................................................................... findbugs: Class define clone but not cloneable Change-Id: I5474832e1a9b26279bdc2e2d79546104fe74ee49 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaConsumptionParametersWrapper.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/rsdl/Signature.java 3 files changed, 3 insertions(+), 3 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14313 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5474832e1a9b26279bdc2e2d79546104fe74ee49 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: findbugs: toString may return null
by shavivi＠redhat.com 06 May '13

06 May '13

Shahar Havivi has submitted this change and it was merged. Change subject: findbugs: toString may return null ...................................................................... findbugs: toString may return null Change-Id: I7540e6cfadb76f742f5b9959418b5e0a6cbf4fed Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/NGuid.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14294 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7540e6cfadb76f742f5b9959418b5e0a6cbf4fed Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core:running the db scripts manually with user...
by emesika＠redhat.com 06 May '13

06 May '13

Eli Mesika has submitted this change and it was merged. Change subject: core:running the db scripts manually with user... ...................................................................... core:running the db scripts manually with user... running the db scripts manually with user posgres will change the table permission and upgrade will fail since user engine cannot change tables Setting user "engine" as the deault user for all the following utilities: backup.sh create_db.sh create_db_devel.sh create_schema.sh encryptionvalidator.sh encodingvalidator.sh exportDbSchema.sh fkvalidator.sh refreshStoredProcedures.sh restore.sh taskcleaner.sh unlock_entity.sh upgrade.sh Change-Id: I8ae8999dcfad53a1e62613dbff915f76b32e89de Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=958765 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/dbscripts/backup.sh M backend/manager/dbscripts/create_db.sh M backend/manager/dbscripts/create_db_devel.sh M backend/manager/dbscripts/create_schema.sh M backend/manager/dbscripts/dbcustomfunctions.sh M backend/manager/dbscripts/encryptionvalidator.sh M backend/manager/dbscripts/exportDbSchema.sh M backend/manager/dbscripts/refreshStoredProcedures.sh M backend/manager/dbscripts/restore.sh M backend/manager/dbscripts/unlock_entity.sh M backend/manager/dbscripts/upgrade.sh M backend/manager/tools/dbutils/common.sh M backend/manager/tools/dbutils/encodingvalidator.sh M backend/manager/tools/dbutils/fkvalidator.sh M backend/manager/tools/dbutils/taskcleaner.sh 15 files changed, 15 insertions(+), 15 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14438 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8ae8999dcfad53a1e62613dbff915f76b32e89de Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: ConcurrentModificationException failing domain/host ...
by yzaslavs＠redhat.com 06 May '13

06 May '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: engine: ConcurrentModificationException failing domain/host fail process ...................................................................... engine: ConcurrentModificationException failing domain/host fail process The following bugs were caused because of trying to iterate over collection and in the same time (inside an iteration) try to modify it. In order to solve a bug I removed one of the problematic collections, and move all logic to work with one collection Change-Id: Ie4e401263a6839370c7fccbf77b05d866fc06145 Bug-Url: https://bugzilla.redhat.com/958095 Bug-Url: https://bugzilla.redhat.com/958186 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java 1 file changed, 36 insertions(+), 53 deletions(-) Approvals: Michael Kublin: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14496 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie4e401263a6839370c7fccbf77b05d866fc06145 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: findbugs: self comparison of user to itself
by amureini＠redhat.com 06 May '13

06 May '13

Allon Mureinik has submitted this change and it was merged. Change subject: findbugs: self comparison of user to itself ...................................................................... findbugs: self comparison of user to itself Change-Id: Ifa88e752da82043857f27d334ba86ca1c5587bcd Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ssh/SSHD.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14293 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifa88e752da82043857f27d334ba86ca1c5587bcd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove stdout from SimpleAuthenticationCheck
by amureini＠redhat.com 06 May '13

06 May '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove stdout from SimpleAuthenticationCheck ...................................................................... core: Remove stdout from SimpleAuthenticationCheck Removed an old System.out.println call from the class - it was probably left there by mistake during debugging, and in any event has no place in production code. Change-Id: I1ac20e5aa5d9a8236a2a081c5cd0be68a25f724b Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ipa/SimpleAuthenticationCheck.java 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14421 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1ac20e5aa5d9a8236a2a081c5cd0be68a25f724b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: EncryptoinUtilsTest @Before->@BeforeClass
by amureini＠redhat.com 06 May '13

06 May '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: EncryptoinUtilsTest @Before->@BeforeClass ...................................................................... core: EncryptoinUtilsTest @Before->@BeforeClass Replaced the @Before method with @BeforeClass. There is a single URL that won't change between test runs. Change-Id: I89ad4e12f08af5e0ef19e486bf21c350ad7f1015 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/crypt/EncryptionUtilsTest.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14426 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I89ad4e12f08af5e0ef19e486bf21c350ad7f1015 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Synthetic emulators EcryptionUtilsTest
by amureini＠redhat.com 06 May '13

06 May '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Synthetic emulators EcryptionUtilsTest ...................................................................... core: Synthetic emulators EcryptionUtilsTest Changed members visibility from private to protected to solve the synthetic emulators warning. This may slightly increase performance, but I doubt it will be noticeable. Change-Id: I5d17aa584e4b8c1d858d74c155265a9f30cf86d0 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/crypt/EncryptionUtilsTest.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14425 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5d17aa584e4b8c1d858d74c155265a9f30cf86d0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Removed std from KDCLocatorTest
by amureini＠redhat.com 06 May '13

06 May '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Removed std from KDCLocatorTest ...................................................................... core: Removed std from KDCLocatorTest Removed printing of results with System.out.println - this is no way to handle robust logging. Change-Id: I37eac9646bcbabe3a80a563e41d7bd904de626cd Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/KDCLocatorTest.java 1 file changed, 0 insertions(+), 6 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14422 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I37eac9646bcbabe3a80a563e41d7bd904de626cd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Removed std from EncryptionUtilsTest
by amureini＠redhat.com 06 May '13

06 May '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Removed std from EncryptionUtilsTest ...................................................................... core: Removed std from EncryptionUtilsTest Removed printing of results with System.out.println - and replaced it with a proper error message in case of failure. Change-Id: Ia1386b1ddb0e090e5c49a6c3130a3dccfb35a365 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/crypt/EncryptionUtilsTest.java 1 file changed, 11 insertions(+), 6 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14423 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia1386b1ddb0e090e5c49a6c3130a3dccfb35a365 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0