- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Removed comparators' Compare methods
by amureini＠redhat.com 05 May '13

05 May '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Removed comparators' Compare methods ...................................................................... core: Removed comparators' Compare methods This is probably a leftover from the C# days. In java, comparators have a compare(T, T) method. Change-Id: I0fa2e830a9560dc4db9929053bd7ceced48a135d Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVMActionRunner.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/comparators/VmTemplateComparerByDiskSize.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/comparators/VmsComparer.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/comparators/VmsComparerByDiskSize.java 4 files changed, 3 insertions(+), 15 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified -- To view, visit http://gerrit.ovirt.org/14413 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0fa2e830a9560dc4db9929053bd7ceced48a135d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Replace FQCNs with imports for comparators
by amureini＠redhat.com 05 May '13

05 May '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Replace FQCNs with imports for comparators ...................................................................... core: Replace FQCNs with imports for comparators Replaced FQCN references with imports throughout the comparators package. Change-Id: I80a1f040a395a5681dedd891ba5e6ddeb601ec15 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/comparators/InterfaceComparerByMAC.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/comparators/VmTemplateComparerByDiskSize.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/comparators/VmsComparer.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/comparators/VmsComparerByDiskSize.java 4 files changed, 8 insertions(+), 5 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified -- To view, visit http://gerrit.ovirt.org/14414 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I80a1f040a395a5681dedd891ba5e6ddeb601ec15 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove comparators' empty default ctors
by amureini＠redhat.com 05 May '13

05 May '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove comparators' empty default ctors ...................................................................... core: Remove comparators' empty default ctors Removed empty implementation of the default constructor throughout the comparators package. These constructors have no added value, and just clatter up the code. Change-Id: Id8477d87cd992ceba047a4f07a75337b8ed7d30d Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/comparators/InterfaceComparerByMAC.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/comparators/VmTemplateComparerByDiskSize.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/comparators/VmsComparer.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/comparators/VmsComparerByDiskSize.java 4 files changed, 0 insertions(+), 12 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified -- To view, visit http://gerrit.ovirt.org/14415 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id8477d87cd992ceba047a4f07a75337b8ed7d30d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove FieldsInVDCConfigXmlToSQL
by amureini＠redhat.com 04 May '13

04 May '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove FieldsInVDCConfigXmlToSQL ...................................................................... core: Remove FieldsInVDCConfigXmlToSQL The FieldsInVDCConfigXmlToSQL is no longer in use, and should be removed. Change-Id: I950bbe7e04fd2f90df23e70d0749c8fa8210235f Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- D backend/manager/dbscripts/FieldsInVDCConfigXmlToSQL.java 1 file changed, 0 insertions(+), 263 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14191 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I950bbe7e04fd2f90df23e70d0749c8fa8210235f Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Fix redundant space in DB upgrade output
by amureini＠redhat.com 04 May '13

04 May '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Fix redundant space in DB upgrade output ...................................................................... core: Fix redundant space in DB upgrade output The run_file function only receives one argument, so $2 is always evaluated as an empty string. This cause the database upgrade/creation scripts to print "Running upgrade sql script" and "Running upgrade shell script", with two whitespaces after "Running" instead of just one. Removing the call to $2 resolves this issue. Change-Id: I3cb5f8778e570df1f2f76f3a16d32530b9a24b52 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/dbscripts/dbfunctions.sh 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14195 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3cb5f8778e570df1f2f76f3a16d32530b9a24b52 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: update splash page locales
by ecohen＠redhat.com 03 May '13

03 May '13

Einav Cohen has submitted this change and it was merged. Change subject: core: update splash page locales ...................................................................... core: update splash page locales After merging patch http://gerrit.ovirt.org/#/c/14356/, adjusting the splash page to conform to the updated list of available locales. Change-Id: I2f853c6e2d6526d1ca1665f934941f18f05946a0 Signed-off-by: Einav Cohen <ecohen(a)redhat.com> --- M backend/manager/modules/root/src/main/resources/org/ovirt/engine/core/languages.properties M backend/manager/modules/root/src/test/java/org/ovirt/engine/core/SplashServletTest.java 2 files changed, 8 insertions(+), 8 deletions(-) Approvals: Einav Cohen: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14409 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2f853c6e2d6526d1ca1665f934941f18f05946a0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin, userportal: Support column resizing for all tables
by vszocs＠redhat.com 03 May '13

03 May '13

Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin,userportal: Support column resizing for all tables ...................................................................... webadmin,userportal: Support column resizing for all tables This patch moves column resize implementation out of AbstractActionTable and into dedicated table widget, ColumnResizeCellTable. 1. All custom CellTable widgets now inherit from ColumnResizeCellTable: - ElementIdCellTable [ActionCellTable + EntityModelCellTable] - IVdcQueryableCellTable 2. ColumnResizeCellTable now contains enableColumnResizing() method, plus some other related/useful methods 3. Columns added to ColumnResizeCellTable automatically benefit from tooltip displayed when the given header has its content (text) truncated, i.e. after shrinking the column or with long header text 4. AbstractActionTable now just delegates to table/tableHeader widgets, plus code to synchronize both tables (during column resize, etc.) 5. AbstractCellWithTooltip now contains common tooltip-related logic used by different subclasses: - SafeHtmlCellWithTooltip [resizable + non-resizable header cells] - TextCellWithTooltip [textual body cells] 6. Minor ElementIdCellTable improvement: call configureElementId() for every insertColumn() call for better consistency AbstractCellWithTooltip does two kinds of content overflow detection: (a) scrollWidth with temporary CSS 'overflow:auto' (b) clientHeight with temporary CSS 'whiteSpace:normal' In practice, (a) is used for both header and body cells. In Firefox, header cells (SafeHtmlCellWithTooltip) use <div> with 'display:block' to work around Firefox-specific issue with scrollWidth. Change-Id: Ic69b597d7c5f2330cef5a93bc8812494af731734 Bug-Url: https://bugzilla.redhat.com/956378 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/EntityModelCellTable.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/IVdcQueryableCellTable.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/AbstractActionTable.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/ElementIdCellTable.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/SimpleActionTable.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/AbstractCellWithTooltip.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/SafeHtmlCellWithTooltip.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/TextCellWithTooltip.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/resize/ColumnResizeCellTable.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/resize/ResizableHeader.java D frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/resize/ResizableHeaderCell.java 11 files changed, 530 insertions(+), 235 deletions(-) Approvals: Einav Cohen: Looks good to me, approved Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14341 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic69b597d7c5f2330cef5a93bc8812494af731734 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: frontend: Disabling WAN options for SPICE doesn't work
by tjelinek＠redhat.com 03 May '13

03 May '13

Tomas Jelinek has submitted this change and it was merged. Change subject: frontend: Disabling WAN options for SPICE doesn't work ...................................................................... frontend: Disabling WAN options for SPICE doesn't work SPICE -> Enable WAN options causes 16bit color depth get kept for every console opening for whole browser session even after disabling this option in the console dialog. The problem was caused by not resetting the ColorDepth and DisabledEffects values after disabling WAN options to default values. Change-Id: Ie64779658796243f0182ac1209d9f5640b4370fc Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=913183 Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/AbstractSpice.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/SpicePluginImpl.java 2 files changed, 8 insertions(+), 4 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14398 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie64779658796243f0182ac1209d9f5640b4370fc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: frontend: Spice is always available
by tjelinek＠redhat.com 03 May '13

03 May '13

Tomas Jelinek has submitted this change and it was merged. Change subject: frontend: Spice is always available ...................................................................... frontend: Spice is always available This patch removes the method ConsoleUtils.isSpiceAvailable because it is no longer needed as spice can be always invoked using the nonplugin way. This patch also moves configuration of spice implementations (by Configurator classes) and connect listener to the method responsible for switching implementations on the fly so that effect of these actions is not forgotten after switching spice implementation. Change-Id: Ice5c3f80988962c5fa5e39f51e91543938258912 Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/popup/ConsolePopupPresenterWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/ConsoleManagerImpl.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/ConsoleOptionsFrontendPersisterImpl.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/ConsoleUtilsImpl.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/ConsoleUtils.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SpiceConsoleModel.java 6 files changed, 19 insertions(+), 42 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14390 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ice5c3f80988962c5fa5e39f51e91543938258912 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: WARNING: nonstandard use of escape in...
by yzaslavs＠redhat.com 03 May '13

03 May '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: WARNING: nonstandard use of escape in... ...................................................................... core: WARNING: nonstandard use of escape in... WARNING: nonstandard use of escape in a string literal Adding use of the escape string syntax for escapes, Change-Id: I168e1fe503c235d36b07aed18d88dc017726155e Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=958018 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/dbscripts/create_functions.sql 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14379 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I168e1fe503c235d36b07aed18d88dc017726155e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0