- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: packaging: engine-service: fix sysv typeo
by oschreib＠redhat.com 05 May '13

05 May '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: engine-service: fix sysv typeo ...................................................................... packaging: engine-service: fix sysv typeo Change-Id: Ie76ef19aed39b8ba8b2af646c110cfe864996ffe Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/services/ovirt-engine.sysv.in 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Alon Bar-Lev: Verified Ofer Schreiber: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14429 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie76ef19aed39b8ba8b2af646c110cfe864996ffe Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: Added generic DB validations before the upgrade
by oschreib＠redhat.com 05 May '13

05 May '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: Added generic DB validations before the upgrade ...................................................................... packaging: Added generic DB validations before the upgrade * This patch adds a simple validatedb.sh script that will run required validation scripts. * When a new validation script is added, it should be added to the validatedb runner script as well. * During the upgrade, this script is executed and handles the validations control to corresponding scripts. * If user decides not to clear DB issues or there's any other error, the exception is raised. * Patch also introduces some code cleanups Change-Id: Ief0e65231bb42b569734cdd2fa6491b645491f98 Bug-Url: https://bugzilla.redhat.com/893459 Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M Makefile M backend/manager/tools/dbutils/fkvalidator.sh M backend/manager/tools/dbutils/fkvalidator_sp.sql A backend/manager/tools/dbutils/validatedb.sh M packaging/fedora/setup/basedefs.py M packaging/fedora/setup/engine-upgrade.py M packaging/fedora/spec/ovirt-engine.spec.in 7 files changed, 200 insertions(+), 25 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12512 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ief0e65231bb42b569734cdd2fa6491b645491f98 Gerrit-PatchSet: 18 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: move all packaging related to packaging
by oschreib＠redhat.com 05 May '13

05 May '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: move all packaging related to packaging ...................................................................... packaging: move all packaging related to packaging currently we manage packaging scripts all over the tree, sometimes in different names than the file installed. this patch collects all files to be under the packaging directory using hierarchy similar to the installation and using same file naming. Change-Id: I6d0bd7b8cd5381ddb80b4b2e5ee7df65bab487bc Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M .gitignore M Makefile R packaging/bin/engine-config.sh R packaging/bin/engine-encrypt-passwd.sh R packaging/bin/engine-manage-domains.sh R packaging/bin/engine-notifier-service.sh R packaging/bin/engine-notifier.sh R packaging/bin/engine-prolog.sh.in R packaging/conf/engine-config-install.properties R packaging/conf/engine.conf.defaults.in R packaging/conf/jaas.conf R packaging/etc/engine-config/engine-config.conf R packaging/etc/engine-config/engine-config.properties R packaging/etc/engine-config/log4j.xml.in R packaging/etc/engine-manage-domains/engine-manage-domains.conf R packaging/etc/engine-manage-domains/log4j.xml.in R packaging/etc/engine.conf R packaging/etc/notifier/log4j.xml.in R packaging/etc/notifier/notifier.conf R packaging/etc/pki/CreateCA.sh R packaging/etc/pki/SignReq.lock R packaging/etc/pki/SignReq.sh R packaging/etc/pki/cacert.template.in R packaging/etc/pki/cert.template.in R packaging/etc/pki/certs/.keep R packaging/etc/pki/installCA.sh R packaging/etc/pki/keys/.keep R packaging/etc/pki/openssl.conf R packaging/etc/pki/private/.keep R packaging/etc/pki/requests/.keep R packaging/etc/sysprep/sysprep.2k12x64 R packaging/etc/sysprep/sysprep.2k3 R packaging/etc/sysprep/sysprep.2k8 R packaging/etc/sysprep/sysprep.2k8x86 R packaging/etc/sysprep/sysprep.w7 R packaging/etc/sysprep/sysprep.w7x64 R packaging/etc/sysprep/sysprep.w8 R packaging/etc/sysprep/sysprep.w8x64 R packaging/etc/sysprep/sysprep.xp R packaging/etc/usbfilter.txt 40 files changed, 34 insertions(+), 34 deletions(-) Approvals: Alon Bar-Lev: Verified Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14302 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6d0bd7b8cd5381ddb80b4b2e5ee7df65bab487bc Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: engine.conf: add quotes to selected keys
by oschreib＠redhat.com 05 May '13

05 May '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: engine.conf: add quotes to selected keys ...................................................................... packaging: engine.conf: add quotes to selected keys this to support potential space within value, while sourcing in shell. Change-Id: If7b0086fc2927449b54877e3cf1a18bd6e9480e0 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/conf/engine.conf.defaults.in 1 file changed, 7 insertions(+), 7 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14352 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If7b0086fc2927449b54877e3cf1a18bd6e9480e0 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: engine-cleanup: drop user as well
by oschreib＠redhat.com 05 May '13

05 May '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: engine-cleanup: drop user as well ...................................................................... packaging: engine-cleanup: drop user as well currently we drop database, but we create user as well, no reason why not to attempt remove it. Change-Id: I5cc437890d7cce686329435c12d82a50ab0df4b0 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/fedora/setup/basedefs.py M packaging/fedora/setup/engine-cleanup.py 2 files changed, 13 insertions(+), 0 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14363 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5cc437890d7cce686329435c12d82a50ab0df4b0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: enigne-service: cleanup to ease reuse
by oschreib＠redhat.com 05 May '13

05 May '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: enigne-service: cleanup to ease reuse ...................................................................... packaging: enigne-service: cleanup to ease reuse Change-Id: I755f550f6992851fd70e03afa1db008d6b42d9d4 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/services/ovirt-engine.py M packaging/services/ovirt-engine.systemd.in M packaging/services/ovirt-engine.sysv.in 3 files changed, 15 insertions(+), 16 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14372 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I755f550f6992851fd70e03afa1db008d6b42d9d4 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: cleanup spec file
by oschreib＠redhat.com 05 May '13

05 May '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: cleanup spec file ...................................................................... packaging: cleanup spec file 1. use %{_initddir} 2. be more consistent with service name, use explict name always Change-Id: Ib30fc665069d90b7cdb6855c92ee27d8ef143615 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/fedora/spec/ovirt-engine.spec.in 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14373 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib30fc665069d90b7cdb6855c92ee27d8ef143615 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal: prevent an error dialog in login page
by derez＠redhat.com 05 May '13

05 May '13

Daniel Erez has submitted this change and it was merged. Change subject: userportal: prevent an error dialog in login page ...................................................................... userportal: prevent an error dialog in login page Frontend -> handleActionResult: * Removed the redundant call to getEventsHandler().runActionFailed(failed) which invokes an error dialog without verifying 'isRaiseErrorModalPanel' flag first. * Removed the method as well since it's not used anymore. * Now, the error dialog will be invoked only after flag verification by raising frontendFailureEvent. * This issue of duplicate dialog invocation was hidden by now in UserPortal's login page by simply ignoring any error dialog (removed in Ibd2718649ab4031e6ff2b0d0e6c449f53164ff9f). Change-Id: Ib240214df319a0122ebcac82bf2b96d608997432 Bug-Url: https://bugzilla.redhat.com/957793 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/Frontend.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/IFrontendEventsHandler.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/FrontendEventsHandlerImpl.java 3 files changed, 0 insertions(+), 9 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14392 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib240214df319a0122ebcac82bf2b96d608997432 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove SearchQueryFormatter.main(String[])
by amureini＠redhat.com 05 May '13

05 May '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove SearchQueryFormatter.main(String[]) ...................................................................... core: Remove SearchQueryFormatter.main(String[]) SearchQueryFormatter seems to have an old main(String[]) function used for a visual sanity check. This method has not real use, and no place in production code. Change-Id: I4e36f0fe4dd51d96725090a5ece6f736f298a4e7 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/SearchQueryFotmatter.java 1 file changed, 0 insertions(+), 13 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14420 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4e36f0fe4dd51d96725090a5ece6f736f298a4e7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: LexoNumericComparator to comparators pkg
by amureini＠redhat.com 05 May '13

05 May '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: LexoNumericComparator to comparators pkg ...................................................................... core: LexoNumericComparator to comparators pkg Moved LexoNumericComparator to the comparators package, like all the other comparators. Change-Id: Ic23f6efefb8f83a791cab38f3da43a78c5f885bb Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- R backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/comparators/LexoNumericComparator.java R backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/businessentities/comparators/LexoNumericComparatorTest.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostBondInterfaceModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/SetupNetworksBondModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/NetworkItemModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInterfaceModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkItemPanel.java 9 files changed, 10 insertions(+), 10 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified -- To view, visit http://gerrit.ovirt.org/14412 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic23f6efefb8f83a791cab38f3da43a78c5f885bb Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0