- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: User Event Notification dialog element IDs
by vszocs＠redhat.com 02 May '13

02 May '13

Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin: User Event Notification dialog element IDs ...................................................................... webadmin: User Event Notification dialog element IDs 1. UI infrastructure changes - created ElementIdCellTree that supports assigning DOM element IDs to tree nodes through HasElementId interface - EntityModelCellTree derives from ElementIdCellTree, so all model-bound trees now support node element IDs - ModelListTreeViewModel does the actual element ID assignment for the CheckboxCell - example tree node ID, e.g. 2nd child of 3rd root node: <prefix>_root2_node1 2. WebAdmin dialog changes - User Event Notification dialog (ManageEventsPopupView) now supports element IDs for Tree and Expand/Collapse buttons Change-Id: Icf18b0080fffe6ba3886736a605f53570889bf3a Bug-Url: https://bugzilla.redhat.com/870993 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- R frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/model/TreeNodeModel.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/ElementIdUtils.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/ColumnWithElementId.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/tree/ElementIdCellTree.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/tree/TreeModelWithElementId.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/AssignTagsPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/configure/RolePopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/user/ManageEventsPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/uicommon/model/ModelListTreeViewModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/uicommon/model/SimpleSelectionTreeNodeModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/editor/EntityModelCellTree.java 11 files changed, 220 insertions(+), 88 deletions(-) Approvals: Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14048 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icf18b0080fffe6ba3886736a605f53570889bf3a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: Adding parameters to delay fence based on host's load
by yzaslavs＠redhat.com 02 May '13

02 May '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: Adding parameters to delay fence based on host's load ...................................................................... Adding parameters to delay fence based on host's load Before performing fencing to host, we wait TimeoutToResetVdsInSeconds. This patch adds a formula based on vms count and SPM status that calculates different timeout period before starting the fence. Change-Id: I69c15b254cb5323416aaa33756866218870056d2 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=924801 Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com> --- M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java M backend/manager/tools/src/main/conf/engine-config.properties 4 files changed, 31 insertions(+), 3 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14288 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I69c15b254cb5323416aaa33756866218870056d2 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>

1 0

Change in ovirt-engine[master]: tools: move profile to the end of the pom
by lhornyak＠redhat.com 02 May '13

02 May '13

Laszlo Hornyak has submitted this change and it was merged. Change subject: tools: move profile to the end of the pom ...................................................................... tools: move profile to the end of the pom Moved the optional itests profile to the end of the pom file to make it more readable. Now, the regular build flow can be read without the conceptual interruption of an optional profile. Change-Id: I611035ea98c5254c1e5b86d057255447d1ce313e Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/tools/pom.xml 1 file changed, 15 insertions(+), 17 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14272 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I611035ea98c5254c1e5b86d057255447d1ce313e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: tools: enable unit tests
by lhornyak＠redhat.com 02 May '13

02 May '13

Laszlo Hornyak has submitted this change and it was merged. Change subject: tools: enable unit tests ...................................................................... tools: enable unit tests The tools package contains some useful unit tests, which are unfortunately disabled since they are intermixed with integration tests. This patch replaces the all-out disabling of the package's tests with a black list of component tests, allowing the unit tests to run in build time. Change-Id: Ic9205fd5d46fb8e44c0ad87cfbe4c3b5c7817dbe Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/tools/pom.xml 1 file changed, 16 insertions(+), 4 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14271 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic9205fd5d46fb8e44c0ad87cfbe4c3b5c7817dbe Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: gluster: Override CommandBase.getJobMessageProperties
by sanjal＠redhat.com 02 May '13

02 May '13

Shireesh Anjal has submitted this change and it was merged. Change subject: gluster: Override CommandBase.getJobMessageProperties ...................................................................... gluster: Override CommandBase.getJobMessageProperties The patch overrides the basic implementation of getJobMessageProperties with a concrete one relevant to Gluster commands: 1. Commands inherited from GlusterCommandBase define the Cluster name. 2. Commands inherited from GlusterVolumeCommandBase define Volume name as well as Cluster name. Change-Id: I393621e3f52b343b8dc5916f20497a0da3aa3bf1 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterVolumeCommandBase.java M backend/manager/modules/dal/src/main/resources/bundles/ExecutionMessages.properties 3 files changed, 27 insertions(+), 1 deletion(-) Approvals: Shireesh Anjal: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10988 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I393621e3f52b343b8dc5916f20497a0da3aa3bf1 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[engine_3.2]: restapi:Correct rsdl for add bricks
by mpastern＠redhat.com 02 May '13

02 May '13

Michael Pasternak has submitted this change and it was merged. Change subject: restapi:Correct rsdl for add bricks ...................................................................... restapi:Correct rsdl for add bricks Add bricks command causes an exception in cli when passed a collection of bricks. Changed the rsdl to brick--COLLECTION as per Michael's suggestion Change-Id: I2a229faa90c8fcded33b53ab8801c4cb03094798 Bug-Url: https://bugzilla.redhat.com/923169 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml 1 file changed, 15 insertions(+), 16 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14381 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2a229faa90c8fcded33b53ab8801c4cb03094798 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.2 Gerrit-Owner: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: disabling POST & DELETE implementations for quota
by mpastern＠redhat.com 02 May '13

02 May '13

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: disabling POST & DELETE implementations for quota ...................................................................... restapi: disabling POST & DELETE implementations for quota It is not fully implemented, therefore removing it. Change-Id: I819cad0212ea941fa5ff3dcf14386201b7a0577d Bug-Url: https://bugzilla.redhat.com/950464 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/QuotasResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendQuotasResource.java 2 files changed, 1 insertion(+), 30 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14046 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I819cad0212ea941fa5ff3dcf14386201b7a0577d Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: Added usages option to CLI add cluster network
by mpastern＠redhat.com 02 May '13

02 May '13

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: Added usages option to CLI add cluster network ...................................................................... restapi: Added usages option to CLI add cluster network When adding a network via CLI, in cluster context, added the ability to pass the usages option - same as when updating a network. Change-Id: Id4573674ddd1015eba33a05b95d687f685f707c4 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=949884 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13873 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id4573674ddd1015eba33a05b95d687f685f707c4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine[engine_3.2]: restapi : don't set jsessionid cookie when authentication fa...
by mpastern＠redhat.com 02 May '13

02 May '13

Michael Pasternak has submitted this change and it was merged. Change subject: restapi : don't set jsessionid cookie when authentication fails(#927140) ...................................................................... restapi : don't set jsessionid cookie when authentication fails(#927140) Rest APi returns session id when authentication fails and the user makes calls with "prefer: persistent-auth" Change-Id: I84907ab56e99ebb875124f42345d691edad3cdbe Bug-Url: https://bugzilla.redhat.com/927140 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/security/auth/Challenger.java M backend/manager/modules/restapi/interface/common/jaxrs/src/test/java/org/ovirt/engine/api/common/security/auth/ChallengerTest.java 2 files changed, 16 insertions(+), 11 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14042 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I84907ab56e99ebb875124f42345d691edad3cdbe Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.2 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi : don't set jsessionid cookie when authentication fa...
by mpastern＠redhat.com 02 May '13

02 May '13

Michael Pasternak has submitted this change and it was merged. Change subject: restapi : don't set jsessionid cookie when authentication fails(#927140) ...................................................................... restapi : don't set jsessionid cookie when authentication fails(#927140) Rest APi returns session id when authentication fails and the user makes calls with "prefer: persistent-auth" Change-Id: I84907ab56e99ebb875124f42345d691edad3cdbe Bug-Url: https://bugzilla.redhat.com/927140 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/security/auth/Challenger.java M backend/manager/modules/restapi/interface/common/jaxrs/src/test/java/org/ovirt/engine/api/common/security/auth/ChallengerTest.java 2 files changed, 16 insertions(+), 11 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13371 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I84907ab56e99ebb875124f42345d691edad3cdbe Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0