- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Singleton row mapper for VdsDynamic
by amureini＠redhat.com 03 Mar '13

03 Mar '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Singleton row mapper for VdsDynamic ...................................................................... core: Singleton row mapper for VdsDynamic Added a singleton row mapper for VdsDynamic, as specified by http://www.ovirt.org/Backend_Coding_Standards . Change-Id: I1c3a587db0b43e6b1da40f310479a366c8799a60 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDynamicDAODbFacadeImpl.java 1 file changed, 68 insertions(+), 67 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12576 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1c3a587db0b43e6b1da40f310479a366c8799a60 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Singleton row mapper for VdsStatistics
by amureini＠redhat.com 03 Mar '13

03 Mar '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Singleton row mapper for VdsStatistics ...................................................................... core: Singleton row mapper for VdsStatistics Added a singleton row mapper for VdsStatistics, as specified by http://www.ovirt.org/Backend_Coding_Standards . Change-Id: I138a81d75fd2965eb15979aa925687f64bb19fbc Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsStatisticsDAODbFacadeImpl.java 1 file changed, 33 insertions(+), 30 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12577 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I138a81d75fd2965eb15979aa925687f64bb19fbc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: Updated psql calls not to ask password
by oschreib＠redhat.com 03 Mar '13

03 Mar '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: Updated psql calls not to ask password ...................................................................... packaging: Updated psql calls not to ask password Currently we use our own pgpass file to supply the required password for the user. This patch adds a "-w" flag for all psql calls that inhibits quering password at all. This will lead to psql connection errors if pgpass was incorrectly defined, but password will still not be asked, which is the desired behavior of the setup. Bug-Url: https://bugzilla.redhat.com/915409 Change-Id: Ib73a7e3a5955a66afa0eeeafa80cf1f6464e8fd4 Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M backend/manager/dbscripts/dbfunctions.sh M backend/manager/dbscripts/engine-db-install.sh M backend/manager/dbscripts/restore.sh M backend/manager/tools/dbutils/fkvalidator.sh M backend/manager/tools/dbutils/taskcleaner.sh M packaging/fedora/setup/common_utils.py M packaging/fedora/setup/engine-upgrade.py 7 files changed, 27 insertions(+), 19 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12418 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib73a7e3a5955a66afa0eeeafa80cf1f6464e8fd4 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Disable unsupported fence agents in UI
by emesika＠redhat.com 02 Mar '13

02 Mar '13

Eli Mesika has submitted this change and it was merged. Change subject: core: Disable unsupported fence agents in UI ...................................................................... core: Disable unsupported fence agents in UI Remove the alom Power Management agent from supported agent device since fence_alom script was removed from the fence_agents rpm Change-Id: I199d50968f42e1e237d8b2f26f1fda2c6407a061 Signed-off-by: Eli Mesika <emesika(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=908278 --- M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12519 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I199d50968f42e1e237d8b2f26f1fda2c6407a061 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal: fix memory leaks
by ecohen＠redhat.com 01 Mar '13

01 Mar '13

Einav Cohen has submitted this change and it was merged. Change subject: userportal: fix memory leaks ...................................................................... userportal: fix memory leaks - Fixed a memory leak in user portal extended tab - Fixed a memory leak in user portal basic tab. Change-Id: I6ebfd191f59b3ab9841b0cb11c110e50da336263 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/action/UiCommandButtonDefinition.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalBasicListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalItemModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/tab/basic/MainTabBasicListItemPresenterWidget.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/tab/basic/MainTabBasicListPresenterWidget.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/basic/MainTabBasicListItemView.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/basic/MainTabBasicListView.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/extended/SideTabExtendedVirtualMachineView.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/basic/MainTabBasicListItemActionButton.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/extended/vm/ImageButtonCell.java 11 files changed, 357 insertions(+), 244 deletions(-) Approvals: Einav Cohen: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11975 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6ebfd191f59b3ab9841b0cb11c110e50da336263 Gerrit-PatchSet: 21 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal: stop basic list provider on extended tab
by ecohen＠redhat.com 01 Mar '13

01 Mar '13

Einav Cohen has submitted this change and it was merged. Change subject: userportal: stop basic list provider on extended tab ...................................................................... userportal: stop basic list provider on extended tab - Modified how listener is attached - Fix UserPortalConfigurator getSpiceFullScreen Change-Id: I18e24cfcb5a477df3d3017b2f72409a37162ea64 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/place/UserPortalPlaceManager.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/AbstractModelActivationPresenter.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/uicommon/UserPortalConfigurator.java 3 files changed, 23 insertions(+), 21 deletions(-) Approvals: Einav Cohen: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12104 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I18e24cfcb5a477df3d3017b2f72409a37162ea64 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal: Fix UI update for Basic list item
by ecohen＠redhat.com 01 Mar '13

01 Mar '13

Einav Cohen has submitted this change and it was merged. Change subject: userportal: Fix UI update for Basic list item ...................................................................... userportal: Fix UI update for Basic list item Since MainTabBasicListItemPresenterWidget is bound as non-singleton, the EditorDriver instance must not be static, but bound to the given View instance. Change-Id: I6ad79df01ae452397727b6481a9fbe68fa7bc677 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/basic/MainTabBasicListItemView.java 1 file changed, 5 insertions(+), 4 deletions(-) Approvals: Einav Cohen: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12524 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6ad79df01ae452397727b6481a9fbe68fa7bc677 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal: fix memory leak when VM selected
by ecohen＠redhat.com 01 Mar '13

01 Mar '13

Einav Cohen has submitted this change and it was merged. Change subject: userportal: fix memory leak when VM selected ...................................................................... userportal: fix memory leak when VM selected - Fixed a slow memory leak when selecting a VM. Change-Id: Ibea56e991d5d09051ab931cb1584d9c94f74ab42 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/editor/AbstractUiCommonModelEditorDriver.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/FormBuilder.java 2 files changed, 16 insertions(+), 9 deletions(-) Approvals: Einav Cohen: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12301 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibea56e991d5d09051ab931cb1584d9c94f74ab42 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal: Optimize basic view
by ecohen＠redhat.com 01 Mar '13

01 Mar '13

Einav Cohen has submitted this change and it was merged. Change subject: userportal: Optimize basic view ...................................................................... userportal: Optimize basic view 1. Fixed VmPool.equals method 2. Added UserPortalItemModel.entityStateEqualTo method containing VM/Pool entity state comparison logic 3. Fixed related NPE in UserPortalListModel that occured when items == null, and added break statement to optimize selected item handling loop 4. UserPortalBasicListModel provider now includes original optimization logic: * on first data update, just proceed to refresh UI * on subsequent data update, proceed to refresh UI only if there's (any) change in items 5. VM/Pool list presenter widget includes additional optimization logic: * reuse item presenter widgets (avoid recreating item views) for existing items * properly unbind/remove item presenter widgets whose items are absent within new data 6. VM/Pool item presenter widget's setModel method and related code refactored to allowed repeated setModel invocations Change-Id: I17b92858345de398dbc89d9141468ccea67963fe Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalBasicListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalItemModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/tab/basic/MainTabBasicListItemPresenterWidget.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/tab/basic/MainTabBasicListPresenterWidget.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/basic/MainTabBasicListItemView.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/uicommon/model/basic/UserPortalBasicListProvider.java 7 files changed, 218 insertions(+), 89 deletions(-) Approvals: Einav Cohen: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10509 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I17b92858345de398dbc89d9141468ccea67963fe Gerrit-PatchSet: 18 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal: Set default VM/Pool refresh rate to 30s for IE8
by ecohen＠redhat.com 01 Mar '13

01 Mar '13

Einav Cohen has submitted this change and it was merged. Change subject: userportal: Set default VM/Pool refresh rate to 30s for IE8 ...................................................................... userportal: Set default VM/Pool refresh rate to 30s for IE8 For IE8 and below, default refresh rate for VM/Pool entities is set to 30 seconds. This change applies to following parts of UI: - Basic tab - Extended tab [Virtual Machines grid] Change-Id: Ibcaf85e0f6f38b522ccc282a0a76ef3016a220ea Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/gin/BaseClientGinjector.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/refresh/AbstractRefreshManager.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/SimpleActionTable.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/AbstractSideTabWithDetailsView.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/MainTabBasicView.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/extended/SideTabExtendedResourceView.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/extended/SideTabExtendedTemplateView.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/extended/SideTabExtendedVirtualMachineView.java A frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/refresh/UserPortalRefreshManager.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/table/column/UserPortalSimpleActionTable.java 10 files changed, 102 insertions(+), 40 deletions(-) Approvals: Einav Cohen: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12340 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibcaf85e0f6f38b522ccc282a0a76ef3016a220ea Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0