- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: restapi: add /disks sub-collection to /storagedomain resourc...
by amureini＠redhat.com 28 Feb '13

28 Feb '13

Allon Mureinik has submitted this change and it was merged. Change subject: restapi: add /disks sub-collection to /storagedomain resource ...................................................................... restapi: add /disks sub-collection to /storagedomain resource - This patch is preparation for the NetApp external cloning integration support, added new /disks sub-collections under /storagedomain & dataceneter/storagedomain, new URIs are: /api/storagedomains/{storagedomain:id}/disks|rel=get /api/storagedomains/{storagedomain:id}/disks/{disk:id}|rel=get /api/storagedomains/{storagedomain:id}/disks/{disk:id}|rel=delete /api/storagedomains/{storagedomain:id}/disks|rel=add /api/datacenters/{datacenter:id}/storagedomains/{storagedomain:id}/disks|rel=get /api/datacenters/{datacenter:id}/storagedomains/{storagedomain:id}/disks/{disk:id}|rel=get /api/datacenters/{datacenter:id}/storagedomains/{storagedomain:id}/disks/{disk:id}|rel=delete /api/datacenters/{datacenter:id}/storagedomains/{storagedomain:id}/disks|rel=add - 'scan' for yet imported disks will be performed via [1], NetApp will implement /import action on the disk. [1] /api/storagedomains/{storagedomain:id}/disks;unregistered|rel=get /api/datacenters/{datacenter:id}/storagedomains/{storagedomain:id}/disks;unregistered|rel=get Change-Id: If6c18e5b28e81f13b44e9431efd623a5627379a1 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/util/LinkHelper.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/AttachedStorageDomainResource.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/StorageDomainResource.java M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendAttachedStorageDomainResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendAttachedStorageDomainsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDisksResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainDiskResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainDisksResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainsResource.java A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainDiskResourceTest.java A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainDisksResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainsResourceTest.java 15 files changed, 551 insertions(+), 8 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10337 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If6c18e5b28e81f13b44e9431efd623a5627379a1 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Chris Morrissey <cmorriss(a)netapp.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal: quota permissions show extended view wrongfully
by gchaplik＠redhat.com 27 Feb '13

27 Feb '13

Gilad Chaplik has submitted this change and it was merged. Change subject: userportal: quota permissions show extended view wrongfully ...................................................................... userportal: quota permissions show extended view wrongfully In the userportal we show extended view if the user has other permissions associated with him that are not included in user role. 'Consume Quota' is a user role and action group that is not included in user role, therefore, in client side, we will add a check for consume quota action group, and ignore/skip it. Change-Id: I435bf61277bb77fd4e400ee738b74f71024f57d3 Bug-Url: https://bugzilla.redhat.com/905144 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalLoginModel.java 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Gilad Chaplik: Verified Einav Cohen: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12008 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I435bf61277bb77fd4e400ee738b74f71024f57d3 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine-sdk[sdk_3.2]: sdk: explicitly ask for reply in xml
by mpastern＠redhat.com 27 Feb '13

27 Feb '13

Michael Pasternak has submitted this change and it was merged. Change subject: sdk: explicitly ask for reply in xml ...................................................................... sdk: explicitly ask for reply in xml Change-Id: I5f9b9e6a68e352371e0150b7ef5b2298656cd2cd Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M src/ovirtsdk/web/connection.py 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved Ravi Nori: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/12499 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5f9b9e6a68e352371e0150b7ef5b2298656cd2cd Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_3.2 Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine-sdk[master]: sdk: explicitly ask for reply in xml
by mpastern＠redhat.com 27 Feb '13

27 Feb '13

Michael Pasternak has submitted this change and it was merged. Change subject: sdk: explicitly ask for reply in xml ...................................................................... sdk: explicitly ask for reply in xml Change-Id: I5f9b9e6a68e352371e0150b7ef5b2298656cd2cd Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M src/ovirtsdk/web/connection.py 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved Ravi Nori: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/12500 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5f9b9e6a68e352371e0150b7ef5b2298656cd2cd Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: sanity check for cluster's quota
by gchaplik＠redhat.com 27 Feb '13

27 Feb '13

Gilad Chaplik has submitted this change and it was merged. Change subject: core: sanity check for cluster's quota ...................................................................... core: sanity check for cluster's quota If quota mode is enforced, we should fail action in case no quota is provided. This bug was hidden from UI, and discovered via REST, since there is a client validation for it. The original bug was opened only for AddVmFromScratch, Added this missing check also to: *AddVm *AddVmFromTemplate *AddVmFromSnapshot *AddVmTemplate Change-Id: I0ef84ca9603a16014edaa4ddf99dfaa2f31744d4 Bug-Url: https://bugzilla.redhat.com/909749 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmPoolWithVmsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java 4 files changed, 49 insertions(+), 10 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12012 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0ef84ca9603a16014edaa4ddf99dfaa2f31744d4 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: prevent several imported VMs with same name
by derez＠redhat.com 27 Feb '13

27 Feb '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: prevent several imported VMs with same name ...................................................................... webadmin: prevent several imported VMs with same name This patch prevents the user from assigning the same name for several imported VMs. if the user tries to assign a name that was already been assigned for a different VM that is going to be imported, the name field will be marked as invalid with a proper error message. When the user tried to import multiple VMs that already exist, he could choose a different name for each of them. when doing so, there was no validation that ensures the user don't assign the same name for several VMs, so the backend got that bunch of VMs to import with the given names and created them without checking that each name is unique (because it's done as multiple actions, thus not checking canDoAction on each of them), and the result is that there were multiple VMs created with the same name. So this patch prevents this situation from happening by ensuring that the UI don't pass several VMs with the same name to import to the backend, by adding a proper validation for the name field of the to-be-imported VM which checks that it's unique. Change-Id: I69eae7350ae840a06b440003c436f7adc0b032cd Bug-Url: https://bugzilla.redhat.com/907132 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/TemplateBackupModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/VmBackupModel.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/NotInCollectionValidation.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Messages.java 4 files changed, 184 insertions(+), 66 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12203 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I69eae7350ae840a06b440003c436f7adc0b032cd Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine-cli[master]: cli: Bad error message when trying to create a new Role(#908...
by mpastern＠redhat.com 27 Feb '13

27 Feb '13

Michael Pasternak has submitted this change and it was merged. Change subject: cli: Bad error message when trying to create a new Role(#908284) ...................................................................... cli: Bad error message when trying to create a new Role(#908284) Bad error message when trying to create a new Role without passing the collection correctly : "unknown error: 'int' object has no attribute 'split'" Change-Id: Iba01f4f02c0521332b84e7d5148b0c00c0a70b63 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=908284 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M src/ovirtcli/command/command.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12462 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iba01f4f02c0521332b84e7d5148b0c00c0a70b63 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi : RSDL lists host display address as mandatory(#9150...
by mpastern＠redhat.com 27 Feb '13

27 Feb '13

Michael Pasternak has submitted this change and it was merged. Change subject: restapi : RSDL lists host display address as mandatory(#915066) ...................................................................... restapi : RSDL lists host display address as mandatory(#915066) Host display address is listed as a mandatory parameter in api?rsdl This patch changes the host.display.address to optional parameter Change-Id: Iaa6d7799d9e8f2bf45e8bb076c40afafff9f5e07 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=915066 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12424 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaa6d7799d9e8f2bf45e8bb076c40afafff9f5e07 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine-sdk[sdk_3.2]: codegen: regenerate using new templates
by mpastern＠redhat.com 27 Feb '13

27 Feb '13

Michael Pasternak has submitted this change and it was merged. Change subject: codegen: regenerate using new templates ...................................................................... codegen: regenerate using new templates Change-Id: I4a668084d7d1600678898f005b129606e23e49f9 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M src/ovirtsdk/infrastructure/brokers.py 1 file changed, 4,715 insertions(+), 1,714 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12491 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4a668084d7d1600678898f005b129606e23e49f9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_3.2 Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine-sdk[master]: sdk: Add constructor parameter validate_cert_chain=True #915...
by mpastern＠redhat.com 27 Feb '13

27 Feb '13

Michael Pasternak has submitted this change and it was merged. Change subject: sdk: Add constructor parameter validate_cert_chain=True #915225 ...................................................................... sdk: Add constructor parameter validate_cert_chain=True #915225 https://bugzilla.redhat.com/show_bug.cgi?id=915225 Change-Id: I61707c4b0380665bc42b34387efdc622cfc4201e Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M src/codegen/templates/entrypointtemplate M src/ovirtsdk/api.py M src/ovirtsdk/infrastructure/connectionspool.py M src/ovirtsdk/web/connection.py 4 files changed, 37 insertions(+), 11 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Michael Pasternak: Verified; Looks good to me, approved Ravi Nori: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/12474 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I61707c4b0380665bc42b34387efdc622cfc4201e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0