- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: userportal: Optimize basic view
by ecohen＠redhat.com 01 Mar '13

01 Mar '13

Einav Cohen has submitted this change and it was merged. Change subject: userportal: Optimize basic view ...................................................................... userportal: Optimize basic view 1. Fixed VmPool.equals method 2. Added UserPortalItemModel.entityStateEqualTo method containing VM/Pool entity state comparison logic 3. Fixed related NPE in UserPortalListModel that occured when items == null, and added break statement to optimize selected item handling loop 4. UserPortalBasicListModel provider now includes original optimization logic: * on first data update, just proceed to refresh UI * on subsequent data update, proceed to refresh UI only if there's (any) change in items 5. VM/Pool list presenter widget includes additional optimization logic: * reuse item presenter widgets (avoid recreating item views) for existing items * properly unbind/remove item presenter widgets whose items are absent within new data 6. VM/Pool item presenter widget's setModel method and related code refactored to allowed repeated setModel invocations Change-Id: I17b92858345de398dbc89d9141468ccea67963fe Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalBasicListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalItemModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/tab/basic/MainTabBasicListItemPresenterWidget.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/tab/basic/MainTabBasicListPresenterWidget.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/basic/MainTabBasicListItemView.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/uicommon/model/basic/UserPortalBasicListProvider.java 7 files changed, 218 insertions(+), 89 deletions(-) Approvals: Einav Cohen: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10509 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I17b92858345de398dbc89d9141468ccea67963fe Gerrit-PatchSet: 18 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal: Optimization fixes
by ecohen＠redhat.com 01 Mar '13

01 Mar '13

Einav Cohen has submitted this change and it was merged. Change subject: userportal: Optimization fixes ...................................................................... userportal: Optimization fixes 1. Fixed a problem when Basic view item selection was not retained after subsequent data refresh 2. Fixed a problem when Basic view UI was redrawn even when there was no change in items 3. Removed duplicate code with regard to clearing UserPortalItemModel references by moving it to IUserPortalListModel (parent class) 4. Fixed issue where if nothing changed the buttons would become disabled. 5. Fixed issue where buttons in basic/extended tab were unresponsive. Change-Id: I81b30a5e03d35862d92e6630aac71c70f7cd75de Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalBasicListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/uicommon/model/AbstractUserPortalListProvider.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/uicommon/model/UserPortalDataBoundModelProvider.java 4 files changed, 21 insertions(+), 19 deletions(-) Approvals: Einav Cohen: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12213 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I81b30a5e03d35862d92e6630aac71c70f7cd75de Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: frontend: Non-plugin automatic invocation of console session
by tjelinek＠redhat.com 01 Mar '13

01 Mar '13

Tomas Jelinek has submitted this change and it was merged. Change subject: frontend: Non-plugin automatic invocation of console session ...................................................................... frontend: Non-plugin automatic invocation of console session This patch adds a native way of connecting to a (SPICE and VNC) console from WA/UP using external viewer (virt-viewer) installed on client system. It is achieved by implementing a servlet that generates a config file (with all needed information to connect) for virt-viewer that is served to the client afterwards. The old way of invoking console viewer (browser plugin) is still kept, the configuration is set in the database. The behavior for SPICE is driven by configuration. There are three modes of behavior: - Plugin - The "old" way - spice-xpi is used. - Native - The native client is used. - Auto - If plugin is installed, it is used. Otherwise "native" implementation is used. As for VNC - it is set to use the native implementation by default (i.e. there is no VNC connection info popup dialog). Frontend changes: - removed classes that deal with displaying VNC connection info popup - added SpiceNativeImpl (implements ISpice) for invoking request for spice client configuration file - renamed SpiceInterfaceImpl to SpicePluginImpl - added marking interfaces to these two implementations - added class AbstractSpice that contains common properties of ISpice implementations - added ClientConsoleMode enum for representing console mode configuration (Auto, Native, Plugin) Change-Id: Ib31e870deb7ecb3dac4cff25e49a3ebca4706a25 Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=843410 --- A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/AbstractSpice.java D frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/IVncImpl.java D frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/SpiceInterfaceImpl.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/SpiceNativeImpl.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/SpicePluginImpl.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/UiCommonDefaultTypeResolver.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Configurator.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/IUserPortalListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ConsoleModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ISpice.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ISpiceNative.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ISpicePlugin.java D frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/IVnc.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SpiceConsoleModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VncConsoleModel.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/popup/console/ConsolePopupPresenterWidget.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/popup/console/ConsolePopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/uicommon/WebAdminConfigurator.java 19 files changed, 1,001 insertions(+), 972 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Frank Kobzik: Verified -- To view, visit http://gerrit.ovirt.org/11703 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib31e870deb7ecb3dac4cff25e49a3ebca4706a25 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Non-plugin automatic invocation of console session
by tjelinek＠redhat.com 01 Mar '13

01 Mar '13

Tomas Jelinek has submitted this change and it was merged. Change subject: core: Non-plugin automatic invocation of console session ...................................................................... core: Non-plugin automatic invocation of console session This patch adds a native way of connecting to a (SPICE and VNC) console from WA/UP using external viewer (virt-viewer) installed on client system. It is achieved by implementing a servlet that generates a config file (with all needed information to connect) for virt-viewer that is served to the client afterwards. The old way of invoking console viewer (browser plugin) is still kept, the configuration is set in the database. The behavior for SPICE is driven by configuration. There are three modes of behavior: - Plugin - The "old" way - spice-xpi is used. - Native - The native client is used. - Auto - If plugin is installed, it is used. Otherwise "native" implementation is used. As for VNC - it is set to use the native implementation by default (i.e. there is no VNC connection info popup dialog). Backend changes: - Added servlets for serving console configuration. - Added ClientConsoleMode to vdc_options (default setting is 'Auto') and modified related enums. Change-Id: I18b9d2efad15f5e9bb98a8176112b721c810205f Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=843410 --- M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java A backend/manager/modules/root/src/main/java/org/ovirt/engine/core/GetAttachmentServlet.java M backend/manager/modules/root/src/main/webapp/WEB-INF/web.xml 5 files changed, 73 insertions(+), 0 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Frank Kobzik: Verified -- To view, visit http://gerrit.ovirt.org/11702 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I18b9d2efad15f5e9bb98a8176112b721c810205f Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal: ignore the NetworkUser role
by tjelinek＠redhat.com 01 Mar '13

01 Mar '13

Tomas Jelinek has submitted this change and it was merged. Change subject: userportal: ignore the NetworkUser role ...................................................................... userportal: ignore the NetworkUser role Since 97e84c622a7cfa9f709eb4d814d42d90448edc91 there is a NetworkUser role and this role is assigned to everyone. Since the engineUser does not contain this role, UP evaluates, that this specific user has more roles than the engineUser so he is an admin and should see the extended tab. Fixed by ignoring the NetworkUser in this algorithm the same way as e.g. the QuotaConsumer is. Change-Id: Iaf696b51159ba016d88124b789d5bbbab7b736fe Bug-Url: https://bugzilla.redhat.com/916328 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/auth/ApplicationGuids.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalLoginModel.java 2 files changed, 9 insertions(+), 1 deletion(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12526 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaf696b51159ba016d88124b789d5bbbab7b736fe Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: get LocalFSPath config value synchronously
by derez＠redhat.com 28 Feb '13

28 Feb '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: get LocalFSPath config value synchronously ...................................................................... webadmin: get LocalFSPath config value synchronously Replacing the asynchronous fetch of LocalFSPath configuration value with a synchronous one. Change-Id: I66d2dbd6c795466107a533ee5f0423a9c76b2565 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModel.java 3 files changed, 10 insertions(+), 42 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12511 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I66d2dbd6c795466107a533ee5f0423a9c76b2565 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: get HotPlugEnabled config value synchronously
by derez＠redhat.com 28 Feb '13

28 Feb '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: get HotPlugEnabled config value synchronously ...................................................................... webadmin: get HotPlugEnabled config value synchronously Replacing the asynchronous fetch of HotPlugEnabled configuration value with a synchronous one. Change-Id: I9f10f10bffbf79f7e282221e93de5be95385ba78 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmDiskListModel.java 2 files changed, 3 insertions(+), 22 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12510 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9f10f10bffbf79f7e282221e93de5be95385ba78 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: No exportable disk warning text fixed
by derez＠redhat.com 28 Feb '13

28 Feb '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: No exportable disk warning text fixed ...................................................................... webadmin: No exportable disk warning text fixed The warning for diskless VM rephrased (for VM export/template/snapshot dialogs). Change-Id: I4625f756eacc07c6aa58c12ac49b39b431330451 Bug-Url: https://bugzilla.redhat.com/855625 Signed-off-by: Libor Spevak <lspevak(a)redhat.com> --- M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Messages.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12525 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4625f756eacc07c6aa58c12ac49b39b431330451 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Libor Spevak <lspevak(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Libor Spevak <lspevak(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Make pinned to host error clearer.
by alkaplan＠redhat.com 28 Feb '13

28 Feb '13

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Make pinned to host error clearer. ...................................................................... webadmin: Make pinned to host error clearer. If there is an error when trying to run a vm that is pinned to a host, the displayed error message should be- - The specific reason why the vm cannot run. - Note: The VM is pinned to Host '${VdsName}' but cannot run on it. Change-Id: I1645a1dbe402c73c9e44545819368b01f00e3990 Bug-Url: https://bugzilla.redhat.com/878451 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsSelector.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 5 files changed, 7 insertions(+), 9 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12460 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1645a1dbe402c73c9e44545819368b01f00e3990 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal: quota used by graph doesn't get cleared
by gchaplik＠redhat.com 28 Feb '13

28 Feb '13

Gilad Chaplik has submitted this change and it was merged. Change subject: userportal: quota used by graph doesn't get cleared ...................................................................... userportal: quota used by graph doesn't get cleared There are 2 rulers in quota progress bar, one for 'all' and one for used by you; When 0% of quota is used, i.e. 'all' and 'by you' are 0%, one of the bars should be hidden, while the other one gets 100% width with 0%. Change-Id: Ic15b1ff6d0685b8c3752aa86429ab5802595f953 Bug-Url: https://bugzilla.redhat.com/908809 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/DoublePercentageProgressBar.java 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Doron Fediuck: Looks good to me, but someone else must approve Gilad Chaplik: Verified -- To view, visit http://gerrit.ovirt.org/12497 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic15b1ff6d0685b8c3752aa86429ab5802595f953 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0