- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: packaging: changed tasks polling in engine-upgrade
by juan.hernandez＠redhat.com 27 Feb '13

27 Feb '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: changed tasks polling in engine-upgrade ...................................................................... packaging: changed tasks polling in engine-upgrade Modified checkRunningTasks: during engine upgrade, sample the current situation of asynchronous tasks and compensations and continue the upgrade, exiting the check loop one second after there are no async tasks or compensations left. Currently the stopping of asynchronous tasks and compensations could take 3 minutes so every ~3 minutes (MAINTENANCE_TASKS_WAIT_PERIOD) if there are async tasks still around, allows the user to retry or abort. Other than that it doesn't change the behavior of the script. Removed MAINTENANCE_TASKS_CYCLES since it's not used anymore. Fixed a small typo in MSG_ERROR_FAILED_CONVERT_ENGINE_KEY. Change-Id: I32eaeb2427fcc9c4566ca12bf547d49a308a8937 Bug-Url: https://bugzilla.redhat.com/877749 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M packaging/fedora/setup/engine-upgrade.py 1 file changed, 23 insertions(+), 12 deletions(-) Approvals: Sandro Bonazzola: Verified Juan Hernandez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12177 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I32eaeb2427fcc9c4566ca12bf547d49a308a8937 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: LSM - standardize version checks in CDA
by amureini＠redhat.com 27 Feb '13

27 Feb '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: LSM - standardize version checks in CDA ...................................................................... core: LSM - standardize version checks in CDA Removed the canDoAction check that relies on the LiveMigrationEnabled config value and used the standard action_version_map instead. Change-Id: I3527c79ee77bc60c9ff7ca5030f3cd5f2ee28f39 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- A backend/manager/dbscripts/upgrade/03_02_0470_lsm_version_support.sql M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmDiskListModel.java 8 files changed, 15 insertions(+), 53 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12375 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3527c79ee77bc60c9ff7ca5030f3cd5f2ee28f39 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>

1 0

Change in ovirt-engine[master]: tools : Unable to add remote domain using engine-manage-doma...
by yzaslavs＠redhat.com 26 Feb '13

26 Feb '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: tools : Unable to add remote domain using engine-manage-domains ...................................................................... tools : Unable to add remote domain using engine-manage-domains When there is an error with engine config while adding a remote domain the toll does not log the error to the log file. This patch sets the default log level of engine config to DEBUG instead of OFF. This write the debug messages to the log file instead of supressing it. Change-Id: I8457b778274acabaab30b27b0605b8600e338873 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=912736 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/EngineConfig.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Ravi Nori: Verified Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12428 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8457b778274acabaab30b27b0605b8600e338873 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: fix IAE on run once dialog
by ofrenkel＠redhat.com 26 Feb '13

26 Feb '13

Omer Frenkel has submitted this change and it was merged. Change subject: webadmin: fix IAE on run once dialog ...................................................................... webadmin: fix IAE on run once dialog This patch fixes IllegalArgumentException that was thrown when trying to run-once a VM with no bootable device. Before change http://gerrit.ovirt.org/#/c/11735 the boot sequence that was generated when trying to run-once a VM was never empty - it always contained at least the hard-disk (even for diskless VM). After applying the change above, the returned boot sequence for a VM with no bootable device is empty, and wrong handling of the empty string that represents it results in IllegalArgumentException. Change-Id: I42197615331c6b62f5978e1d4546298aee617db4 Bug-Url: https://bugzilla.redhat.com/885994 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmOnceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmRunHandler.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/BootSequenceModel.java 3 files changed, 3 insertions(+), 7 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/12454 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I42197615331c6b62f5978e1d4546298aee617db4 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: Remove Module.resourcePath
by amureini＠redhat.com 26 Feb '13

26 Feb '13

Allon Mureinik has submitted this change and it was merged. Change subject: packaging: Remove Module.resourcePath ...................................................................... packaging: Remove Module.resourcePath The resourcePath member in Module is never initialized, and in fact, there is no way to initialize it - i.e., it is always null. This patch removes it and all references to it. Change-Id: I1ca9f1a35ffc461311e61e649fdf1a1375ffd0a7 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M build-tools-root/jboss-modules-maven-plugin/src/main/java/org/ovirt/engine/build/Module.java 1 file changed, 0 insertions(+), 4 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12337 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1ca9f1a35ffc461311e61e649fdf1a1375ffd0a7 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: simplify businessentity equals() methods [part 2]
by lhornyak＠redhat.com 26 Feb '13

26 Feb '13

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: simplify businessentity equals() methods [part 2] ...................................................................... core: simplify businessentity equals() methods [part 2] Instead of manually doing a null-safe comparison for each business entity, use ObjectUtils.objectsEqual(). Where applicable, optimize the order of comparison by looking at the id field first. The resulting code is more concise, easier to maintain, and doesn't mask errors due to missing braces like the previous code did. Change-Id: I8e77ebc95015105b54fbb09472e38a2d36492278 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/LUN_storage_server_connection_map.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/LUNs.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/LdapGroup.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/LunDisk.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Quota.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/QuotaStorage.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/QuotaVdsGroup.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Role.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/RoleGroupMap.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/RoleGroupMapId.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Snapshot.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomain.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomainDynamic.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomainStatic.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StoragePoolIsoMap.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StoragePoolIsoMapId.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/TagsUserGroupMap.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/TagsUserMap.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/TagsVdsMap.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/TagsVmMap.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/TagsVmPoolMap.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdcOption.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsDynamic.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsStatic.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsStatistics.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDevice.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDeviceId.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDynamic.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmGuestAgentInterface.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmPool.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmPoolMap.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmStatic.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmStatistics.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/permissions.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage_pool.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/tags.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/vds_spm_id_map.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/ObjectUtils.java M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/ObjectUtilsTest.java 41 files changed, 615 insertions(+), 1,746 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12416 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8e77ebc95015105b54fbb09472e38a2d36492278 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: cpu pinning visibility in vm dialog
by gchaplik＠redhat.com 26 Feb '13

26 Feb '13

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: cpu pinning visibility in vm dialog ...................................................................... webadmin: cpu pinning visibility in vm dialog Fix showing CPU pinning section when the VM: * Respective to CpuPinningEnabled, CpuPinMigrationEnabled * Pinned * Assigned to host & admin-migration & cpu-host are checked Change-Id: I7343e94f6133f0ad796b5446718af98dcd734c30 Bug-Url: https://bugzilla.redhat.com/867039 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java 2 files changed, 9 insertions(+), 4 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11972 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7343e94f6133f0ad796b5446718af98dcd734c30 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove unused entities
by tnisan＠redhat.com 26 Feb '13

26 Feb '13

Tal Nisan has submitted this change and it was merged. Change subject: core: Remove unused entities ...................................................................... core: Remove unused entities Change-Id: I916ff0ac4745d4f05811d4f0737f93d764620ebe Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/dbscripts/create_views.sql M backend/manager/dbscripts/event_sp.sql D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/event_subscriber_notification_methods.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/image_vm_map.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/image_vm_map_id.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/roles_actions.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage_pool_iso_map_id.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml 8 files changed, 0 insertions(+), 287 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12400 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I916ff0ac4745d4f05811d4f0737f93d764620ebe Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: Makefile: fix errors when running make install on ovirt-engi...
by juan.hernandez＠redhat.com 26 Feb '13

26 Feb '13

Juan Hernandez has submitted this change and it was merged. Change subject: Makefile: fix errors when running make install on ovirt-engine ...................................................................... Makefile: fix errors when running make install on ovirt-engine - running make install required interactive answer from user - added -f for forcing link creation Change-Id: I280a20a77ee3980437be3f3bca2f7bc9082d34c4 Signed-off-by: Eyal Edri <eedri(a)redhat.com> --- M Makefile 1 file changed, 8 insertions(+), 8 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12449 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I280a20a77ee3980437be3f3bca2f7bc9082d34c4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: VmRunHandler: simplify isInternal evaluation
by amureini＠redhat.com 26 Feb '13

26 Feb '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: VmRunHandler: simplify isInternal evaluation ...................................................................... core: VmRunHandler: simplify isInternal evaluation Some of the checks in VmRunHandler are only evaluated in the following condition: !vm.isAutoStartup() || !runParams.getIsInternal() && vm.isAutoStartup() Since java evaluated boolean conditions with short circuit logic, this can be simplified. The right hand of the || condition is only tested if !vm.isAutoStartup() evaluates to false, which means vm.isAutoStartup() evaluated to true - so there is no reason to test it again. The added readability is a bonus. Change-Id: I0aa0ce3b0ef22739014f31f4019a35b8d230aaee Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmRunHandler.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12248 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0aa0ce3b0ef22739014f31f4019a35b8d230aaee Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0