- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Remove unused action type enum values.
by mlipchuk＠redhat.com 27 Feb '13

27 Feb '13

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Remove unused action type enum values. ...................................................................... core: Remove unused action type enum values. The removed enums do not have any references, and could be deleted. Change-Id: I8b837f7ba89ba3d78968c9b0b308405f6d2d2dbe Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java 1 file changed, 0 insertions(+), 19 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11934 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8b837f7ba89ba3d78968c9b0b308405f6d2d2dbe Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Hot-unplug fails when unplug nic and changing MAC ad...
by alkaplan＠redhat.com 27 Feb '13

27 Feb '13

Alona Kaplan has submitted this change and it was merged. Change subject: engine: Hot-unplug fails when unplug nic and changing MAC address. ...................................................................... engine: Hot-unplug fails when unplug nic and changing MAC address. Hot-unplug fails when trying to unplug and change MAC address for nic under running VM. When unplugging a nic of a running vm- 1. The db is updated. 2. Unplug action is sent to the host. It means that the vdsm gets unplug with the new mac address (although the vnic is defined on the host with the old one). To solve this issue the old mac address should be sent to the vdsm. Change-Id: I185e5572501ea86443a93f4fdf309e0e05520646 Bug-Url: https://bugzilla.redhat.com/904840 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/AbstractVmInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/ActivateDeactivateVmNicCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/UpdateVmInterfaceCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ActivateDeactivateVmNicParameters.java 4 files changed, 26 insertions(+), 7 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12459 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I185e5572501ea86443a93f4fdf309e0e05520646 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>

1 0

Change in ovirt-engine[master]: ui: Use EnumTranslator for OS types tooltips
by rgolan＠redhat.com 27 Feb '13

27 Feb '13

Roy Golan has submitted this change and it was merged. Change subject: ui: Use EnumTranslator for OS types tooltips ...................................................................... ui: Use EnumTranslator for OS types tooltips Change-Id: I39d0e5437953d72e61f92a833a68aa297fdeed74 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/extended/SideTabExtendedVirtualMachineView.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12493 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I39d0e5437953d72e61f92a833a68aa297fdeed74 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: ui: use real OS names
by rgolan＠redhat.com 27 Feb '13

27 Feb '13

Roy Golan has submitted this change and it was merged. Change subject: ui: use real OS names ...................................................................... ui: use real OS names Change the operating system field type to EnumLabel which is being already translated to the real name according to Enum.properties resource file. Change-Id: I8fa85225c09fd6c00783507a8df4e96e66e87180 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=895609 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/basic/MainTabBasicDetailsView.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/basic/MainTabBasicDetailsView.ui.xml 2 files changed, 8 insertions(+), 15 deletions(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12475 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8fa85225c09fd6c00783507a8df4e96e66e87180 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: ui: Add images for Windows 8 and 2012
by rgolan＠redhat.com 27 Feb '13

27 Feb '13

Roy Golan has submitted this change and it was merged. Change subject: ui: Add images for Windows 8 and 2012 ...................................................................... ui: Add images for Windows 8 and 2012 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=895609 Change-Id: I984e126e85581cc35815cf523bbb1ba95055d3f5 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/ApplicationResourcesWithLookup.java A frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/userportal/images/os/Windows2012x64.png A frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/userportal/images/os/Windows8.png A frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/userportal/images/os/Windows8x64.png A frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/userportal/images/os/large/Windows2012x64.png A frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/userportal/images/os/large/Windows8.png A frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/userportal/images/os/large/Windows8x64.png 7 files changed, 18 insertions(+), 0 deletions(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12469 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I984e126e85581cc35815cf523bbb1ba95055d3f5 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Add message when template does not exists.
by mlipchuk＠redhat.com 27 Feb '13

27 Feb '13

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Add message when template does not exists. ...................................................................... core: Add message when template does not exists. If template does not exists when it is being edited we should return a CDA message which implies it. Change-Id: I1232c9bc9ef75610e58a31568f45fb0ea075088c Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10847 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1232c9bc9ef75610e58a31568f45fb0ea075088c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: backend: shorten message for PM test (#909891)
by yzaslavs＠redhat.com 27 Feb '13

27 Feb '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: backend: shorten message for PM test (#909891) ...................................................................... backend: shorten message for PM test (#909891) http://bugzilla.redhat.com/909891 Change-Id: I1d9736c64cffba817fbfea7caa51eb0d8820ec32 Signed-off-by: Alexey Chub <achub(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/FenceStatusReturnValue.java 1 file changed, 1 insertion(+), 5 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12392 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1d9736c64cffba817fbfea7caa51eb0d8820ec32 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexey Chub <achub(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: trace export template command by job status
by mpastern＠redhat.com 27 Feb '13

27 Feb '13

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: trace export template command by job status ...................................................................... restapi: trace export template command by job status This patch prevents a situation in which the REST reports that export template command was finished before the end-action event is added. This situation occured because the REST part monitored the command according to the statuses of its VDSM tasks - when they were done, it reports back to the user that the command has finished and gave him back the control (the command was invoked synchronously), sometimes before the engine managed to add the end-action event. This patch change the way the export template command is monitored by the REST to be according to the command's job status, that way we ensure that the end-action event is added before REST is reporting back to the user that the command is finished. Change-Id: I4442b337e0242aa756825243dbcf6db1a2b0559f Bug-Url: https://bugzilla.redhat.com/860194 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplateResource.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12432 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4442b337e0242aa756825243dbcf6db1a2b0559f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Refactor GlusterQueriesCommand Base
by sanjal＠redhat.com 27 Feb '13

27 Feb '13

Shireesh Anjal has submitted this change and it was merged. Change subject: engine: Refactor GlusterQueriesCommand Base ...................................................................... engine: Refactor GlusterQueriesCommand Base Introducting runVdsCommand() in the GlusterQueriesCommandBase and refactored GetGlusterVolumeProfileInfoQuery, GetGlusterVolumeOptionsInfoQuery and GetGlusterVolumeAdvancedDetailsQuery Moving this change to separate patch(from Gluster Hooks patch) - also removed reference to GlusterHooksDao Change-Id: If73701b7756de155c4917944ed43517e53f9b4e6 Signed-off-by: Sahina Bose <sahina(a)gmail.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeAdvancedDetailsQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeOptionsInfoQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeProfileInfoQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterQueriesCommandBase.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeAdvancedDetailsQueryTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeOptionsInfoQueryTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeProfileInfoQueryTest.java 7 files changed, 32 insertions(+), 29 deletions(-) Approvals: Shireesh Anjal: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12398 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If73701b7756de155c4917944ed43517e53f9b4e6 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Move fkvalidator.sh to tools/dbutils
by yzaslavs＠redhat.com 27 Feb '13

27 Feb '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Move fkvalidator.sh to tools/dbutils ...................................................................... core: Move fkvalidator.sh to tools/dbutils fkvalidator uses SPs that should also be moved to the tools/dbscripts directory. Since the fkvalidator is used from the installer in the pre-upgrade step, it will fail if those SPs are not found. Change-Id: Ib4211b8ff2ab00c85d9f73bb4e7338324017878a Signed-off-by: Eli Mesika <emesika(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=912305 --- M backend/manager/dbscripts/common_sp.sql M backend/manager/tools/dbutils/fkvalidator.sh A backend/manager/tools/dbutils/fkvalidator_sp.sql 3 files changed, 56 insertions(+), 54 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12492 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib4211b8ff2ab00c85d9f73bb4e7338324017878a Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0