- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: VmRunHandler: correct check for disk images
by amureini＠redhat.com 26 Feb '13

26 Feb '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: VmRunHandler: correct check for disk images ...................................................................... core: VmRunHandler: correct check for disk images VmRunHandler has a series of checks on VM images - these checks should only be performed if the VM has image based disks, not disks in general (which could be LUN disks). Change-Id: Ib47cf77154a5e46af23a10550884bbd6cdeecb30 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmRunHandler.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RunVmCommandTest.java 2 files changed, 5 insertions(+), 4 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12247 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib47cf77154a5e46af23a10550884bbd6cdeecb30 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: VmRunHandler: snapshot check on diskless VMs
by amureini＠redhat.com 26 Feb '13

26 Feb '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: VmRunHandler: snapshot check on diskless VMs ...................................................................... core: VmRunHandler: snapshot check on diskless VMs Since oVirt 3.1 supports snapshoting a diskless VM, VmRunHandler should make sure a VM is not locked or during a snapshot when attempting to run it even if it doesn't have any disks. Change-Id: I232971b0d92aed1266d51ef89b2ae8175f08fbb2 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmRunHandler.java 1 file changed, 22 insertions(+), 18 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12246 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I232971b0d92aed1266d51ef89b2ae8175f08fbb2 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: use slf4j-jdk14 1.5.6
by amureini＠redhat.com 26 Feb '13

26 Feb '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: use slf4j-jdk14 1.5.6 ...................................................................... core: use slf4j-jdk14 1.5.6 Downgraded slf4j-jdk14 to be compatible with log4j 1.2.16 that we use in the project. Change-Id: I0b3d1363da413881ee1aa89738dd8d7ea6ac52c5 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M pom.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12110 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0b3d1363da413881ee1aa89738dd8d7ea6ac52c5 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove rmw-war
by juan.hernandez＠redhat.com 26 Feb '13

26 Feb '13

Juan Hernandez has submitted this change and it was merged. Change subject: core: Remove rmw-war ...................................................................... core: Remove rmw-war This war, located in the frontend, contains a few servlts that are in fact more related to the backend, and it doesn't grant the existence of a different module and .war file. This patch moves all the content to the root web application. As the URLs don't change there is no impact outside of the engine. Change-Id: I1b5a292cb28cbc460cf45a9595bddd7ebb824857 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/root/pom.xml R backend/manager/modules/root/src/main/java/org/ovirt/engine/core/redirect/RedirectServlet.java R backend/manager/modules/root/src/main/java/org/ovirt/engine/core/register/RegisterServlet.java A backend/manager/modules/root/src/main/java/org/ovirt/engine/core/status/HealthStatus.java R backend/manager/modules/root/src/main/java/org/ovirt/engine/core/validate/ValidateSession.java M backend/manager/modules/root/src/main/webapp/WEB-INF/web.xml M ear/pom.xml M frontend/pom.xml D frontend/wars/pom.xml D frontend/wars/rmw-war/pom.xml D frontend/wars/rmw-war/src/main/java/org/ovirt/engine/core/status/HealthStatus.java D frontend/wars/rmw-war/src/main/webapp/WEB-INF/web.xml M packaging/fedora/spec/ovirt-engine.spec.in 13 files changed, 143 insertions(+), 259 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11324 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1b5a292cb28cbc460cf45a9595bddd7ebb824857 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove StringCompatTest
by amureini＠redhat.com 26 Feb '13

26 Feb '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove StringCompatTest ...................................................................... core: Remove StringCompatTest StringCompatTest did not in fact test StringCompat (which was already removed), but StringHelper's join method. This method is already thoroughly tested in StringHelperTest, so this test is redundant and can be removed. Change-Id: I9fc6ec3759f661e4da54957a2140a4d975cf9546 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- D backend/manager/modules/compat/src/test/java/org/ovirt/engine/core/compat/StringCompatTest.java 1 file changed, 0 insertions(+), 11 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12423 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9fc6ec3759f661e4da54957a2140a4d975cf9546 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove the Helper class
by amureini＠redhat.com 26 Feb '13

26 Feb '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove the Helper class ...................................................................... core: Remove the Helper class org.ovirt.engine.core.utils.Helper had only one method, ToList, which was, in fact, just creating a new ArrayList around a given iterable. This patch removes this useless class, and just calls ArrayList's constructor instead. Change-Id: I2563766d08aeece478ac7659103f26f19b90deb3 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java D backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/Helper.java 2 files changed, 3 insertions(+), 14 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12422 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2563766d08aeece478ac7659103f26f19b90deb3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: remove read lock of template while creating VM from it
by mkublin＠redhat.com 26 Feb '13

26 Feb '13

Michael Kublin has submitted this change and it was merged. Change subject: core: remove read lock of template while creating VM from it ...................................................................... core: remove read lock of template while creating VM from it This patch is using the new mechanism that let us run commands without release their lock at the end of the sync execution part, in order to remove the unnecessary read lock of template while we create VM that is based on this template. so with this patch, it is now possible to create multiple VMs that are based on the same template with preallocated disks in parallel, which wasn't possible before. The AddVmFromTemplate command was modified in such a way that it won't lock the template in the DB. instead, we take a shared-lock for the whole execution process (sync + async, until the command is finished). The call to "freeLock" in AddVmCommand#executeVmCommand was also removed, so that the shared lock would not be released. it seems that this call was not required for the AddVmCommand (because it is set to release the lock at the end of this method anyway) and not for the commands that inherit it. Change-Id: If1b74347110c468b90e75b4dc6470595576f94f4 Bug-Url: https://bugzilla.redhat.com/815642 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromTemplateCommand.java 2 files changed, 3 insertions(+), 17 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12407 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If1b74347110c468b90e75b4dc6470595576f94f4 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-reports[master]: reports: made tooltip clearer in ccp report (#913081)
by ydary＠redhat.com 26 Feb '13

26 Feb '13

Yaniv Dary has submitted this change and it was merged. Change subject: reports: made tooltip clearer in ccp report (#913081) ...................................................................... reports: made tooltip clearer in ccp report (#913081) uptime and existence now have tooltip in the format: 'DDd HHh MMm' (upper case letters is the actual data) Bug-Url: https://bugzilla.redhat.com/913081 Change-Id: I3505c6c3c0d8e6dc353d07007bb197a30890c0c3 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M reports/repository_files/resources/Reports/Inventory/ccp_vm_inventory_br44_files/ccp_vm_inventory_br44_jrxml.data 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12446 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3505c6c3c0d8e6dc353d07007bb197a30890c0c3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Upgrade maven-checkstyle-plugin to 2.9.1
by dfediuck＠redhat.com 26 Feb '13

26 Feb '13

Doron Fediuck has submitted this change and it was merged. Change subject: core: Upgrade maven-checkstyle-plugin to 2.9.1 ...................................................................... core: Upgrade maven-checkstyle-plugin to 2.9.1 Upgraded maven-checkstyle-plugin to 2.9.1 in order to facilitate a future move to Java 7. This version of maven-checkstyle-plugin requires a higher version of checkstyle, so it was upgraded too, to 5.4. Change-Id: Icccfb347a27ed0f2ff9a706d42b31f6a9d102fce Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M build-tools-root/ovirt-checkstyle-extension/pom.xml M pom.xml 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: Doron Fediuck: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9771 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icccfb347a27ed0f2ff9a706d42b31f6a9d102fce Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Small code improvement at VdsEventListener.vdsUpEven...
by mkublin＠redhat.com 26 Feb '13

26 Feb '13

Michael Kublin has submitted this change and it was merged. Change subject: engine: Small code improvement at VdsEventListener.vdsUpEvent ...................................................................... engine: Small code improvement at VdsEventListener.vdsUpEvent No reason to create a MultipleActionRunner when there are no vms Change-Id: I66e1db82357a0b0cfc3260dc6aaf27ae51d3b803 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java 1 file changed, 20 insertions(+), 15 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12022 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I66e1db82357a0b0cfc3260dc6aaf27ae51d3b803 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0