- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: packaging: Don't resolve plugins
by juan.hernandez＠redhat.com 25 Feb '13

25 Feb '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: Don't resolve plugins ...................................................................... packaging: Don't resolve plugins Now that we have a plugin in the project that is required for the build (the jboss modules plugin) this will always fail in the first build. Change-Id: I9667a5d3dc416cd46ff8fb5b08f74baddab86d50 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M Makefile 1 file changed, 0 insertions(+), 4 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12239 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9667a5d3dc416cd46ff8fb5b08f74baddab86d50 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Fix broken bll unit test
by amureini＠redhat.com 25 Feb '13

25 Feb '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Fix broken bll unit test ...................................................................... core: Fix broken bll unit test An error was introduced due to usage of AsyncTaskDao.getAll in the CTOR of the AsyncTaskManager sinleton The following patch uses mocking to create mocked data source + mocked db facade to handle the error. Change-Id: If70f5da87e1238f0a545496d6e9700151275d642 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/BackwardCompatibilityTaskCreationTest.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacadeLocator.java 2 files changed, 27 insertions(+), 4 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12385 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If70f5da87e1238f0a545496d6e9700151275d642 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Removal of @override annotation
by amureini＠redhat.com 25 Feb '13

25 Feb '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Removal of @override annotation ...................................................................... core: Removal of @override annotation This removes an @override annotation which breaks compatbility with open jdk6. Change-Id: I486b521252abcca77fea54fe6dd0dbc1f72590c2 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/tools/src/main/java/org/ovirt/engine/core/tools/common/db/StandaloneDataSource.java 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12388 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I486b521252abcca77fea54fe6dd0dbc1f72590c2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: tool-tip for DirectLUN disk column
by derez＠redhat.com 24 Feb '13

24 Feb '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: tool-tip for DirectLUN disk column ...................................................................... webadmin: tool-tip for DirectLUN disk column Added a tool-tip for DirectLUN disk column (for each item). Affected tabs: Disks main-tab and VM -> Disks sub-tab ('All' view). Change-Id: I939fb57ca024baba86090b9b1840b62a1425dc66 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/disks/DisksViewColumns.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12378 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I939fb57ca024baba86090b9b1840b62a1425dc66 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Storage tabs - move description column
by derez＠redhat.com 24 Feb '13

24 Feb '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Storage tabs - move description column ...................................................................... webadmin: Storage tabs - move description column For keeping the convention on other tabs: * move description column to the right. * rename 'Domain Description' to 'Description'. Change-Id: Idbdac003253f15f8806c465980b29f059e5d09b4 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabStorageView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/datacenter/SubTabDataCenterStorageView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/disk/SubTabDiskStorageView.java 4 files changed, 30 insertions(+), 30 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12377 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idbdac003253f15f8806c465980b29f059e5d09b4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: storage tab - remove redundant name column
by derez＠redhat.com 24 Feb '13

24 Feb '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: storage tab - remove redundant name column ...................................................................... webadmin: storage tab - remove redundant name column Remove redundant Domain Name column from Storage main-tab. Change-Id: I09bdc4192877f4484feb0a21ac8e87a022469b1e Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabStorageView.java 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12376 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I09bdc4192877f4484feb0a21ac8e87a022469b1e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-reports[master]: reports: fixed time missing in br45 (#910778)
by ydary＠redhat.com 24 Feb '13

24 Feb '13

Yaniv Dary has submitted this change and it was merged. Change subject: reports: fixed time missing in br45 (#910778) ...................................................................... reports: fixed time missing in br45 (#910778) Bug-Url: https://bugzilla.redhat.com/910778 Change-Id: I653956a70b4d27997b543c8dff2fe98384ba0a06 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M reports/repository_files/resources/Reports/users_usage/users_spice_sessions_activity_br45_files/users_spice_sessions_activity_br45_jrxml.data 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12383 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I653956a70b4d27997b543c8dff2fe98384ba0a06 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-reports[master]: reports: fixed input controls entities selection (#910778)
by ydary＠redhat.com 24 Feb '13

24 Feb '13

Yaniv Dary has submitted this change and it was merged. Change subject: reports: fixed input controls entities selection (#910778) ...................................................................... reports: fixed input controls entities selection (#910778) Bug-Url: https://bugzilla.redhat.com/910778 Change-Id: Id58c2286f2ca26ccf5cfdf72c033b73935cbe20b Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M reports/repository_files/resources/reports_resources/JDBC/Input_Controls/Period_Affected/single_select/cluster_ic/all_cluster_with_vms/P_Cluster_ID.xml M reports/repository_files/resources/reports_resources/JDBC/Input_Controls/Period_Affected/single_select/cluster_ic/all_clusters_with_hosts/P_Cluster_ID.xml M reports/repository_files/resources/reports_resources/JDBC/Input_Controls/Period_Affected/single_select/datacenter_ic/all_dcs_with_entities/P_DataCenter_ID.xml M reports/repository_files/resources/reports_resources/JDBC/Input_Controls/Period_Affected/single_select/datacenter_ic/all_dcs_with_hosts/P_DataCenter_ID.xml M reports/repository_files/resources/reports_resources/JDBC/Input_Controls/Period_Affected/single_select/datacenter_ic/all_dcs_with_storage/P_DataCenter_ID.xml M reports/repository_files/resources/reports_resources/JDBC/Input_Controls/Period_Affected/single_select/datacenter_ic/all_dcs_with_vms/P_DataCenter_ID.xml M reports/repository_files/resources/reports_resources/JDBC/Input_Controls/Period_Affected/single_select/host_ic/Hosts_List.xml M reports/repository_files/resources/reports_resources/JDBC/Input_Controls/Period_Affected/single_select/host_ic/P_Host_Type.xml M reports/repository_files/resources/reports_resources/JDBC/Input_Controls/Period_Affected/single_select/storage_ic/P_StorageDomain_ID.xml M reports/repository_files/resources/reports_resources/JDBC/Input_Controls/Period_Affected/single_select/storage_ic/P_Storage_Type.xml M reports/repository_files/resources/reports_resources/JDBC/Input_Controls/Period_Affected/single_select/vm_ic/P_VM_Type.xml M reports/repository_files/resources/reports_resources/JDBC/Input_Controls/Period_Affected/single_select/vm_ic/VM_List.xml 12 files changed, 40 insertions(+), 240 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12382 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id58c2286f2ca26ccf5cfdf72c033b73935cbe20b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Move lock RunVmCommand -> RunVmCommandBase
by amureini＠redhat.com 24 Feb '13

24 Feb '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Move lock RunVmCommand -> RunVmCommandBase ...................................................................... core: Move lock RunVmCommand -> RunVmCommandBase Move RunVmCommand's exclusive lock up to its ancestor, RunVmCommandBase. RunVmCommand and all it's extending classes' locking will remain unchanged (as they inherit the lock from RunVmCommandBase), and the migration flows will also benefit from the lock. This is done in order to solve a race in virt/storage migration flows, like the bug mentioned below, and makes sense regardless - you can't start running a VM, e.g., if it's in the middle of migrating to another host. Change-Id: I8cbea4ae3a8bc47b4bbc451d8ecd3080287a3df0 Bug-Url: https://bugzilla.redhat.com/878131 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java 2 files changed, 12 insertions(+), 10 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12315 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8cbea4ae3a8bc47b4bbc451d8ecd3080287a3df0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine-sdk-java[master]: sdk: prepare for the next development iteration
by mpastern＠redhat.com 24 Feb '13

24 Feb '13

Michael Pasternak has submitted this change and it was merged. Change subject: sdk: prepare for the next development iteration ...................................................................... sdk: prepare for the next development iteration Change-Id: Ibe4419bb5b34d9654d4e0f1c5a7db2f04adeafd4 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M ovirt-engine-sdk-java/pom.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12373 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibe4419bb5b34d9654d4e0f1c5a7db2f04adeafd4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0