- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Clean "only in db" async tasks
by yzaslavs＠redhat.com 24 Feb '13

24 Feb '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Clean "only in db" async tasks ...................................................................... core: Clean "only in db" async tasks When system restarts, storagePoolUp event is sent per each SPM that becomes up. We query the SPM and get its tasks. If we had tasks in DB, that did not exist in SPM, we will remove them from DB. This is an alternative to previous versions of this patch, in which I introduced zombie treatment for these tasks. Change-Id: Ie13ae21eaadb1bb621a7fc8ad471e60387a3699b Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AsyncTaskManager.java 1 file changed, 35 insertions(+), 4 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12055 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie13ae21eaadb1bb621a7fc8ad471e60387a3699b Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: Add detailed note to user when password validation fails by ...
by yzaslavs＠redhat.com 24 Feb '13

24 Feb '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: Add detailed note to user when password validation fails by using engine-config ...................................................................... Add detailed note to user when password validation fails by using engine-config Change-Id: I7ae53d9b19f1b09990cf540d56e648698a00233d Bug-Id: https://bugzilla.redhat.com/show_bug.cgi?id=893682 Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com> --- M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/entity/helper/PasswordValueHelper.java M backend/manager/tools/src/main/shell/engine-config.sh 2 files changed, 14 insertions(+), 3 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12153 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7ae53d9b19f1b09990cf540d56e648698a00233d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Stephen Gordon <sgordon(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>

1 0

Change in ovirt-engine-sdk-java[master]: sdk: release 1.0.0.4-1
by mpastern＠redhat.com 24 Feb '13

24 Feb '13

Michael Pasternak has submitted this change and it was merged. Change subject: sdk: release 1.0.0.4-1 ...................................................................... sdk: release 1.0.0.4-1 - implement SSL support (without host verification) - implement shutdown() to deallocate system resources - to cluster added tunnel_migration property - to DataCenter added Clusters sub-collection - to root collection resource Disk added Permissions sub-collectio - to root collection resource Disk added Statistic sub-collection - host can be attached to cluster now either by id or name - to StorageDomainTemplate added Disks sub-collection - to StorageDomainVM added Disks sub-collection - to template.display added keyboard_layout property - to template added tunnel_migration property - to vm.display added keyboard_layout property - to vm added tunnel_migration property - to VMSnapshot added preview method - to VMSnapshot added undo method - to VMSnapshot added commit method Change-Id: Id12cc90a93922d55bc28c627a65c87898e66bbc1 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M ovirt-engine-sdk-java/pom.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12371 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id12cc90a93922d55bc28c627a65c87898e66bbc1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Add details to general Cluster sub-tab
by alkaplan＠redhat.com 24 Feb '13

24 Feb '13

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Add details to general Cluster sub-tab ...................................................................... webadmin: Add details to general Cluster sub-tab Added some information about the selected Cluster to sub-tab 'General' under the main-tab Cluster. Change-Id: I9933cd4ec03a3df35dc4ff8fa157854b776a632c Signed-off-by: Ofri Masad <omasad(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/FormItemWithDefaultValue.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/GeneralFormPanel.ui.xml A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/label/ClusterTypeLabel.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/label/ResiliencePolicyLabel.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/renderer/ClusterTypeRenderer.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterGeneralModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/ClusterGeneralModelForm.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/SubTabClusterGeneralView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/SubTabClusterGeneralView.ui.xml 11 files changed, 434 insertions(+), 91 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11726 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9933cd4ec03a3df35dc4ff8fa157854b776a632c Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <omasad(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: GetDiskByDiskId query support for user-level API
by oourfali＠redhat.com 24 Feb '13

24 Feb '13

Oved Ourfali has submitted this change and it was merged. Change subject: GetDiskByDiskId query support for user-level API ...................................................................... GetDiskByDiskId query support for user-level API This patch adds support for the GetDiskByDiskId query for the user-level API. Change-Id: I83c873f3f427c10d8d9b56279c7b0a46299db287 Bug-Url: https://bugzilla.redhat.com/910092 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M backend/manager/dbscripts/all_disks_sp.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetDiskByDiskIdQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskDaoDbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DiskDaoTest.java 6 files changed, 72 insertions(+), 22 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12290 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I83c873f3f427c10d8d9b56279c7b0a46299db287 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: create cluster hangs
by yzaslavs＠redhat.com 24 Feb '13

24 Feb '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: webadmin: create cluster hangs ...................................................................... webadmin: create cluster hangs Change-Id: I97ac6720a8115142bb041a3e6ecec549f75372d9 Bug-Url: https://bugzilla.redhat.com/880111 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterGuideModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterGuideModel.java 2 files changed, 8 insertions(+), 4 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11507 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I97ac6720a8115142bb041a3e6ecec549f75372d9 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin, userportal: fix Events tabs sorting
by yzaslavs＠redhat.com 24 Feb '13

24 Feb '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: webadmin,userportal: fix Events tabs sorting ...................................................................... webadmin,userportal: fix Events tabs sorting As a result of commit 2c5d00aac4f588260bb36f7a28d7be5e856a8474 the webadmin gets stuck (must be refreshed) when trying to navigate back from any events tab/sub-tab. The problem is that the method setItems is updated with null when switching tabs - causing a NPE in the sort method. The method setItems is actually redundant in EventListModel and should be added instead to UserPortalVmEventListModel and UserPortalTemplateEventListModel. EventListModel -> SyncSearch calls setItems with an empty list. It uses the refreshModel method for fetching events and UpdateItems for reverse sorting them; i.e. the sorting in setItems is effective only for classes that override the refreshModel method. Therefore, moved the sorting to these classes and added the nullity check. [ToDo: the reverse sorting in EventListModel -> UpdateItems should probably be re-factored in a way that allows sorting for all inherited classes without overrides...] Change-Id: Ibefebeea4dd804f6f930ed61e5899fe460996a70 RelatedTo-Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=907421 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/events/EventListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/UserPortalTemplateEventListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UserPortalVmEventListModel.java 3 files changed, 27 insertions(+), 10 deletions(-) Approvals: Gilad Chaplik: Looks good to me, approved Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12367 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibefebeea4dd804f6f930ed61e5899fe460996a70 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine-cli[master]: cli: collection-based-options could be passed in 2 ways(#859...
by mpastern＠redhat.com 24 Feb '13

24 Feb '13

Michael Pasternak has submitted this change and it was merged. Change subject: cli: collection-based-options could be passed in 2 ways(#859684) ...................................................................... cli: collection-based-options could be passed in 2 ways(#859684) Collection based options can be passwd without the xml type prefix. Both boot.dev=hd and dev=hd as value for --os-boot work. Only the first one bood.dev=hd is a valid value for the option --os-boot. Change-Id: Ic20ec38e3d08061dd33dd81b8d4b49cb1f5c2b79 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=859684 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M src/ovirtcli/command/command.py 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12324 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic20ec38e3d08061dd33dd81b8d4b49cb1f5c2b79 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine-cli[master]: cli: make NO_SUCH_ACTION error a bit more clear
by mpastern＠redhat.com 24 Feb '13

24 Feb '13

Michael Pasternak has submitted this change and it was merged. Change subject: cli: make NO_SUCH_ACTION error a bit more clear ...................................................................... cli: make NO_SUCH_ACTION error a bit more clear Change-Id: If1c49aa0fd9e3a86477930c4f1c3816dac4ef903 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M src/cli/messages.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12345 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If1c49aa0fd9e3a86477930c4f1c3816dac4ef903 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Rename OvfWriterTest to OvfManagerTest
by amureini＠redhat.com 24 Feb '13

24 Feb '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Rename OvfWriterTest to OvfManagerTest ...................................................................... core: Rename OvfWriterTest to OvfManagerTest Change-Id I9b5132300fb1f1fd94f771cab15efe5246dbeca8 add a bunch of tests related to templates to this class, making the name OvfVmriterTest incorrect. This patch renames the test to OvfManagerTest, to better reflect what it does. Change-Id: I190cba03c06da688b18cc31dd65992c6d2817399 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- R backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ovf/OvfManagerTest.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12359 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I190cba03c06da688b18cc31dd65992c6d2817399 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0