- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: Limit selection of datacenters in new quota
by gchaplik＠redhat.com 25 Feb '13

25 Feb '13

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Limit selection of datacenters in new quota ...................................................................... webadmin: Limit selection of datacenters in new quota when creating new quota from the datacenter_quota subtab only the selected datacenter should be an option for the created quota and fixed a possible null pionter exception in a certain race conditions Change-Id: I81c6d13e6ddb704c85593d8ffec317e40a3d3a86 Bug-Url: https://bugzilla.redhat.com/911241 Signed-off-by: Noam Slomianko <nslomian(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterQuotaListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/quota/QuotaListModel.java 2 files changed, 48 insertions(+), 25 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12287 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I81c6d13e6ddb704c85593d8ffec317e40a3d3a86 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Noam Slomianko <nslomian(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Noam Slomianko <nslomian(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Fix quota calculation for floating disks
by dfediuck＠redhat.com 25 Feb '13

25 Feb '13

Doron Fediuck has submitted this change and it was merged. Change subject: core: Fix quota calculation for floating disks ...................................................................... core: Fix quota calculation for floating disks Disk which are not connected to a VM are not counted when calculating storage quota. The DB script was updated to include also disks which are not connected to a VM. Change-Id: I0da0a2535897076c4512384e65c0aea5ce28a0df Bug-Url: https://bugzilla.redhat.com/913408 Signed-off-by: Ofri Masad <omasad(a)redhat.com> --- M backend/manager/dbscripts/create_functions.sql 1 file changed, 1 insertion(+), 3 deletions(-) Approvals: Doron Fediuck: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12269 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0da0a2535897076c4512384e65c0aea5ce28a0df Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <omasad(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Fix sql syntax for quota
by dfediuck＠redhat.com 25 Feb '13

25 Feb '13

Doron Fediuck has submitted this change and it was merged. Change subject: core: Fix sql syntax for quota ...................................................................... core: Fix sql syntax for quota calculateAllVdsGroupUsage function was fixed to be compatible with lower postgres versions (verified on version 8.4.13) Change-Id: I9eed6757ac4a9ed891792929be902aa628d62f59 Bug-Url: https://bugzilla.redhat.com/905891 Signed-off-by: Ofri Masad <omasad(a)redhat.com> --- M backend/manager/dbscripts/create_functions.sql 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Doron Fediuck: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12289 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9eed6757ac4a9ed891792929be902aa628d62f59 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <omasad(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: Use context classloader from YAML
by mpastern＠redhat.com 25 Feb '13

25 Feb '13

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: Use context classloader from YAML ...................................................................... restapi: Use context classloader from YAML The YAML library that we use to build load the RSDL metadata assumes that it can load classes using from its own class loader, and this is incorrect, specially now the the library is loaded from a JBoss module. The correct way to load classes is to use the context class loader, so it will work regardless of where in the application the classes are located. Change-Id: Ie86d591a0ce71b9984fa9c76ee42de67dce2ae4e Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/rsdl/RsdlBuilder.java M backend/manager/modules/restapi/webapp/pom.xml A backend/manager/modules/restapi/webapp/src/main/resources/META-INF/MANIFEST.MF 3 files changed, 13 insertions(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12390 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie86d591a0ce71b9984fa9c76ee42de67dce2ae4e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Fixing HibernateVm when one of the storage domain is...
by ofrenkel＠redhat.com 25 Feb '13

25 Feb '13

Omer Frenkel has submitted this change and it was merged. Change subject: engine: Fixing HibernateVm when one of the storage domain is not active ...................................................................... engine: Fixing HibernateVm when one of the storage domain is not active The bug is simple we can choose storage domain which is not Active at getStorageDomainId. After that a wrong storgae domain id will be send during hibernate vm and operation will fail Change-Id: I3c381c54eaa3cc874c3c918b4a9da7bf6ef241f5 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HibernateVmCommand.java 1 file changed, 6 insertions(+), 6 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12393 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3c381c54eaa3cc874c3c918b4a9da7bf6ef241f5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>

1 0

Change in ovirt-engine[master]: tools: Added SpiceProxyDefault property to vdc_options
by tjelinek＠redhat.com 25 Feb '13

25 Feb '13

Tomas Jelinek has submitted this change and it was merged. Change subject: tools: Added SpiceProxyDefault property to vdc_options ...................................................................... tools: Added SpiceProxyDefault property to vdc_options The value of SpiceProxyDefault is in form of [protocol://]<host>[:port] and will be used in FE to fill into the spice client Change-Id: Ie5521021fc6d826e8f70706e4eb7e971339e8e56 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/tools/src/main/conf/engine-config.properties 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12092 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie5521021fc6d826e8f70706e4eb7e971339e8e56 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin, userportal: set up Proxy property to SPICE
by tjelinek＠redhat.com 25 Feb '13

25 Feb '13

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin,userportal: set up Proxy property to SPICE ...................................................................... webadmin,userportal: set up Proxy property to SPICE This patch reads the SpiceProxyDefault property from vdc_options and sets it to the Proxy property of SPICE client(both cab and xpi). If the SpiceProxy is not set then nothing is set to the client. Change-Id: If269869413eae577fb243bffe849548f90ff8f4a Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/SpiceInterfaceImpl.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ISpice.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SpiceConsoleModel.java 3 files changed, 30 insertions(+), 3 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12093 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If269869413eae577fb243bffe849548f90ff8f4a Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: core : ImportVm with snapshots without collapse - not all di...
by amureini＠redhat.com 25 Feb '13

25 Feb '13

Allon Mureinik has submitted this change and it was merged. Change subject: core : ImportVm with snapshots without collapse - not all disks are copied ...................................................................... core : ImportVm with snapshots without collapse - not all disks are copied When importing a vmlists of disk ids and image ids are being populated in order to be used when creating the parameters for MoveOrCopyImageGroupCommand. When vm has snapshots, vm.getImages() returnes the DiskImage instances of all the disks snapshots as well - that caused that when importing the vm that has snapshots without collapse, same disk id was added few times to the disk's id list. When creating the tasks for copying the disks, the iteration is according to the disk count, meaning that possibly we will execute copy of the same image group while other image groups won't be copied at all - which will cause that the imported vm will have only some of it's disks. the proposed fix adds only the disk id\image of the leaf disk, so duplicate id's won't be added. Change-Id: Ib850d2d22ea6acb37320ad2b1bd6c571e1048faa Bug-Url: https://bugzilla.redhat.com/912697 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12297 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib850d2d22ea6acb37320ad2b1bd6c571e1048faa Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Paikov <paikov(a)gmail.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: Updated 'nfs exports' step alignment in cleanup
by juan.hernandez＠redhat.com 25 Feb '13

25 Feb '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: Updated 'nfs exports' step alignment in cleanup ...................................................................... packaging: Updated 'nfs exports' step alignment in cleanup Change-Id: I06d36c964a6b8125982ce85328c52f603c227245 Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M packaging/fedora/setup/engine-cleanup.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12384 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I06d36c964a6b8125982ce85328c52f603c227245 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: changed psql execution environment
by juan.hernandez＠redhat.com 25 Feb '13

25 Feb '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: changed psql execution environment ...................................................................... packaging: changed psql execution environment Added LC_ALL=C in the environment provided by getPgPassEnv used whenever psql is called. Renamed getPgPassEnv to getPgEnv and added the documentation. Change-Id: I24869748184d9397192461fa01da632a558208f7 Bug-Url: https://bugzilla.redhat.com/912426 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M packaging/fedora/setup/common_utils.py M packaging/fedora/setup/engine-cleanup.py M packaging/fedora/setup/engine-setup.py M packaging/fedora/setup/engine-upgrade.py 4 files changed, 19 insertions(+), 16 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12227 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I24869748184d9397192461fa01da632a558208f7 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0