- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Changes to MockEJBStrategyRule
by yzaslavs＠redhat.com 20 Feb '13

20 Feb '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Changes to MockEJBStrategyRule ...................................................................... core: Changes to MockEJBStrategyRule The following patch introduces the following changes: 1. Gives the ability to allow to mock a managed resource, not just a bean 2. mockBean should actually use Mocikto to define the actual mock using when..thenReturn as the "startingMethod" was not aware to that bean when it was called Change-Id: Ia23cbe33abe5a080cd599c6af468e3ce728c190a Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/MockEJBStrategyRule.java 1 file changed, 24 insertions(+), 2 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12186 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia23cbe33abe5a080cd599c6af468e3ce728c190a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: Updated getEngineVersion functionality
by juan.hernandez＠redhat.com 19 Feb '13

19 Feb '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: Updated getEngineVersion functionality ...................................................................... packaging: Updated getEngineVersion functionality If we use the getEngineVersion code on upgrades from versions where the version file does not exist, we will experience an error with opening the version file. This patch tries to solve it by checking the presence of the version file. If the file doesn't exist it will use the getRpmVersion function to fetch the real version of the engine package from the rpm. Change-Id: I57c62cf64d0c44f824a8ec5071f2ef50ec97854e Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M packaging/fedora/setup/common_utils.py 1 file changed, 6 insertions(+), 2 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12211 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I57c62cf64d0c44f824a8ec5071f2ef50ec97854e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: add qouta mode check in consume storage
by dfediuck＠redhat.com 19 Feb '13

19 Feb '13

Doron Fediuck has submitted this change and it was merged. Change subject: engine: add qouta mode check in consume storage ...................................................................... engine: add qouta mode check in consume storage Problem: When qouta mode is set to audit, error "no qouta" on storage was returned Solution: In checkConsumptionForSpecificStorageQuota we did not make sure that qouta was set to enforce before returning an error. Change-Id: I21cc59098ede7044ebde1d544e295300d8b40cb7 Bug-Url: https://bugzilla.redhat.com/906485 Signed-off-by: Noam Slomianko <nslomian(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaManager.java 1 file changed, 8 insertions(+), 4 deletions(-) Approvals: Doron Fediuck: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12049 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I21cc59098ede7044ebde1d544e295300d8b40cb7 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Noam Slomianko <nslomian(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Noam Slomianko <nslomian(a)redhat.com> Gerrit-Reviewer: liron aravot <liron.aravot(a)gmail.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal : Events sorting - oldest first
by gchaplik＠redhat.com 19 Feb '13

19 Feb '13

Gilad Chaplik has submitted this change and it was merged. Change subject: userportal : Events sorting - oldest first ...................................................................... userportal : Events sorting - oldest first Incorrect sorting of events in user portal. The events are not sorted in any particular order resulting in newer events being displayed after older ones. Change-Id: I93eeae05af9d07ad1fea0f3ee9c0dee9c8023f81 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=907421 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/events/EventListModel.java 1 file changed, 10 insertions(+), 0 deletions(-) Approvals: Ravi Nori: Verified Gilad Chaplik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12181 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I93eeae05af9d07ad1fea0f3ee9c0dee9c8023f81 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Change move to quota enforcing mode message
by dfediuck＠redhat.com 19 Feb '13

19 Feb '13

Doron Fediuck has submitted this change and it was merged. Change subject: webadmin: Change move to quota enforcing mode message ...................................................................... webadmin: Change move to quota enforcing mode message The message presented when moving the DC into enforcing quota mode was rephrased. Change-Id: Ie24d00f6523d4600962820ff2b88ed4eaf60443f Bug-Url: https://bugzilla.redhat.com/903684 Signed-off-by: Ofri Masad <omasad(a)redhat.com> --- M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Doron Fediuck: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12163 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie24d00f6523d4600962820ff2b88ed4eaf60443f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <omasad(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Fix Quota accounting for move disk
by gchaplik＠redhat.com 19 Feb '13

19 Feb '13

Gilad Chaplik has submitted this change and it was merged. Change subject: core: Fix Quota accounting for move disk ...................................................................... core: Fix Quota accounting for move disk When moving a disk without changing a quota the quota check is not performed. This is a problem since the quota can be specific for each storage domain. The logic was changed to support quota change even if quota id was not changed. Change-Id: I33a6a409388622bb0ab14644445a187357ce5fa2 Bug-Url: https://bugzilla.redhat.com/906499 Signed-off-by: Ofri Masad <omasad(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommand.java 2 files changed, 0 insertions(+), 8 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12159 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I33a6a409388622bb0ab14644445a187357ce5fa2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <omasad(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: engine-setup avoid traceback when loading iso
by juan.hernandez＠redhat.com 19 Feb '13

19 Feb '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: engine-setup avoid traceback when loading iso ...................................................................... packaging: engine-setup avoid traceback when loading iso In engine-setup, _loadFilesToIsoDomain now try to copy the iso files provided by possibly installed rpm into the configured ISO domain only if they exists avoiding useless traceback in the log. Change-Id: Ic995c3bee295b964d2f6a729e4d4fb750eb6b4b5 Bug-Url: https://bugzilla.redhat.com/904763 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M packaging/fedora/setup/engine-setup.py 1 file changed, 8 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Verified Juan Hernandez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12207 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic995c3bee295b964d2f6a729e4d4fb750eb6b4b5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine-cli[cli_3.2]: cli: release 3.2.0.10-1
by mpastern＠redhat.com 19 Feb '13

19 Feb '13

Michael Pasternak has submitted this change and it was merged. Change subject: cli: release 3.2.0.10-1 ...................................................................... cli: release 3.2.0.10-1 Change-Id: Idfe3920a2563b1d23e915e68b81e56ccfe73fe08 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M Makefile M ovirt-engine-cli.spec.in M setup.py 3 files changed, 6 insertions(+), 2 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12208 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idfe3920a2563b1d23e915e68b81e56ccfe73fe08 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: cli_3.2 Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: patterned pool names support
by ofrenkel＠redhat.com 19 Feb '13

19 Feb '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: patterned pool names support ...................................................................... core: patterned pool names support This patch contains the backend part of patterned pool names support. the user can specify inside a pool name a mask for the indexes that are included in the generated names of the VMs in the pool. that way, the user can determine a fixed-length to the generated VM names. The mask is a sequence of question-marks. the mask will be replaced with a zero-padded number in the length of the mask corredponding to the index of the VM in the pool, in the generate VM names. for example, for the patterned pool name 'my???pool', the generated names of the VMs will be: my01pool, my02pool, ... , my999pool (it's the user's responsibility not to set too many VMs in pool). Change-Id: I81a1ffb6324fb728b2584677dd654ac79b679cd8 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmPool.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/ValidationUtils.java A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/NameForVmInPoolGenerator.java A backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/NameForVmInPoolGeneratorTest.java 5 files changed, 74 insertions(+), 12 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11986 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I81a1ffb6324fb728b2584677dd654ac79b679cd8 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>

1 0

Change in ovirt-engine-sdk[sdk_3.2]: sdk: release 3.2.0.9-1
by mpastern＠redhat.com 19 Feb '13

19 Feb '13

Michael Pasternak has submitted this change and it was merged. Change subject: sdk: release 3.2.0.9-1 ...................................................................... sdk: release 3.2.0.9-1 Change-Id: I8edd0d7e27f00f5f8bb911572b6187012004129d Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M Makefile M ovirt-engine-sdk.spec.in M setup.py 3 files changed, 7 insertions(+), 2 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12205 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8edd0d7e27f00f5f8bb911572b6187012004129d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_3.2 Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0