- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core : increment pool master version only if there's new mas...
by mkublin＠redhat.com 20 Feb '13

20 Feb '13

Michael Kublin has submitted this change and it was merged. Change subject: core : increment pool master version only if there's new master ...................................................................... core : increment pool master version only if there's new master When incrementing the pool master version, it should be incremented only when there is a new master otherwise we might not be able to use the pool again/perform unneeded reconstructs. Incrementing the version always can be hazardous, an example is when we have a pool with one domain which we deactivate, master version will be incremented and then we won't be able to perform ConnectStoragePool (as we will have now different master version in engine compared to vdsm), reconstruct will also fail as there are no active domains and we won't be able to have the pool operational again. Change-Id: Ib292802ee2b7feeb95656d492f75dde549350c48 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12214 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib292802ee2b7feeb95656d492f75dde549350c48 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core:sorting of VMs changes during refresh
by emesika＠redhat.com 20 Feb '13

20 Feb '13

Eli Mesika has submitted this change and it was merged. Change subject: core:sorting of VMs changes during refresh ...................................................................... core:sorting of VMs changes during refresh Adding a default secondary sort that insures that if another sort is used all entities are sorted with entity name as a secondary field. In case no sort is used explicitly, the entity name is used as before Change-Id: If82b26f8b648abbce3a8337eb0ccb1212a268116 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxChecker.java 1 file changed, 9 insertions(+), 2 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11944 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If82b26f8b648abbce3a8337eb0ccb1212a268116 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Hiding Confirm host reboot in Gluster mode
by sanjal＠redhat.com 20 Feb '13

20 Feb '13

Shireesh Anjal has submitted this change and it was merged. Change subject: webadmin: Hiding Confirm host reboot in Gluster mode ...................................................................... webadmin: Hiding Confirm host reboot in Gluster mode If the Application is running in 'GlusterOnly' mode, 'Confirm host rebooted' action will be hidden. Change-Id: Ib2970eb5c5a88679f449633ba9ae7a342024e6a7 Bug-Url: https://bugzilla.redhat.com/879004 Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabHostView.java 1 file changed, 9 insertions(+), 7 deletions(-) Approvals: Shireesh Anjal: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12152 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib2970eb5c5a88679f449633ba9ae7a342024e6a7 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: skip CPU checks while updating gluster cluster
by sanjal＠redhat.com 20 Feb '13

20 Feb '13

Shireesh Anjal has submitted this change and it was merged. Change subject: engine: skip CPU checks while updating gluster cluster ...................................................................... engine: skip CPU checks while updating gluster cluster While updating a cluster which supports gluster(doesn't support virt), none of the cpu related checks will be performed. Change-Id: I7ed98b2cdbcc3006ea42718497051131cbb55711 Bug-Url: https://bugzilla.redhat.com/902882 Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommand.java 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: Shireesh Anjal: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12218 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7ed98b2cdbcc3006ea42718497051131cbb55711 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: adding missing file for fkvalidator
by emesika＠redhat.com 20 Feb '13

20 Feb '13

Eli Mesika has submitted this change and it was merged. Change subject: core: adding missing file for fkvalidator ...................................................................... core: adding missing file for fkvalidator This file was missing when committing the fkvalidaor move from dbscripts to dbutils. Change-Id: Id30fd1437d479049ab3cfc55e3f87e2d5af56f9e Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- A backend/manager/tools/dbutils/common.sh 1 file changed, 22 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12225 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id30fd1437d479049ab3cfc55e3f87e2d5af56f9e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove JBoss specific logging from bll
by amureini＠redhat.com 20 Feb '13

20 Feb '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove JBoss specific logging from bll ...................................................................... core: Remove JBoss specific logging from bll Removed the usage of JBoss specific implementation from bll tests' logging configuration and replaced it with standard log4j configuration for better portability and simplicity. Change-Id: I6988196004df741f37ce4971327c005e068cca5b Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/pom.xml M backend/manager/modules/bll/src/test/resources/log4j.xml 2 files changed, 9 insertions(+), 26 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12168 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6988196004df741f37ce4971327c005e068cca5b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove unused JARs from bll's pom.xml
by amureini＠redhat.com 20 Feb '13

20 Feb '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove unused JARs from bll's pom.xml ...................................................................... core: Remove unused JARs from bll's pom.xml Removed a bunch of JAR dependencies from bll's pom.xml file. These dependencies were probably required when we had integration tests on an embedded JBoss. Since these tests are long gone, there is no reason to hang on to their dependencies. Change-Id: I3312c854bf9da0236f42ad559015ff71d1a08aea Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/pom.xml 1 file changed, 0 insertions(+), 55 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12167 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3312c854bf9da0236f42ad559015ff71d1a08aea Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Make connection timeout configurable
by dfediuck＠redhat.com 20 Feb '13

20 Feb '13

Doron Fediuck has submitted this change and it was merged. Change subject: core: Make connection timeout configurable ...................................................................... core: Make connection timeout configurable The timeout that we currently use to connect to hosts is by default very large, as it is the same we use for VDSM operations. The default is 180 seconds but waiting that long for connections is not very reasonable, as establishing a connection is a quick operation, specially in a high speed local network. This large timeout severely affects the high availability support, as it means that we need to wait at least 6 minutes (we need at least 2 failures in a row) when a host fails and starts dropping packets before we can declare it failed and start the recovery process. This patch introduces two new parameters that control the time that it takes to react when there are connection issues: 1. vdsConnectionTimeout (default is 3 minutes) Timeout for establishment of connections with hosts. This should be quite small, a few seconds at most, as it the TCP handshake with hosts should be very quick in most networks. At the moment we are using 3 minutes in order to preserve the behaviour before this modification, but this will probably be changed to a much smaller value (2 seconds, for example) in the future. 2. vdsRetries (default is 3) The number of times to retry host operations when there are IO errors. The default value is 3 to match the default value of the XML RPC library that we use, so there is no change in behaviour. Bug-Url: https://bugzilla.redhat.com/863211 Change-Id: I55a49ae5d655c2105c5840decec81ae712e40c32 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/xmlrpc/XmlRpcUtils.java M backend/manager/tools/src/main/conf/engine-config.properties 6 files changed, 72 insertions(+), 5 deletions(-) Approvals: Doron Fediuck: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8410 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I55a49ae5d655c2105c5840decec81ae712e40c32 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Noam Slomianko <nslomian(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Yaniv Kaul <ykaul(a)redhat.com>

1 0

Change in ovirt-engine[engine_3.1]: restapi: if filter: header is set, use query instead of sear...
by mpastern＠redhat.com 20 Feb '13

20 Feb '13

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: if filter: header is set, use query instead of search (#882946) ...................................................................... restapi: if filter: header is set, use query instead of search (#882946) When the filter option is specified the api query should not throw a insufficient permissions exception. Instead the query should return a list of objects that the user has permissions for. Change-Id: I00eeb96515cb50431f73f8fc66d2730b143f14af Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=882946 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmPoolsResource.java 1 file changed, 12 insertions(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved Ravi Nori: Verified -- To view, visit http://gerrit.ovirt.org/12088 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I00eeb96515cb50431f73f8fc66d2730b143f14af Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.1 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: if filter: header is set, use query instead of sear...
by mpastern＠redhat.com 20 Feb '13

20 Feb '13

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: if filter: header is set, use query instead of search (#869334) ...................................................................... restapi: if filter: header is set, use query instead of search (#869334) When the filter option is specified the api query should not throw a insufficient permissions exception. Instead the query should return a list of objects that the user has permissions for. Change-Id: I0051d10458fe85cf6660f09ce4efca1aa7c2d952 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=869334 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmPoolsResource.java 2 files changed, 13 insertions(+), 2 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12087 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0051d10458fe85cf6660f09ce4efca1aa7c2d952 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0