- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: minor CommandBase change for rename logging
by lhornyak＠redhat.com 18 Feb '13

18 Feb '13

Laszlo Hornyak has submitted this change and it was merged. Change subject: engine: minor CommandBase change for rename logging ...................................................................... engine: minor CommandBase change for rename logging - catching Exception is removed - added junit test for the new method Change-Id: I8b437192af2635a133d1636c2ede39eb91a51c71 Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CommandBaseTest.java 2 files changed, 52 insertions(+), 17 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11981 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8b437192af2635a133d1636c2ede39eb91a51c71 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Cannot add network to VM when dc have bridgeless m...
by alkaplan＠redhat.com 18 Feb '13

18 Feb '13

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Cannot add network to VM when dc have bridgeless mgmnt network ...................................................................... webadmin: Cannot add network to VM when dc have bridgeless mgmnt network If the management network is brigeless it is not in the vm network list. If there are no other networks in the list it gets to the last "null" network and caused NPE. Change-Id: I9f844fde815c00dff441192d9e977e4c23615ce3 Bug-Url: https://bugzilla.redhat.com/911115 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewVmInterfaceModel.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12139 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9f844fde815c00dff441192d9e977e4c23615ce3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: gluster: resolve hostname before checking ip in db
by sanjal＠redhat.com 18 Feb '13

18 Feb '13

Shireesh Anjal has submitted this change and it was merged. Change subject: gluster: resolve hostname before checking ip in db ...................................................................... gluster: resolve hostname before checking ip in db At two places, we are checking if a server with given ip address exists in the engine DB. However it is possible that the value passed is a hostname, and it's not same as what is present in the host_name field. To handle such cases, modified the code to make sure that we resolve the given ip/hostname, and check for the resolved ip addr in db. As part of this change, performed following refactoring: - Renamed GlusterUtils to GlusterDBUtils and moved it to dao module - Modified the test case in GetAddedGlusterServersQueryTest accordingly Change-Id: Iab25afc5cb0acb5be288c005d1110c1ad0a54b2d Signed-off-by: Shireesh Anjal <sanjal(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVDSClusterCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetAddedGlusterServersQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StartGlusterVolumeCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StopGlusterVolumeCommand.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/GlusterUtils.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GetAddedGlusterServersQueryTest.java A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterDBUtils.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterVolumesListReturnForXmlRpc.java 9 files changed, 155 insertions(+), 151 deletions(-) Approvals: Shireesh Anjal: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12021 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iab25afc5cb0acb5be288c005d1110c1ad0a54b2d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Changes in VdsStaticDAO
by sanjal＠redhat.com 18 Feb '13

18 Feb '13

Shireesh Anjal has submitted this change and it was merged. Change subject: engine: Changes in VdsStaticDAO ...................................................................... engine: Changes in VdsStaticDAO Since there is a unique constraint on host_name now, the method getAllForHostname() doesn't make sense any more. Hence replaced it with getByHostName() that returns a single object Change-Id: I0075430a97f19238b93da1e199fa73a4584556d6 Signed-off-by: Shireesh Anjal <sanjal(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterServersForImportQuery.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GetGlusterServersForImportQueryTest.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsStaticDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsStaticDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdsStaticDAOTest.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterVolumesListReturnForXmlRpc.java 7 files changed, 34 insertions(+), 38 deletions(-) Approvals: Shireesh Anjal: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12052 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0075430a97f19238b93da1e199fa73a4584556d6 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: minor change for Handler cleanup
by lhornyak＠redhat.com 18 Feb '13

18 Feb '13

Laszlo Hornyak has submitted this change and it was merged. Change subject: minor change for Handler cleanup ...................................................................... minor change for Handler cleanup AddPermittedField was almost only invoked from AddPermittedFields, so its content can be inlined Change-Id: I4f101c7dc3bae5277c8755a7920ff4bb7c380d24 Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ObjectIdentityChecker.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ObjectIdentityCheckerTest.java 4 files changed, 4 insertions(+), 8 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11963 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4f101c7dc3bae5277c8755a7920ff4bb7c380d24 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>

1 0

Change in ovirt-engine-sdk[master]: codegen: implement generic URI processing
by mpastern＠redhat.com 18 Feb '13

18 Feb '13

Michael Pasternak has submitted this change and it was merged. Change subject: codegen: implement generic URI processing ...................................................................... codegen: implement generic URI processing Change-Id: I36d3914a0b8f639d0d6a32d1cc3ef18e6fb63541 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M src/codegen/rsdl/rsdlcodegen.py M src/ovirtsdk/infrastructure/brokers.py 2 files changed, 53 insertions(+), 18 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12162 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I36d3914a0b8f639d0d6a32d1cc3ef18e6fb63541 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Fix test break in LiveMigrateVmDisksCommand
by derez＠redhat.com 18 Feb '13

18 Feb '13

Daniel Erez has submitted this change and it was merged. Change subject: core: Fix test break in LiveMigrateVmDisksCommand ...................................................................... core: Fix test break in LiveMigrateVmDisksCommand Change-Id Ifefe823faa8e546eba3e9d34c4b46609085baad8 changed the semantics of how storage domains were validated, which broke the unit test. This patch mocks the storage domain ID on the image correctly, so the test can continue functioning. Change-Id: I79162cffafcfd385fdced56e23e6e005828c21f9 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommandTest.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12161 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I79162cffafcfd385fdced56e23e6e005828c21f9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: AsyncTask manger part 2 - vms scenario
by mkublin＠redhat.com 18 Feb '13

18 Feb '13

Michael Kublin has submitted this change and it was merged. Change subject: engine: AsyncTask manger part 2 - vms scenario ...................................................................... engine: AsyncTask manger part 2 - vms scenario The following fix should solve a following paroblem: 1. Part of vm scenarios are creating async task with out parent and child task thats why appropriate check should be added to EntityAsyncTask 2. Fixing also VdcActionParametersBase accordingly, because of imageParameters are not passed to DB Change-Id: I43320dfb32a2477308cd881cb7d27c49f3f9f346 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AsyncTaskManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/EntityAsyncTask.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionParametersBase.java 4 files changed, 16 insertions(+), 29 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12156 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I43320dfb32a2477308cd881cb7d27c49f3f9f346 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Fix audit log for network on multiple interfaces
by masayag＠redhat.com 18 Feb '13

18 Feb '13

Moti Asayag has submitted this change and it was merged. Change subject: engine: Fix audit log for network on multiple interfaces ...................................................................... engine: Fix audit log for network on multiple interfaces The patch fixes the place holder name inside the properties file to be a correlated with the parameter within the code. Change-Id: Ibda3f6e6d78a0fed2ea2b5d7879d717f859793e8 Bug-Url: https://bugzilla.redhat.com/881055 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java 2 files changed, 2 insertions(+), 3 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12155 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibda3f6e6d78a0fed2ea2b5d7879d717f859793e8 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Refactoring in unassign network from cluster command
by mkolesni＠redhat.com 18 Feb '13

18 Feb '13

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Refactoring in unassign network from cluster command ...................................................................... engine: Refactoring in unassign network from cluster command Refactored some code in DetachNetworkToVdsGroupCommand to reuse code from NetworkValidator. As part of the refactoring added to the error message the list of VMs/templates using the network, if it was used, simply by using the internal implementation of the validation in NetworkValidator. Change-Id: I127615d9144084ad093ac1d20841979be8163a12 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=746912 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/DetachNetworkToVdsGroupCommand.java 1 file changed, 38 insertions(+), 67 deletions(-) Approvals: Mike Kolesnik: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/10683 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I127615d9144084ad093ac1d20841979be8163a12 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>

1 0