- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: Refactored code into NetworkValidator class
by mkolesni＠redhat.com 18 Feb '13

18 Feb '13

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Refactored code into NetworkValidator class ...................................................................... engine: Refactored code into NetworkValidator class The NetworkValidator class handles network validation on the data center level, and is instantiated on a per-network basis. This validation had previously been performed by the NetworkCommon class and its derived classes, but now the NetworkValidator may be used as a service provider. A corresponding test class is added. While refactoring fixed inconsistency bug related to add/update network commands. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=905479 Change-Id: Icf40d81f0481c6b6dec141a71363888dc9e9a941 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/AddNetworkCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/NetworkCommon.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/RemoveNetworkCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UpdateNetworkCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/NetworkValidator.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/NetworkValidatorTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddNetworkStoragePoolParameters.java 7 files changed, 582 insertions(+), 201 deletions(-) Approvals: Mike Kolesnik: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/10940 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icf40d81f0481c6b6dec141a71363888dc9e9a941 Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Failed to add VM network interface from User Porta...
by alkaplan＠redhat.com 18 Feb '13

18 Feb '13

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Failed to add VM network interface from User Portal ...................................................................... webadmin: Failed to add VM network interface from User Portal ConfigurationValues.ManagementNetwork doesn't have ConfigAuthType.User. It means user role can't determine this value. The user shouldn't know what is the management network. If the management network can't be determined the default network should be the first network in the list. Change-Id: I77a15bd0d9d290c8f7e2673f0e0039d70f125c1b Bug-Url: https://bugzilla.redhat.com/912005 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewVmInterfaceModel.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12137 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I77a15bd0d9d290c8f7e2673f0e0039d70f125c1b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Cleanup of GetSystemStatisticsQuery
by tnisan＠redhat.com 18 Feb '13

18 Feb '13

Tal Nisan has submitted this change and it was merged. Change subject: core: Cleanup of GetSystemStatisticsQuery ...................................................................... core: Cleanup of GetSystemStatisticsQuery Replaced all hard coded strings with contstants, extracted logic to separate methods, renamed variables by Java standard and other minor changes Change-Id: Ibb87448c24c6ac32838ae2e381856f478c27ea52 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetSystemStatisticsQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/constants/QueryConstants.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacade.java 3 files changed, 77 insertions(+), 77 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12145 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibb87448c24c6ac32838ae2e381856f478c27ea52 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core, restapi: Replaced system stats query fields with const...
by tnisan＠redhat.com 18 Feb '13

18 Feb '13

Tal Nisan has submitted this change and it was merged. Change subject: core, restapi: Replaced system stats query fields with constants ...................................................................... core, restapi: Replaced system stats query fields with constants Replaced the hard coded String fields returning in GetSystemStatistics query to constants, also changed the call to this query in the REST to use the contstants when parsing the result Change-Id: I1a2e3fc22c4c8228ec9362d1fb2a608c4db4746c Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetSystemStatisticsQuery.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/constants/QueryConstants.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendApiResource.java 3 files changed, 40 insertions(+), 19 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12143 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1a2e3fc22c4c8228ec9362d1fb2a608c4db4746c Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: MigrateVmDisks - get source domain by disk
by derez＠redhat.com 18 Feb '13

18 Feb '13

Daniel Erez has submitted this change and it was merged. Change subject: core: MigrateVmDisks - get source domain by disk ...................................................................... core: MigrateVmDisks - get source domain by disk LiveMigrateVmDisksCommand - source storage domain should be retrieved from the operated disk instead of the command parameters (only a disk that resides on a single storage domain can be moved). Change-Id: Ifefe823faa8e546eba3e9d34c4b46609085baad8 Bug-Url: https://bugzilla.redhat.com/883871 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommand.java 1 file changed, 9 insertions(+), 11 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12147 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifefe823faa8e546eba3e9d34c4b46609085baad8 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Fix UpdateVm permissions check for Quota
by gchaplik＠redhat.com 18 Feb '13

18 Feb '13

Gilad Chaplik has submitted this change and it was merged. Change subject: core: Fix UpdateVm permissions check for Quota ...................................................................... core: Fix UpdateVm permissions check for Quota Quota permissions were checked regardless of the vm state (running/stopped), the quota enforcement mode (Audit/enforcing) and the change in quota selection box. addQuotaPermissionSubject was change to check for quota consumption permissions only if the quota was changed & quota is Enforced & vm is running. Otherwise, User could edit vm without having quota consumption permissions. Change-Id: Ib55016efcbed22b003eaddf5c4f8f62aec88928e Bug-Url: https://bugzilla.redhat.com/904105 Signed-off-by: Ofri Masad <omasad(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java 2 files changed, 14 insertions(+), 3 deletions(-) Approvals: ofri masad: Verified Gilad Chaplik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11418 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib55016efcbed22b003eaddf5c4f8f62aec88928e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <omasad(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: core:Use audit log on disk finish action
by mlipchuk＠redhat.com 18 Feb '13

18 Feb '13

Maor Lipchuk has submitted this change and it was merged. Change subject: core:Use audit log on disk finish action ...................................................................... core:Use audit log on disk finish action Direct lun disk should only log it finished the action, since there is no use of tasks in the process. We also should log when remove disk ends for all type of disks. Change-Id: I22b145fbc12481e40eaa8329eb8ce35f7c39a320 Bug-Url: https://bugzilla.redhat.com/910693 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java 3 files changed, 21 insertions(+), 4 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12011 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I22b145fbc12481e40eaa8329eb8ce35f7c39a320 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: liron aravot <liron.aravot(a)gmail.com>

1 0

Change in ovirt-engine[master]: engine: AsyncTaskManager - restart fix part 1 (Logic)
by mkublin＠redhat.com 18 Feb '13

18 Feb '13

Michael Kublin has submitted this change and it was merged. Change subject: engine: AsyncTaskManager - restart fix part 1 (Logic) ...................................................................... engine: AsyncTaskManager - restart fix part 1 (Logic) The following fix should change a current behaviour which is: During creation child command which is asynchronious a parameters of parent command are saved in DB (this ok), but parameters of parent comand also contains a list of parameters of child commands (sic!). So a first child command created we save a parent command with list of one command, second command created list with two commands and etc... After a restart and random child is choosen, so we have a random number of child parameters. By the way , if list of child parameters is updated after saving a task to db, we will never have a correct list (Example can be seen in one of the next patches) Solution, save to DB parent parameters and appropriate child command parameter, during endAction() bnuild a list of parameters. One of the known bugs (a lot of unknown): During preview on vm after all task are send to host, perform restart. All task are send, all task finished successfully, but disk still left in status Locked and the number of disks is random Benefits: 1. Bug is solved 2. Reduced serialization and desirialization (by current situation we have O(n^2) serialization/deserialization operations) 3. Most of the logic moved to the same place, no need to copy paste it all over a project 4. No need to make work arounds all over a project What is still not solved: If we will fail in the middle of task creation, we will not know if all task that we have that all tak that we wanted to start, the fix is easy and will be send soon Change-Id: I06507f537b2de0dc358a59aa27e62cbb042ccbb1 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AsyncTaskFactory.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AsyncTaskManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/EntityAsyncTask.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/asynctasks/AsyncTaskParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/AsyncTasks.java 6 files changed, 40 insertions(+), 19 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12128 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I06507f537b2de0dc358a59aa27e62cbb042ccbb1 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: AsyncTaskManager - fix restart part 1 (DB)
by mkublin＠redhat.com 18 Feb '13

18 Feb '13

Michael Kublin has submitted this change and it was merged. Change subject: engine: AsyncTaskManager - fix restart part 1 (DB) ...................................................................... engine: AsyncTaskManager - fix restart part 1 (DB) The following patch contains a changes for DB schema which is required in order to solve a problem. The changes are: added a new two collums to async_task table. Those columns are respresenting a parameters of command which is associated with task Change-Id: I3beb5c4a675c567abdf789f40c26fd9fa0a1fb4d Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/dbscripts/async_tasks_sp.sql A backend/manager/dbscripts/upgrade/03_02_0460_add_async_task_task_parameters.sql M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AsyncTaskDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/AsyncTaskDAOTest.java 4 files changed, 41 insertions(+), 11 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12129 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3beb5c4a675c567abdf789f40c26fd9fa0a1fb4d Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: AsyncTaskManager - fix restart part 1 (Clean ups)
by mkublin＠redhat.com 18 Feb '13

18 Feb '13

Michael Kublin has submitted this change and it was merged. Change subject: engine: AsyncTaskManager - fix restart part 1 (Clean ups) ...................................................................... engine: AsyncTaskManager - fix restart part 1 (Clean ups) The following patch contains a clean ups, the following code is not needed anymore after introducing a fix. Also at some classes like AddVmFromTemplateCommand we can see that child parameters are added to list only after persist of the task to DB, so after a restart we will never have a task which have a parent parameters with all list of child parameters (sic!) Change-Id: I2c8c26b79df08a139c6bd19b28dd376ba69829ca Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmAndCloneImageCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreAllSnapshotsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TryBackToAllSnapshotsOfVmCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionParametersBase.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/asynctasks/IEndedTaskVisitor.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/asynctasks/SetTaskGroupStatusVisitor.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/serialization/json/JsonVdcActionParametersBaseMixIn.java 20 files changed, 6 insertions(+), 62 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12130 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2c8c26b79df08a139c6bd19b28dd376ba69829ca Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0