- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Add VDSM missing error messages.
by mlipchuk＠redhat.com 18 Feb '13

18 Feb '13

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Add VDSM missing error messages. ...................................................................... core: Add VDSM missing error messages. Add missing VDSM messages to the engine. After this fix, ReleaseLockFailure and AcquireHostIdFailure will cause fail over, while the other errors will not. Change-Id: Id8395c75bbba1f66d08bcd9c21fdeacc7f5e6d4f Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllErrors.java M backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ConnectStoragePoolVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ConnectStorageServerVDSCommand.java 4 files changed, 37 insertions(+), 1 deletion(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8958 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id8395c75bbba1f66d08bcd9c21fdeacc7f5e6d4f Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Add storage space validation to removeSnapshot
by mlipchuk＠redhat.com 18 Feb '13

18 Feb '13

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Add storage space validation to removeSnapshot ...................................................................... core: Add storage space validation to removeSnapshot Today there is no validation in RemoveSnapshotCommand to ensure there is enough space on the domain to merge the disk snapshots. This space is needed on remove snapshot process since VDSM creates a new temporary volume, as part of the merge process, which might be large as the volume's actual size. The proposed fix introduces a new validation in the command which validates whether each storage domain has enough free space to perform removeSnapshot. Change-Id: Ifbebc5af8e7489bccfa5d8e79695fe21c5371ec9 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/StorageDomainValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RemoveSnapshotCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/StorageDomainValidatorTest.java 4 files changed, 217 insertions(+), 3 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11849 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifbebc5af8e7489bccfa5d8e79695fe21c5371ec9 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: remove unneeded set of parameters member
by tnisan＠redhat.com 18 Feb '13

18 Feb '13

Tal Nisan has submitted this change and it was merged. Change subject: core: remove unneeded set of parameters member ...................................................................... core: remove unneeded set of parameters member During ImportVm, the addStorageDomainMapping flag is set without need, it's ignored during the execute phase of move or copy all image group command when the parent command is import vm command and can cause to unneeded deletion of source image mapping during the endWithFailure method. Change-Id: I55bed0b63faef266cfc30fd8193238ee9dc1163d Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12151 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I55bed0b63faef266cfc30fd8193238ee9dc1163d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Added LexoNumericComparator utility
by mkolesni＠redhat.com 18 Feb '13

18 Feb '13

Mike Kolesnik has submitted this change and it was merged. Change subject: core: Added LexoNumericComparator utility ...................................................................... core: Added LexoNumericComparator utility This utility helps to sort strings which include numeric subsequences according to sensible ordering - sorting numeric subsequences numerically, and the rest lexicographically. A corresponding test class is added. Change-Id: I8c68446ea6f1865a51455a0a359df339bfb15bba Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/LexoNumericComparator.java A backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/LexoNumericComparatorTest.java 2 files changed, 179 insertions(+), 0 deletions(-) Approvals: Mike Kolesnik: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/11996 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8c68446ea6f1865a51455a0a359df339bfb15bba Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine-cli[master]: cli: ovirt-shell misleading help for command "connect"(#9079...
by mpastern＠redhat.com 18 Feb '13

18 Feb '13

Michael Pasternak has submitted this change and it was merged. Change subject: cli: ovirt-shell misleading help for command "connect"(#907943) ...................................................................... cli: ovirt-shell misleading help for command "connect"(#907943) ovirt-shell does not allow the use of show command before being connected to the engine. The help connect message however has refernce to see show command for more details. This patch corrects the help message for connect by removing the refernce to the show command Change-Id: Ifcea649dcd44c87c9f9dff0fa4b65ac9c2449c32 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=907943 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M src/ovirtcli/command/connect.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11939 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifcea649dcd44c87c9f9dff0fa4b65ac9c2449c32 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Database restore script complains about ...
by emesika＠redhat.com 18 Feb '13

18 Feb '13

Eli Mesika has submitted this change and it was merged. Change subject: core: Database restore script complains about ... ...................................................................... core: Database restore script complains about ... Database restore script complains about existing entries and fails horribly This patch fixes a bug when restoring an existing DB. The problem was that "Drop Database" command was used while it was executed from the active database, it caused the drop to fail since some objects were locked and the restore generated lots of error while trying to create duplicate objects. Solution is to use the built-in dropdb function instead the "Drop Database" SQL statement. Change-Id: I636f269e1f6094e7fc7f55ab7fddacf6a33926ba Signed-off-by: Eli Mesika <emesika(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=910748 --- M backend/manager/dbscripts/restore.sh 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12146 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I636f269e1f6094e7fc7f55ab7fddacf6a33926ba Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: RemoveVm: no image checks for LUN based VMs
by amureini＠redhat.com 18 Feb '13

18 Feb '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: RemoveVm: no image checks for LUN based VMs ...................................................................... core: RemoveVm: no image checks for LUN based VMs Since now ImagesHandler.PerformImagesChecks no longer handles VM-level validations, it's possible to skip it altogether if the VM has no image disks (i.e., no disks at all, or just LUN disks) associated with it. Note: This refactoring is a step in a long series of patches intended to completely remove PerformImagesChecks. Change-Id: Ief6ebb5d3d5b23075424acc92a616f2d7e338170 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java 1 file changed, 6 insertions(+), 3 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12144 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ief6ebb5d3d5b23075424acc92a616f2d7e338170 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-host-deploy[ovirt-host-deploy-1.0]: packaging: update ChangeLog
by Alon Bar-Lev 17 Feb '13

17 Feb '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: packaging: update ChangeLog ...................................................................... packaging: update ChangeLog Change-Id: If3d86ad8054e026004ae89fe7d194db5fbfc2878 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ChangeLog 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12142 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If3d86ad8054e026004ae89fe7d194db5fbfc2878 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: ovirt-host-deploy-1.0 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in ovirt-host-deploy[master]: doc: update ChangeLog
by Alon Bar-Lev 17 Feb '13

17 Feb '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: doc: update ChangeLog ...................................................................... doc: update ChangeLog Change-Id: I07feb23fef23a38725a8a7f60d961d508640be59 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ChangeLog 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12141 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I07feb23fef23a38725a8a7f60d961d508640be59 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: fix typo in java comment
by gchaplik＠redhat.com 17 Feb '13

17 Feb '13

Gilad Chaplik has submitted this change and it was merged. Change subject: core: fix typo in java comment ...................................................................... core: fix typo in java comment /s/MultipleActinosRunner/MultipleActionsRunner Change-Id: I071dda2aeb05c709cae36f663a4b74acf4757ba1 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmDelayer.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8875 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I071dda2aeb05c709cae36f663a4b74acf4757ba1 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>

1 0