- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: moving VM with empty nic to unsupported cluster shou...
by alkaplan＠redhat.com 14 Feb '13

14 Feb '13

Alona Kaplan has submitted this change and it was merged. Change subject: engine: moving VM with empty nic to unsupported cluster should be blocked ...................................................................... engine: moving VM with empty nic to unsupported cluster should be blocked When moving VM with empty nic (no network) from cluster 3.2 to cluster 3.1 the VM have nic without network on cluster 3.1. This patch blocks it by canDoAction. Change-Id: Ic94c4b06b42675e4c5fe28317b38a3590d8fbe79 Bug-Url: https://bugzilla.redhat.com/909834 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVMClusterCommand.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 5 files changed, 11 insertions(+), 10 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11988 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic94c4b06b42675e4c5fe28317b38a3590d8fbe79 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: BackendVmDisksResource cleanup
by mpastern＠redhat.com 14 Feb '13

14 Feb '13

Michael Pasternak has submitted this change and it was merged. Change subject: core: BackendVmDisksResource cleanup ...................................................................... core: BackendVmDisksResource cleanup Avoided if-else clause in attachDiskToVm(). Change-Id: Iea65c24b84d99654dea6bbfeabde1bf0a90ec65e Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmDisksResource.java 1 file changed, 6 insertions(+), 10 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10350 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iea65c24b84d99654dea6bbfeabde1bf0a90ec65e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi : vm/template Import candidates should have /disks (...
by mpastern＠redhat.com 14 Feb '13

14 Feb '13

Michael Pasternak has submitted this change and it was merged. Change subject: restapi : vm/template Import candidates should have /disks (#829672) ...................................................................... restapi : vm/template Import candidates should have /disks (#829672) When importing vm/template via api only import candidate metadata is visible (disks are not). This patch exposes the disks subcollection of vm/template in the export domain. Change-Id: I83fd4b046f72f73bb516615137522ac40028a7f0 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=829672 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetTemplatesFromExportDomainQuery.java A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/StorageDomainContentDiskResource.java A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/StorageDomainContentDisksResource.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/StorageDomainContentResource.java M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendStorageDomainContentResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendExportDomainDiskResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendExportDomainDisksResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainTemplateResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainVmResource.java A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendExportDomainDiskResourceTest.java A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendExportDomainDisksResourceTest.java 12 files changed, 703 insertions(+), 4 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11126 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I83fd4b046f72f73bb516615137522ac40028a7f0 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Make IVdcUser extend Serializable
by amureini＠redhat.com 14 Feb '13

14 Feb '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Make IVdcUser extend Serializable ...................................................................... core: Make IVdcUser extend Serializable Define IVdcUser as extends Serializeable so Serializable classes code inspection (such as FindBugs) applied to classes containing it do not fret about a Serializable class with a non Serializable member. Note that this does not change the current behaviour, as VdcUser, the only known implementation of IVdcUser in fact implements Seriazlizable. Change-Id: Id02c1f62fe3406ee0bceaf75cb9d79ce034e4a4d Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/interfaces/IVdcUser.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/users/VdcUser.java 2 files changed, 6 insertions(+), 4 deletions(-) Approvals: Michael Kublin: Looks good to me, approved Allon Mureinik: Verified -- To view, visit http://gerrit.ovirt.org/11905 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id02c1f62fe3406ee0bceaf75cb9d79ce034e4a4d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Change Storage Domain description validation to ValidD...
by tnisan＠redhat.com 13 Feb '13

13 Feb '13

Tal Nisan has submitted this change and it was merged. Change subject: core: Change Storage Domain description validation to ValidDescription ...................................................................... core: Change Storage Domain description validation to ValidDescription Change the validation of Storage Domain description field to ValidDescription instead of ValidName, the description can contain special characters which the name cannot Change-Id: I5d8fb4f12cd74c376c27eab9dc939b56d9fc6da1 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomainStatic.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java 2 files changed, 3 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12037 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5d8fb4f12cd74c376c27eab9dc939b56d9fc6da1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: fixing a duplicate upgrade script
by emesika＠redhat.com 13 Feb '13

13 Feb '13

Eli Mesika has submitted this change and it was merged. Change subject: core: fixing a duplicate upgrade script ...................................................................... core: fixing a duplicate upgrade script Change-Id: I5376185ec8a143539602acbf334ac15ba812669d Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- R backend/manager/dbscripts/upgrade/03_02_0440_materialized_views_extensions.sql 1 file changed, 0 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Verified Shahar Havivi: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12036 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5376185ec8a143539602acbf334ac15ba812669d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Custom Materialized Views should be...
by emesika＠redhat.com 13 Feb '13

13 Feb '13

Eli Mesika has submitted this change and it was merged. Change subject: core: Custom Materialized Views should be... ...................................................................... core: Custom Materialized Views should be... Custom Materialized Views should be treated differently from regular product Materialized Views This patch addresses the following issues: 1) Do not fail the upgrade on custom MV file, rather, revert the custom changes and generate only warnings (need support from integration team) 2) Add custom column to MV table that will easily distinguish between product MV and custom MV. 3) Add active column to temporary disable a MV 4) Refresh options: Defining min refresh flood time in seconds (in the same manner log flood is handled) Change-Id: I6a6857a1691c1dafa1a7edcd58b292e70c78b318 Signed-off-by: Eli Mesika <emesika(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=907232 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/dbscripts/dbfunctions.sh M backend/manager/dbscripts/materialized_views_sp.sql A backend/manager/dbscripts/upgrade/03_02_0400_materialized_views_extensions.sql 3 files changed, 138 insertions(+), 10 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11669 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6a6857a1691c1dafa1a7edcd58b292e70c78b318 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin, userportal: Resize dialogs to fit the screen in 10...
by tnisan＠redhat.com 13 Feb '13

13 Feb '13

Tal Nisan has submitted this change and it was merged. Change subject: webadmin, userportal: Resize dialogs to fit the screen in 1024x768 resolution ...................................................................... webadmin, userportal: Resize dialogs to fit the screen in 1024x768 resolution Resized the VM run once dialog and VM/Template import dialogs to fit the screen in 1024x768 resolution related to https://bugzilla.redhat.com/879324 Change-Id: I126c65ebe1adcd490a09d0fb8961118c0afbde30 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/popup/vm/VmRunOncePopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/backup/ImportVmPopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/vm/VmRunOncePopupView.java 3 files changed, 4 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12007 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I126c65ebe1adcd490a09d0fb8961118c0afbde30 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-reports[master]: packaging: fixed rpm build warning
by ydary＠redhat.com 13 Feb '13

13 Feb '13

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: fixed rpm build warning ...................................................................... packaging: fixed rpm build warning due to package naming change option the rpm build gave warning: 'File listed twice: /usr/bin/ovirt-engine-reports-setup' this fix causes the file to not appear twice. Change-Id: I11de2c5bb5442bc17a34479b5e6b5a53a7b68d38 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M packaging/ovirt-engine-reports.spec.in 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12018 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I11de2c5bb5442bc17a34479b5e6b5a53a7b68d38 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in samples-portals[master]: added views as seperate files
by shavivi＠redhat.com 13 Feb '13

13 Feb '13

Shahar Havivi has submitted this change and it was merged. Change subject: added views as seperate files ...................................................................... added views as seperate files Change-Id: Ie3a37e9304cfd8a2ec9a14b01a942f4cd73730dd Signed-off-by: Ohad Levy <ohadlevy(a)gmail.com> Signed-off-by: Shahar Havivi <shaharh(a)gmail.com> --- A ruby/views/login.html.erb A ruby/views/vms.html.erb M ruby/webhandler.rb 3 files changed, 69 insertions(+), 63 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11562 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie3a37e9304cfd8a2ec9a14b01a942f4cd73730dd Gerrit-PatchSet: 3 Gerrit-Project: samples-portals Gerrit-Branch: master Gerrit-Owner: Ohad Levy <ohadlevy(a)redhat.com> Gerrit-Reviewer: Ohad Levy <ohadlevy(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0